Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | improve CollectionProxy#concat documentation | Francesco Rodriguez | 2012-05-19 | 1 | -7/+18 | |
| | ||||||
* | fix CollectionProxy#<< documentation | Francesco Rodriguez | 2012-05-19 | 1 | -1/+1 | |
| | ||||||
* | add CollectionProxy#<< documentation | Francesco Rodriguez | 2012-05-19 | 1 | -0/+20 | |
| | ||||||
* | add CollectionProxy#clear documentation | Francesco Rodriguez | 2012-05-19 | 1 | -0/+26 | |
| | ||||||
* | add CollectionProxy#include? documentation | Francesco Rodriguez | 2012-05-18 | 1 | -0/+13 | |
| | ||||||
* | move docs from CollectionAssociation to CollectionProxy | Francesco Rodriguez | 2012-05-18 | 1 | -1/+142 | |
| | ||||||
* | Remove #=== quirk | Jon Leighton | 2012-05-11 | 1 | -6/+0 | |
| | | | | Makes it consistent with Relation. Can't see a use for this. | |||||
* | this stuff can all be handled by Relation | Jon Leighton | 2012-05-11 | 1 | -38/+0 | |
| | ||||||
* | extract deprecated code | Jon Leighton | 2012-05-11 | 1 | -8/+1 | |
| | ||||||
* | set_owner_attributes is covered by the scoping | Jon Leighton | 2012-05-11 | 1 | -4/+3 | |
| | ||||||
* | CollectionProxy < Relation | Jon Leighton | 2012-05-11 | 1 | -15/+22 | |
| | | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association. | |||||
* | extract code from AR::Base | Jon Leighton | 2012-05-04 | 1 | -1/+1 | |
| | ||||||
* | clean up implementation of dynamic methods. use method compilation etc. | Jon Leighton | 2012-05-04 | 1 | -3/+3 | |
| | ||||||
* | Fix issue with private kernel methods and collection associations. Closes #2508 | Carlos Antonio da Silva | 2012-05-02 | 1 | -2/+2 | |
| | | | | | | | | Change CollectionProxy#method_missing to use scoped.public_send, to avoid a problem described in issue #2508 when trying to use class methods with names like "open", that clash with private kernel methods. Also changed the dynamic matcher instantiator to send straight to scoped, to avoid another roundtrip to method_missing. | |||||
* | allow AssociationProxy#scoped to take options so that API is the same as ↵ | Jon Leighton | 2012-04-27 | 1 | -2/+6 | |
| | | | | Base#scoped | |||||
* | Define array methods in ActiveRecord::Associations::CollectionProxy | Jorge Bejar | 2012-04-18 | 1 | -0/+13 | |
| | | | | | | if they are not defined or delegated. In this way, we have a performance boost invoking some array methods which are not defined in CollectionAssociation. | |||||
* | Don't instantiate two objects in collection proxy / find_or_instantiator_by | Jonathan del Strother | 2012-01-19 | 1 | -2/+1 | |
| | ||||||
* | Remove Array.wrap calls in ActiveRecord | Rafael Mendonça França | 2012-01-06 | 1 | -1/+1 | |
| | ||||||
* | Fix #3890. (Calling proxy_association in scope chain.) | Jon Leighton | 2011-12-08 | 1 | -2/+8 | |
| | ||||||
* | ActiveRecord::Relation#pluck method | Bogdan Gusiev | 2011-11-30 | 1 | -1/+1 | |
| | ||||||
* | CollectionProxy#replace should change the DB records rather than just ↵ | Jon Leighton | 2011-09-26 | 1 | -1/+1 | |
| | | | | mutating the array. Fixes #3020. | |||||
* | Add a proxy_association method to association proxies, which can be called ↵ | Jon Leighton | 2011-07-27 | 1 | -6/+10 | |
| | | | | by association extensions to access information about the association. This replaces proxy_owner etc with proxy_association.owner. | |||||
* | find(:first) => first | Akira Matsuda | 2011-07-08 | 1 | -1/+1 | |
| | ||||||
* | match method signature of the superclass | Aaron Patterson | 2011-06-30 | 1 | -3/+3 | |
| | ||||||
* | remove warning: assigned but unused variable | Santiago Pastorino | 2011-06-08 | 1 | -1/+1 | |
| | ||||||
* | added an alias for new to build to the AR collection proxy, this corrects an ↵ | Josh Kalderimis | 2011-06-01 | 1 | -8/+2 | |
| | | | | issue where the collection proxies were not consistent | |||||
* | removed deprecated methods, and related tests, from ActiveRecord | Josh Kalderimis | 2011-05-25 | 1 | -24/+0 | |
| | ||||||
* | Implement proxy_owner, proxy_target and proxy_reflection methods on ↵ | Jon Leighton | 2011-05-19 | 1 | -0/+24 | |
| | | | | CollectionProxy with deprecations. Fixes #1148. | |||||
* | Fix for lighthouse #6741 | Nick Howard | 2011-05-01 | 1 | -3/+6 | |
| | | | | | | | - adds tests for find_or_create_by and find_or_initialize_by on has_many associations - changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so find_or_create_by's api on associations will be consistent w/ the api for model classes. | |||||
* | Removing the scope-caching which happens on association proxies, because the ↵ | Jon Leighton | 2011-04-12 | 1 | -2/+0 | |
| | | | | query is already cached by the query cacher. For formalised proof see http://www.youtube.com/watch?v=wDefXLb-FDs | |||||
* | Split AssociationProxy into an Association class (and subclasses) which ↵ | Jon Leighton | 2011-02-18 | 1 | -0/+127 | |
manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more. |