Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | adding requires for constant dependencies | Aaron Patterson | 2012-11-07 | 1 | -0/+3 |
| | |||||
* | Use method compilation for association methods | Jon Leighton | 2012-08-10 | 5 | -64/+62 |
| | | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though. | ||||
* | DRY up handling of dependent option | Jon Leighton | 2012-08-10 | 5 | -63/+22 |
| | |||||
* | Unprivatise all the things | Jon Leighton | 2012-08-10 | 7 | -170/+156 |
| | | | | | | Well, not all of them, but some of them. I don't think there's much reason for these methods to be private. | ||||
* | move dependency logic out of generated methods | Jon Leighton | 2012-08-10 | 4 | -65/+19 |
| | |||||
* | Clean up dependent option validation. | Jon Leighton | 2012-08-10 | 4 | -14/+7 |
| | | | | | We don't need the complexity of to_sentence, and it shouldn't be a bang method. | ||||
* | Remove the dependent_restrict_raises option. | Jon Leighton | 2012-08-10 | 3 | -23/+22 |
| | | | | | | | | | | | | | | | It's not really a good idea to have this as a global config option. We should allow people to specify the behaviour per association. There will now be two new values: * :dependent => :restrict_with_exception implements the current behaviour of :restrict. :restrict itself is deprecated in favour of :restrict_with_exception. * :dependent => :restrict_with_error implements the new behaviour - it adds an error to the owner if there are dependent records present See #4727 for the original discussion of this. | ||||
* | load active_support/deprecation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | load active_support/core_ext/object/inclusion in active_support/rails | Xavier Noria | 2012-08-02 | 3 | -3/+0 |
| | |||||
* | Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql. | Jon Leighton | 2012-08-01 | 2 | -0/+21 |
| | |||||
* | Revert "Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql." | Jon Leighton | 2012-08-01 | 2 | -2/+2 |
| | | | | | | | | | This reverts commit 3803fcce26b837c0117f7d278b83c366dc4ed370. Conflicts: activerecord/CHANGELOG.md It will be deprecated only in 4.0, and removed properly in 4.1. | ||||
* | Refactor dependency check validation | Carlos Antonio da Silva | 2012-08-01 | 4 | -28/+19 |
| | | | | | | Move the logic for validation check to the same method, and cache dependent option in a variable to reuse inside the dependency configuration methods instead of relying on the options hash. | ||||
* | move method for dependent option check | Hrvoje Šimić | 2012-08-01 | 4 | -11/+22 |
| | |||||
* | Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql. | Jon Leighton | 2012-07-20 | 2 | -2/+2 |
| | |||||
* | Avoid options ever being nil | Jon Leighton | 2012-07-20 | 1 | -4/+4 |
| | | | | This fixes active_record_deprecated_finders. | ||||
* | fix association :extend option | Jon Leighton | 2012-07-13 | 2 | -6/+17 |
| | |||||
* | move the deprecated options into active_record_deprecated_finders | Jon Leighton | 2012-07-13 | 2 | -5/+2 |
| | |||||
* | stop using class_attribute where methods/inheritance will suffice. | Jon Leighton | 2012-07-13 | 7 | -29/+53 |
| | |||||
* | extract deprecated association options to active_record_deprecated_finders | Jon Leighton | 2012-07-13 | 1 | -43/+0 |
| | |||||
* | Represent association scope options as AR::Relations insternally. | Jon Leighton | 2012-07-13 | 1 | -0/+43 |
| | |||||
* | Allow associations to take a lambda which builds the scope | Jon Leighton | 2012-07-13 | 2 | -12/+17 |
| | |||||
* | Improve the derivation of HABTM assocation join table names | Andrew White | 2012-06-22 | 1 | -30/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve the derivation of HABTM join table name to take account of nesting. It now takes the table names of the two models, sorts them lexically and then joins them, stripping any common prefix from the second table name. Some examples: Top level models (Category <=> Product) Old: categories_products New: categories_products Top level models with a global table_name_prefix (Category <=> Product) Old: site_categories_products New: site_categories_products Nested models in a module without a table_name_prefix method (Admin::Category <=> Admin::Product) Old: categories_products New: categories_products Nested models in a module with a table_name_prefix method (Admin::Category <=> Admin::Product) Old: categories_products New: admin_categories_products Nested models in a parent model (Catalog::Category <=> Catalog::Product) Old: categories_products New: catalog_categories_products Nested models in different parent models (Catalog::Category <=> Content::Page) Old: categories_pages New: catalog_categories_content_pages Also as part of this commit the validity checks for HABTM assocations have been moved to ActiveRecord::Reflection One side effect of this is to move when the exceptions are raised from the point of declaration to when the association is built. This is consistant with other association validity checks. | ||||
* | Merge pull request #4835 from ↵ | Carlos Antonio da Silva | 2012-05-19 | 1 | -3/+3 |
|\ | | | | | | | | | pacoguzman/refactor_define_restrict_dependency_method Refactor define_restrict_dependency_method using reflection | ||||
| * | Refactor define_restrict_dependency_method using reflection | Paco Guzman | 2012-02-01 | 1 | -3/+3 |
| | | |||||
* | | no longer need #delete_all_on_destroy | Jon Leighton | 2012-05-18 | 2 | -2/+2 |
|/ | |||||
* | Use human attribute name to show the dependent destroy message | Rafael Mendonça França | 2012-02-01 | 1 | -1/+2 |
| | |||||
* | fix has_one, has_many restrict error message | Manoj | 2012-02-01 | 1 | -1/+2 |
| | |||||
* | Merge pull request #4799 from arunagw/warning_fixed_for_indentations | Aaron Patterson | 2012-01-31 | 1 | -1/+1 |
|\ | | | | | warning removed: mismatched indentations | ||||
| * | warning removed: mismatched indentations | Arun Agrawal | 2012-01-31 | 1 | -1/+1 |
| | | |||||
* | | Put spaces between the words at deprecation warning | Rafael Mendonça França | 2012-01-31 | 1 | -3/+3 |
|/ | |||||
* | suggested fixes for :dependent => :restrict deprecation. | Manoj | 2012-01-31 | 1 | -1/+1 |
| | |||||
* | Same method for has_many and has_one associations | Paco Guzman | 2012-01-31 | 3 | -30/+17 |
| | |||||
* | Easy dependent_restrict error message | Paco Guzman | 2012-01-31 | 2 | -4/+2 |
| | |||||
* | has_many/has_one, :dependent => :restrict, deprecation added. | Manoj | 2012-01-29 | 3 | -3/+35 |
| | |||||
* | Deprecate inferred JOINs with includes + SQL snippets. | Jon Leighton | 2012-01-16 | 1 | -1/+1 |
| | | | | | | See the CHANGELOG for details. Fixes #950. | ||||
* | Revert "Deprecate implicit eager loading. Closes #950." | Jon Leighton | 2012-01-16 | 1 | -1/+1 |
| | | | | This reverts commit c99d507fccca2e9e4d12e49b4387e007c5481ae9. | ||||
* | Remove Array.wrap calls in ActiveRecord | Rafael Mendonça França | 2012-01-06 | 1 | -2/+2 |
| | |||||
* | Removed metaclass from the has_many dependency destroy method. Fixes #2954 | Dmitry Polushkin | 2011-12-31 | 2 | -8/+5 |
| | |||||
* | Deprecate implicit eager loading. Closes #950. | Jon Leighton | 2011-12-29 | 1 | -1/+1 |
| | |||||
* | Fix #3672 again (dependent: delete_all perf) | Jon Leighton | 2011-12-14 | 2 | -2/+8 |
| | |||||
* | avoid warnings | Josh Susser | 2011-11-27 | 6 | -15/+15 |
| | | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better. | ||||
* | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 2 | -7/+13 |
| | |||||
* | association methods are now generated in modules | Josh Susser | 2011-11-15 | 7 | -30/+25 |
| | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. | ||||
* | Destroy association habtm record before destroying the record itself. Fixes ↵ | Tomas D'Stefano | 2011-07-08 | 1 | -12/+10 |
| | | | | issue #402. | ||||
* | Removes the restriction on primary key when joining in a habtm && test that ↵ | Mohammad El-Abid | 2011-05-26 | 1 | -4/+0 |
| | | | | it was properly removed | ||||
* | removed deprecated methods, and related tests, from ActiveRecord | Josh Kalderimis | 2011-05-25 | 1 | -13/+0 |
| | |||||
* | Add block setting of attributes to singular associations | Andrew White | 2011-05-17 | 1 | -6/+6 |
| | |||||
* | Bring back obj.association_loaded? as a deprecated method. Fixes #472. | Jon Leighton | 2011-05-11 | 1 | -0/+13 |
| | |||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 3 | -3/+3 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 3 | -3/+3 |
| | | | | suggestion! |