Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix `automatic_inverse_of` not to be disabled if extension block is given | Ryuta Kamizono | 2019-04-12 | 1 | -12/+0 |
| | | | | | | | | If an association has a scope, `automatic_inverse_of` is to be disabled. But extension block is obviously not a scope. It should not be regarded as a scope. Fixes #28806. | ||||
* | Ruby 2.7 warning: creating a Proc without a block | utilum | 2019-02-13 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | As of [Revision 66772]( https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) `Proc.new` without giving a block emits `warning: tried to create Proc object without a block`. This commit fixes cases where Rails test suit tickles this warning. See CI logs: https://travis-ci.org/rails/rails/jobs/487205819#L1161-L1190 https://travis-ci.org/rails/rails/jobs/487205821#L1154-1159 https://travis-ci.org/rails/rails/jobs/487205821#L1160-L1169 https://travis-ci.org/rails/rails/jobs/487205821#L1189 https://travis-ci.org/rails/rails/jobs/487254404#L1307-L1416 https://travis-ci.org/rails/rails/jobs/487254405#L1174-L1191 | ||||
* | Fix call sites | Gannon McGibbon | 2018-10-02 | 1 | -1/+1 |
| | |||||
* | [Active Record] require => require_relative | Akira Matsuda | 2017-10-21 | 1 | -1/+1 |
| | | | | This basically reverts 9d4f79d3d394edb74fa2192e5d9ad7b09ce50c6d | ||||
* | Use frozen-string-literal in ActiveRecord | Kir Shatrov | 2017-07-19 | 1 | -0/+2 |
| | |||||
* | [Active Record] require => require_relative | Akira Matsuda | 2017-07-01 | 1 | -1/+1 |
| | |||||
* | Delete stale comment for `AR::Associations::Builder::CollectionAssociation` | fatkodima | 2017-07-01 | 1 | -2/+0 |
| | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+0 |
| | |||||
* | applies new string literal convention in activerecord/lib | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | don't treat all associations with extensions as instance dependent. | Yves Senn | 2016-03-03 | 1 | -1/+5 |
| | | | | | | | | | | Closes #23934. This is a forward port of ac832a43b4d026dbad28fed196d2de69ec9928ac Previously the scope of all associations with extensions were wrapped in an instance dependent proc. This made it impossible to preload such associations. | ||||
* | docs, add missing `:nodoc: for `Associations::Builder`. [ci skip] | Yves Senn | 2015-10-13 | 1 | -1/+1 |
| | | | | | | This class is only used internally. We should keep it out of public documentation. This patch adds nodoc for `ActiveRecord::Associations::Builder` and everything nested within. | ||||
* | Remove support to activerecord-deprecated_finders | Rafael Mendonça França | 2015-01-02 | 1 | -18/+6 |
| | |||||
* | Revert the whole refactoring in the association builder classes. | Rafael Mendonça França | 2013-12-11 | 1 | -6/+18 |
| | | | | This is to get activerecord-deprecated_finders work again | ||||
* | Bring back the valid_options class accessor | Rafael Mendonça França | 2013-12-11 | 1 | -1/+1 |
| | | | | It is need in activerecord-deprecated_finders | ||||
* | Method visibility will not make difference here | Rafael Mendonça França | 2013-10-09 | 1 | -2/+0 |
| | |||||
* | Extract the scope building to a class method | Rafael Mendonça França | 2013-10-09 | 1 | -8/+0 |
| | |||||
* | Remove unneeded reader | Rafael Mendonça França | 2013-10-09 | 1 | -2/+0 |
| | |||||
* | Move wrap_scope to class level | Rafael Mendonça França | 2013-10-09 | 1 | -2/+2 |
| | |||||
* | Make valid_options a class method | Rafael Mendonça França | 2013-10-09 | 1 | -1/+1 |
| | |||||
* | Define the association extensions without need to have a builder | Rafael Mendonça França | 2013-10-09 | 1 | -8/+8 |
| | | | | instance | ||||
* | :scissors: | Rafael Mendonça França | 2013-10-09 | 1 | -1/+1 |
| | |||||
* | Move define_writers to class level since we don't need anything from the | Rafael Mendonça França | 2013-10-08 | 1 | -1/+1 |
| | | | | instance | ||||
* | Move define_readers to class method since it doesn't need nothing from | Rafael Mendonça França | 2013-10-08 | 1 | -2/+1 |
| | | | | the instance | ||||
* | we can define callbacks without a builder instance | Aaron Patterson | 2013-10-02 | 1 | -2/+2 |
| | |||||
* | push methods that don't depend on the instance to the class | Aaron Patterson | 2013-10-02 | 1 | -2/+2 |
| | |||||
* | cache the name and options on the stack | Aaron Patterson | 2013-10-02 | 1 | -1/+3 |
| | |||||
* | decouple define_callback from the instance | Aaron Patterson | 2013-10-02 | 1 | -2/+4 |
| | |||||
* | remove intermediate assignments | Aaron Patterson | 2013-08-01 | 1 | -4/+2 |
| | |||||
* | association builder classes no longer need the model | Aaron Patterson | 2013-08-01 | 1 | -1/+1 |
| | | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now. | ||||
* | push more mutations outside the factory method | Aaron Patterson | 2013-08-01 | 1 | -8/+2 |
| | |||||
* | push module building to the constructor | Aaron Patterson | 2013-08-01 | 1 | -14/+20 |
| | |||||
* | users should be warned if clobbering constants | Aaron Patterson | 2013-08-01 | 1 | -3/+1 |
| | |||||
* | defning extensions happens once, no need to cache | Aaron Patterson | 2013-08-01 | 1 | -5/+3 |
| | |||||
* | assert that constants have been set rather than the names | Aaron Patterson | 2013-08-01 | 1 | -3/+3 |
| | |||||
* | remove dead code | Aaron Patterson | 2013-08-01 | 1 | -4/+0 |
| | |||||
* | pushing out more callback definitions | Aaron Patterson | 2013-08-01 | 1 | -2/+6 |
| | |||||
* | oops! :bomb: | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | |||||
* | do is_a? tests on assignment so runtime is faster | Aaron Patterson | 2013-07-31 | 1 | -1/+11 |
| | |||||
* | no need to to_sym | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | |||||
* | pass the mixin in to the code generation methods | Aaron Patterson | 2013-07-31 | 1 | -2/+2 |
| | |||||
* | Removed support for deprecated `finder_sql` in associations. | Neeraj Singh | 2013-07-02 | 1 | -1/+1 |
| | |||||
* | Removed support for deprecated `counter_sql` | Neeraj Singh | 2013-07-02 | 1 | -1/+1 |
| | |||||
* | Removed deprecated options for assocations | Neeraj Singh | 2013-07-02 | 1 | -9/+0 |
| | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted. | ||||
* | Added some more documentation for define_readers and define_writer of the ↵ | aditya-kapoor | 2013-05-15 | 1 | -0/+4 |
| | | | | Association and its inherited classes | ||||
* | Undeprecate the :extend option | Jon Leighton | 2013-01-18 | 1 | -1/+2 |
| | | | | | | | Suggested by @dhh. It doesn't affect the generated SQL, so seems reasonable to continue to allow it as an association option. | ||||
* | adding requires for constant dependencies | Aaron Patterson | 2012-11-07 | 1 | -0/+3 |
| | |||||
* | Use method compilation for association methods | Jon Leighton | 2012-08-10 | 1 | -8/+10 |
| | | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though. | ||||
* | DRY up handling of dependent option | Jon Leighton | 2012-08-10 | 1 | -1/+0 |
| | |||||
* | Unprivatise all the things | Jon Leighton | 2012-08-10 | 1 | -37/+35 |
| | | | | | | Well, not all of them, but some of them. I don't think there's much reason for these methods to be private. | ||||
* | load active_support/deprecation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| |