Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | docs, add missing `:nodoc: for `Associations::Builder`. [ci skip] | Yves Senn | 2015-10-13 | 1 | -1/+1 |
| | | | | | | This class is only used internally. We should keep it out of public documentation. This patch adds nodoc for `ActiveRecord::Associations::Builder` and everything nested within. | ||||
* | Remove support to activerecord-deprecated_finders | Rafael Mendonça França | 2015-01-02 | 1 | -18/+6 |
| | |||||
* | Revert the whole refactoring in the association builder classes. | Rafael Mendonça França | 2013-12-11 | 1 | -6/+18 |
| | | | | This is to get activerecord-deprecated_finders work again | ||||
* | Bring back the valid_options class accessor | Rafael Mendonça França | 2013-12-11 | 1 | -1/+1 |
| | | | | It is need in activerecord-deprecated_finders | ||||
* | Method visibility will not make difference here | Rafael Mendonça França | 2013-10-09 | 1 | -2/+0 |
| | |||||
* | Extract the scope building to a class method | Rafael Mendonça França | 2013-10-09 | 1 | -8/+0 |
| | |||||
* | Remove unneeded reader | Rafael Mendonça França | 2013-10-09 | 1 | -2/+0 |
| | |||||
* | Move wrap_scope to class level | Rafael Mendonça França | 2013-10-09 | 1 | -2/+2 |
| | |||||
* | Make valid_options a class method | Rafael Mendonça França | 2013-10-09 | 1 | -1/+1 |
| | |||||
* | Define the association extensions without need to have a builder | Rafael Mendonça França | 2013-10-09 | 1 | -8/+8 |
| | | | | instance | ||||
* | :scissors: | Rafael Mendonça França | 2013-10-09 | 1 | -1/+1 |
| | |||||
* | Move define_writers to class level since we don't need anything from the | Rafael Mendonça França | 2013-10-08 | 1 | -1/+1 |
| | | | | instance | ||||
* | Move define_readers to class method since it doesn't need nothing from | Rafael Mendonça França | 2013-10-08 | 1 | -2/+1 |
| | | | | the instance | ||||
* | we can define callbacks without a builder instance | Aaron Patterson | 2013-10-02 | 1 | -2/+2 |
| | |||||
* | push methods that don't depend on the instance to the class | Aaron Patterson | 2013-10-02 | 1 | -2/+2 |
| | |||||
* | cache the name and options on the stack | Aaron Patterson | 2013-10-02 | 1 | -1/+3 |
| | |||||
* | decouple define_callback from the instance | Aaron Patterson | 2013-10-02 | 1 | -2/+4 |
| | |||||
* | remove intermediate assignments | Aaron Patterson | 2013-08-01 | 1 | -4/+2 |
| | |||||
* | association builder classes no longer need the model | Aaron Patterson | 2013-08-01 | 1 | -1/+1 |
| | | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now. | ||||
* | push more mutations outside the factory method | Aaron Patterson | 2013-08-01 | 1 | -8/+2 |
| | |||||
* | push module building to the constructor | Aaron Patterson | 2013-08-01 | 1 | -14/+20 |
| | |||||
* | users should be warned if clobbering constants | Aaron Patterson | 2013-08-01 | 1 | -3/+1 |
| | |||||
* | defning extensions happens once, no need to cache | Aaron Patterson | 2013-08-01 | 1 | -5/+3 |
| | |||||
* | assert that constants have been set rather than the names | Aaron Patterson | 2013-08-01 | 1 | -3/+3 |
| | |||||
* | remove dead code | Aaron Patterson | 2013-08-01 | 1 | -4/+0 |
| | |||||
* | pushing out more callback definitions | Aaron Patterson | 2013-08-01 | 1 | -2/+6 |
| | |||||
* | oops! :bomb: | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | |||||
* | do is_a? tests on assignment so runtime is faster | Aaron Patterson | 2013-07-31 | 1 | -1/+11 |
| | |||||
* | no need to to_sym | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | |||||
* | pass the mixin in to the code generation methods | Aaron Patterson | 2013-07-31 | 1 | -2/+2 |
| | |||||
* | Removed support for deprecated `finder_sql` in associations. | Neeraj Singh | 2013-07-02 | 1 | -1/+1 |
| | |||||
* | Removed support for deprecated `counter_sql` | Neeraj Singh | 2013-07-02 | 1 | -1/+1 |
| | |||||
* | Removed deprecated options for assocations | Neeraj Singh | 2013-07-02 | 1 | -9/+0 |
| | | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted. | ||||
* | Added some more documentation for define_readers and define_writer of the ↵ | aditya-kapoor | 2013-05-15 | 1 | -0/+4 |
| | | | | Association and its inherited classes | ||||
* | Undeprecate the :extend option | Jon Leighton | 2013-01-18 | 1 | -1/+2 |
| | | | | | | | Suggested by @dhh. It doesn't affect the generated SQL, so seems reasonable to continue to allow it as an association option. | ||||
* | adding requires for constant dependencies | Aaron Patterson | 2012-11-07 | 1 | -0/+3 |
| | |||||
* | Use method compilation for association methods | Jon Leighton | 2012-08-10 | 1 | -8/+10 |
| | | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though. | ||||
* | DRY up handling of dependent option | Jon Leighton | 2012-08-10 | 1 | -1/+0 |
| | |||||
* | Unprivatise all the things | Jon Leighton | 2012-08-10 | 1 | -37/+35 |
| | | | | | | Well, not all of them, but some of them. I don't think there's much reason for these methods to be private. | ||||
* | load active_support/deprecation in active_support/rails | Xavier Noria | 2012-08-02 | 1 | -1/+0 |
| | |||||
* | Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql. | Jon Leighton | 2012-08-01 | 1 | -0/+11 |
| | |||||
* | Revert "Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql." | Jon Leighton | 2012-08-01 | 1 | -1/+1 |
| | | | | | | | | | This reverts commit 3803fcce26b837c0117f7d278b83c366dc4ed370. Conflicts: activerecord/CHANGELOG.md It will be deprecated only in 4.0, and removed properly in 4.1. | ||||
* | Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql. | Jon Leighton | 2012-07-20 | 1 | -1/+1 |
| | |||||
* | fix association :extend option | Jon Leighton | 2012-07-13 | 1 | -6/+12 |
| | |||||
* | move the deprecated options into active_record_deprecated_finders | Jon Leighton | 2012-07-13 | 1 | -4/+1 |
| | |||||
* | stop using class_attribute where methods/inheritance will suffice. | Jon Leighton | 2012-07-13 | 1 | -4/+6 |
| | |||||
* | Allow associations to take a lambda which builds the scope | Jon Leighton | 2012-07-13 | 1 | -6/+2 |
| | |||||
* | Remove Array.wrap calls in ActiveRecord | Rafael Mendonça França | 2012-01-06 | 1 | -2/+2 |
| | |||||
* | avoid warnings | Josh Susser | 2011-11-27 | 1 | -2/+2 |
| | | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better. | ||||
* | association methods are now generated in modules | Josh Susser | 2011-11-15 | 1 | -2/+2 |
| | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. |