aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/builder/collection_association.rb
Commit message (Collapse)AuthorAgeFilesLines
* Namespace association extension modules under the owner modelJean Boussier2019-05-021-2/+2
|
* Make association builder methods privateRyuta Kamizono2019-04-241-0/+2
|
* Fix `automatic_inverse_of` not to be disabled if extension block is givenRyuta Kamizono2019-04-121-12/+0
| | | | | | | | If an association has a scope, `automatic_inverse_of` is to be disabled. But extension block is obviously not a scope. It should not be regarded as a scope. Fixes #28806.
* Ruby 2.7 warning: creating a Proc without a blockutilum2019-02-131-2/+2
| | | | | | | | | | | | | | | | As of [Revision 66772]( https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) `Proc.new` without giving a block emits `warning: tried to create Proc object without a block`. This commit fixes cases where Rails test suit tickles this warning. See CI logs: https://travis-ci.org/rails/rails/jobs/487205819#L1161-L1190 https://travis-ci.org/rails/rails/jobs/487205821#L1154-1159 https://travis-ci.org/rails/rails/jobs/487205821#L1160-L1169 https://travis-ci.org/rails/rails/jobs/487205821#L1189 https://travis-ci.org/rails/rails/jobs/487254404#L1307-L1416 https://travis-ci.org/rails/rails/jobs/487254405#L1174-L1191
* Fix call sitesGannon McGibbon2018-10-021-1/+1
|
* [Active Record] require => require_relativeAkira Matsuda2017-10-211-1/+1
| | | | This basically reverts 9d4f79d3d394edb74fa2192e5d9ad7b09ce50c6d
* Use frozen-string-literal in ActiveRecordKir Shatrov2017-07-191-0/+2
|
* [Active Record] require => require_relativeAkira Matsuda2017-07-011-1/+1
|
* Delete stale comment for `AR::Associations::Builder::CollectionAssociation`fatkodima2017-07-011-2/+0
|
* applies remaining conventions across the projectXavier Noria2016-08-061-1/+0
|
* applies new string literal convention in activerecord/libXavier Noria2016-08-061-1/+1
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* don't treat all associations with extensions as instance dependent.Yves Senn2016-03-031-1/+5
| | | | | | | | | | Closes #23934. This is a forward port of ac832a43b4d026dbad28fed196d2de69ec9928ac Previously the scope of all associations with extensions were wrapped in an instance dependent proc. This made it impossible to preload such associations.
* docs, add missing `:nodoc: for `Associations::Builder`. [ci skip]Yves Senn2015-10-131-1/+1
| | | | | | This class is only used internally. We should keep it out of public documentation. This patch adds nodoc for `ActiveRecord::Associations::Builder` and everything nested within.
* Remove support to activerecord-deprecated_findersRafael Mendonça França2015-01-021-18/+6
|
* Revert the whole refactoring in the association builder classes.Rafael Mendonça França2013-12-111-6/+18
| | | | This is to get activerecord-deprecated_finders work again
* Bring back the valid_options class accessorRafael Mendonça França2013-12-111-1/+1
| | | | It is need in activerecord-deprecated_finders
* Method visibility will not make difference hereRafael Mendonça França2013-10-091-2/+0
|
* Extract the scope building to a class methodRafael Mendonça França2013-10-091-8/+0
|
* Remove unneeded readerRafael Mendonça França2013-10-091-2/+0
|
* Move wrap_scope to class levelRafael Mendonça França2013-10-091-2/+2
|
* Make valid_options a class methodRafael Mendonça França2013-10-091-1/+1
|
* Define the association extensions without need to have a builderRafael Mendonça França2013-10-091-8/+8
| | | | instance
* :scissors:Rafael Mendonça França2013-10-091-1/+1
|
* Move define_writers to class level since we don't need anything from theRafael Mendonça França2013-10-081-1/+1
| | | | instance
* Move define_readers to class method since it doesn't need nothing fromRafael Mendonça França2013-10-081-2/+1
| | | | the instance
* we can define callbacks without a builder instanceAaron Patterson2013-10-021-2/+2
|
* push methods that don't depend on the instance to the classAaron Patterson2013-10-021-2/+2
|
* cache the name and options on the stackAaron Patterson2013-10-021-1/+3
|
* decouple define_callback from the instanceAaron Patterson2013-10-021-2/+4
|
* remove intermediate assignmentsAaron Patterson2013-08-011-4/+2
|
* association builder classes no longer need the modelAaron Patterson2013-08-011-1/+1
| | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now.
* push more mutations outside the factory methodAaron Patterson2013-08-011-8/+2
|
* push module building to the constructorAaron Patterson2013-08-011-14/+20
|
* users should be warned if clobbering constantsAaron Patterson2013-08-011-3/+1
|
* defning extensions happens once, no need to cacheAaron Patterson2013-08-011-5/+3
|
* assert that constants have been set rather than the namesAaron Patterson2013-08-011-3/+3
|
* remove dead codeAaron Patterson2013-08-011-4/+0
|
* pushing out more callback definitionsAaron Patterson2013-08-011-2/+6
|
* oops! :bomb:Aaron Patterson2013-07-311-1/+1
|
* do is_a? tests on assignment so runtime is fasterAaron Patterson2013-07-311-1/+11
|
* no need to to_symAaron Patterson2013-07-311-1/+1
|
* pass the mixin in to the code generation methodsAaron Patterson2013-07-311-2/+2
|
* Removed support for deprecated `finder_sql` in associations.Neeraj Singh2013-07-021-1/+1
|
* Removed support for deprecated `counter_sql`Neeraj Singh2013-07-021-1/+1
|
* Removed deprecated options for assocationsNeeraj Singh2013-07-021-9/+0
| | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted.
* Added some more documentation for define_readers and define_writer of the ↵aditya-kapoor2013-05-151-0/+4
| | | | Association and its inherited classes
* Undeprecate the :extend optionJon Leighton2013-01-181-1/+2
| | | | | | | Suggested by @dhh. It doesn't affect the generated SQL, so seems reasonable to continue to allow it as an association option.
* adding requires for constant dependenciesAaron Patterson2012-11-071-0/+3
|
* Use method compilation for association methodsJon Leighton2012-08-101-8/+10
| | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though.
* DRY up handling of dependent optionJon Leighton2012-08-101-1/+0
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 23:01:28 +0000