aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/builder/collection_association.rb
Commit message (Collapse)AuthorAgeFilesLines
* docs, add missing `:nodoc: for `Associations::Builder`. [ci skip]Yves Senn2015-10-131-1/+1
| | | | | | This class is only used internally. We should keep it out of public documentation. This patch adds nodoc for `ActiveRecord::Associations::Builder` and everything nested within.
* Remove support to activerecord-deprecated_findersRafael Mendonça França2015-01-021-18/+6
|
* Revert the whole refactoring in the association builder classes.Rafael Mendonça França2013-12-111-6/+18
| | | | This is to get activerecord-deprecated_finders work again
* Bring back the valid_options class accessorRafael Mendonça França2013-12-111-1/+1
| | | | It is need in activerecord-deprecated_finders
* Method visibility will not make difference hereRafael Mendonça França2013-10-091-2/+0
|
* Extract the scope building to a class methodRafael Mendonça França2013-10-091-8/+0
|
* Remove unneeded readerRafael Mendonça França2013-10-091-2/+0
|
* Move wrap_scope to class levelRafael Mendonça França2013-10-091-2/+2
|
* Make valid_options a class methodRafael Mendonça França2013-10-091-1/+1
|
* Define the association extensions without need to have a builderRafael Mendonça França2013-10-091-8/+8
| | | | instance
* :scissors:Rafael Mendonça França2013-10-091-1/+1
|
* Move define_writers to class level since we don't need anything from theRafael Mendonça França2013-10-081-1/+1
| | | | instance
* Move define_readers to class method since it doesn't need nothing fromRafael Mendonça França2013-10-081-2/+1
| | | | the instance
* we can define callbacks without a builder instanceAaron Patterson2013-10-021-2/+2
|
* push methods that don't depend on the instance to the classAaron Patterson2013-10-021-2/+2
|
* cache the name and options on the stackAaron Patterson2013-10-021-1/+3
|
* decouple define_callback from the instanceAaron Patterson2013-10-021-2/+4
|
* remove intermediate assignmentsAaron Patterson2013-08-011-4/+2
|
* association builder classes no longer need the modelAaron Patterson2013-08-011-1/+1
| | | | | decouple the builder classes from the model. Builder objects should be easier to reuse now.
* push more mutations outside the factory methodAaron Patterson2013-08-011-8/+2
|
* push module building to the constructorAaron Patterson2013-08-011-14/+20
|
* users should be warned if clobbering constantsAaron Patterson2013-08-011-3/+1
|
* defning extensions happens once, no need to cacheAaron Patterson2013-08-011-5/+3
|
* assert that constants have been set rather than the namesAaron Patterson2013-08-011-3/+3
|
* remove dead codeAaron Patterson2013-08-011-4/+0
|
* pushing out more callback definitionsAaron Patterson2013-08-011-2/+6
|
* oops! :bomb:Aaron Patterson2013-07-311-1/+1
|
* do is_a? tests on assignment so runtime is fasterAaron Patterson2013-07-311-1/+11
|
* no need to to_symAaron Patterson2013-07-311-1/+1
|
* pass the mixin in to the code generation methodsAaron Patterson2013-07-311-2/+2
|
* Removed support for deprecated `finder_sql` in associations.Neeraj Singh2013-07-021-1/+1
|
* Removed support for deprecated `counter_sql`Neeraj Singh2013-07-021-1/+1
|
* Removed deprecated options for assocationsNeeraj Singh2013-07-021-9/+0
| | | | | Deprecated options `delete_sql`, `insert_sql`, `finder_sql` and `counter_sql` have been deleted.
* Added some more documentation for define_readers and define_writer of the ↵aditya-kapoor2013-05-151-0/+4
| | | | Association and its inherited classes
* Undeprecate the :extend optionJon Leighton2013-01-181-1/+2
| | | | | | | Suggested by @dhh. It doesn't affect the generated SQL, so seems reasonable to continue to allow it as an association option.
* adding requires for constant dependenciesAaron Patterson2012-11-071-0/+3
|
* Use method compilation for association methodsJon Leighton2012-08-101-8/+10
| | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though.
* DRY up handling of dependent optionJon Leighton2012-08-101-1/+0
|
* Unprivatise all the thingsJon Leighton2012-08-101-37/+35
| | | | | | Well, not all of them, but some of them. I don't think there's much reason for these methods to be private.
* load active_support/deprecation in active_support/railsXavier Noria2012-08-021-1/+0
|
* Deprecate :finder_sql, :counter_sql, :insert_sql, :delete_sql.Jon Leighton2012-08-011-0/+11
|
* Revert "Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql."Jon Leighton2012-08-011-1/+1
| | | | | | | | | This reverts commit 3803fcce26b837c0117f7d278b83c366dc4ed370. Conflicts: activerecord/CHANGELOG.md It will be deprecated only in 4.0, and removed properly in 4.1.
* Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql.Jon Leighton2012-07-201-1/+1
|
* fix association :extend optionJon Leighton2012-07-131-6/+12
|
* move the deprecated options into active_record_deprecated_findersJon Leighton2012-07-131-4/+1
|
* stop using class_attribute where methods/inheritance will suffice.Jon Leighton2012-07-131-4/+6
|
* Allow associations to take a lambda which builds the scopeJon Leighton2012-07-131-6/+2
|
* Remove Array.wrap calls in ActiveRecordRafael Mendonça França2012-01-061-2/+2
|
* avoid warningsJosh Susser2011-11-271-2/+2
| | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better.
* association methods are now generated in modulesJosh Susser2011-11-151-2/+2
| | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods.