aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/builder/belongs_to.rb
Commit message (Collapse)AuthorAgeFilesLines
* Prevented belongs_to: touch propagating up if there are no changes being savedBrock Trappitt2014-05-211-1/+1
|
* Hide BelongsToAssociation#increment_counters and #decrement_countersJean Boussier2014-04-151-1/+0
|
* Use inheritance chain instead of callbacks to increment counter caches after ↵Jean Boussier2014-04-141-16/+0
| | | | destroy
* Use inheritance chain instead of callbacks to increment counter caches after ↵Jean Boussier2014-04-141-12/+1
| | | | create
* Make counter cache decrementation on destroy idempotentJean Boussier2014-04-131-4/+5
|
* On destroying do not touch destroyed belongs to association.Paul Nikitochkin2013-12-231-1/+1
| | | | Fixes: #13445
* Revert the whole refactoring in the association builder classes.Rafael Mendonça França2013-12-111-2/+4
| | | | This is to get activerecord-deprecated_finders work again
* Bring back the valid_options class accessorRafael Mendonça França2013-12-111-1/+1
| | | | It is need in activerecord-deprecated_finders
* polymorphic belongs_to association with touch: true updates old record correctlySeverin Schoepke2013-12-051-1/+7
| | | | | | | | | Example: Given you have a comments model with a polymorphic commentable association (e.g. books and songs) with the touch option set. Every time you update a comment its commentable should be touched. This was working when you changed attributes on the comment or when you moved the comment from one book to another. However, it was not working when moving a comment from a book to a song. This is now fixed.
* Raise `ArgumentError` when `has_one` is used with `counter_cache`Godfrey Chan2013-11-291-1/+1
| | | | | | | | | Previously, the `has_one` macro incorrectly accepts the `counter_cache` option due to a bug, although that options was never supported nor functional on `has_one` and `has_one ... through` relationships. It now correctly raises an `ArgumentError` when passed that option. For reference, this bug was introduced in 52f8e4b9.
* Method visibility will not make difference hereRafael Mendonça França2013-10-091-2/+0
|
* Move macro to class levelRafael Mendonça França2013-10-091-1/+1
|
* Make valid_options a class methodRafael Mendonça França2013-10-091-1/+1
|
* Push define_accessors to class level since we don't need anythig fromRafael Mendonça França2013-10-081-2/+2
| | | | the instance
* Move add_counter_cache_methods to class levelRafael Mendonça França2013-10-081-2/+2
|
* we can define callbacks without a builder instanceAaron Patterson2013-10-021-3/+3
|
* push methods that don't depend on the instance to the classAaron Patterson2013-10-021-4/+4
|
* decouple belongs_to callback definition from the builder instance.Aaron Patterson2013-10-021-4/+4
| | | | All the information is on the reflection, so just get it there.
* valid_options doesn't depend on the instance, so push it to the classAaron Patterson2013-10-021-1/+1
|
* association builder is no longer needed for counter cache, so remove itAaron Patterson2013-10-021-7/+6
|
* push constructable? on to the reflectionAaron Patterson2013-10-021-6/+2
|
* name is on the reflection, so just use the reflectionAaron Patterson2013-10-021-2/+2
|
* remove dependency on @model when defining callbacksAaron Patterson2013-08-011-5/+5
|
* extract more mutations to the callerAaron Patterson2013-08-011-7/+6
|
* separate some mutations from reflection constructionAaron Patterson2013-08-011-1/+5
|
* #11288: Removed duplicated touchingPaul Nikitochkin2013-07-051-1/+1
| | | | | | if belongs to model with touch option on touch Closes #11288
* stop adding a new method for touch callbacksAaron Patterson2013-06-111-29/+21
|
* push the touch method outside the evalAaron Patterson2013-06-111-13/+34
|
* remove unused variableAaron Patterson2013-06-111-1/+0
|
* check whether the association is constructible rather than checking constantsAaron Patterson2013-06-111-3/+3
|
* use attribute methods for finding key values rather than generating method namesAaron Patterson2013-06-111-3/+3
|
* push belongs_to counter cache method to a single methodAaron Patterson2013-06-111-17/+18
|
* push before_destroy counter cache method to a single methodAaron Patterson2013-06-111-12/+17
|
* remove evaled belongs_to counter cache methodAaron Patterson2013-06-111-8/+22
|
* adding callbacks should be privateAaron Patterson2013-06-111-4/+6
|
* Confirm a record has not already been destroyed before decrementingBen Tucker2013-05-061-1/+3
| | | | | | | | | counter cache At present, calling destroy multiple times on the same record results in the belongs_to counter cache being decremented multiple times. With this change the record is checked for whether it is already destroyed prior to decrementing the counter cache.
* Lookup the class at runtime, not when the association is builtAndrew White2013-04-241-2/+2
| | | | | | | | | Trying to lookup the parent class when the association is being built runs the risk of generating uninitialized constant errors because classes haven't been fully defined yet. To work around this we look up the class at runtime through the `association` method. Fixes #10197.
* Revert "Revert "`belongs_to :touch` behavior now touches old association ↵Andrew White2013-04-241-1/+12
| | | | | | | | | when transitioning to new association" until a proper fix is found for #10197" This reverts commit 7389df139a35436f00876c96d20e81ba23c93f0a. Conflicts: activerecord/test/cases/timestamp_test.rb
* Revert "`belongs_to :touch` behavior now touches old association when ↵David Heinemeier Hansson2013-04-231-12/+1
| | | | transitioning to new association" until a proper fix is found for #10197
* Update counter cache when pushing into associationMatthew Robertson2013-04-211-3/+4
| | | | | | | | | | | | | | | | This commit fixes a regression bug in which counter_cache columns were not being updated correctly when newly created records were being pushed into an assocation. EG: # this was fine @post.comment.create! # this was fine @comment = Comment.first @post.comments << @comment # this would not update counters @post.comments << Comment.create!
* Avoid an attempt to fetch old record when id was not present in touch callbackCarlos Antonio da Silva2013-04-041-7/+7
|
* Use the correct pk field from the reflected class to find the old recordCarlos Antonio da Silva2013-04-041-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | The implementation was using the source class foreign key field instead of the reflected primary key one to find the old record. For instance, for this scenario class Bulb < ActiveRecord::Base belongs_to :car, :touch => true end class Car < ActiveRecord::Base has_many :bulbs end the current implementation was trying to do this query: Car.where(car_id: X).first where we should be doing this query: Car.where(id: X).first This should hopefully fix the build.
* Use inspect when writing the foreign key from the reflectionAndrew White2013-04-051-2/+2
| | | | | | If we don't use inspect inside the class_eval block then the foreign key is written without quotes causing us to fetch the foreign key value and not the column name.
* Merge pull request #9141 from adamgamble/issue-9091David Heinemeier Hansson2013-04-031-0/+10
|\ | | | | belongs_to :touch should touch old record when transitioning.
| * Modifies belong_to touch callback to touch old associations also #9091Adam Gamble2013-03-141-0/+10
| |
* | Update other counter caches on destroyIan Young2013-03-201-1/+1
| |
* | If a counter_cache is defined, then using update_attributes and changingJohn Wang2013-03-151-0/+20
|/ | | | | the primary key on an association will make sure that the corresponding counter on the association is changed properly. Fixes #9722.
* Fix touching an invalid parent record for belongs_toOlek Janiszewski2013-02-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | If the parent of a `belongs_to` record fails to be saved due to validation errors, `touch` will be called on a new record, which causes an exception (see https://github.com/rails/rails/pull/9320). Example: class Owner < ActiveRecord::Base validates_presence_of :name end class Pet < ActiveRecord::Base belongs_to :owner, touch: true end pet = Pet.new(owner: Owner.new) # Before, this line would raise ActiveRecord::ActiveRecordError # "can not touch on a new record object" pet.save
* Use method compilation for association methodsJon Leighton2012-08-101-32/+25
| | | | | | | | | Method compilation provides better performance and I think the code comes out cleaner as well. A knock on effect is that methods that get redefined produce warnings. I think this is a good thing. I had to deal with a bunch of warnings coming from our tests, though.
* DRY up handling of dependent optionJon Leighton2012-08-101-18/+2
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-14 06:28:03 +0000