Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Rename AssociationProxy#loaded to loaded! as it mutates the association | Jon Leighton | 2011-01-30 | 1 | -1/+1 |
| | |||||
* | Abstract load_target conditional logic | Jon Leighton | 2011-01-30 | 1 | -1/+1 |
| | |||||
* | Let's be less blasé about method visibility on association proxies | Jon Leighton | 2011-01-30 | 1 | -37/+38 |
| | |||||
* | We shouldn't be using scoped.scoping { ... } to build associated records, as ↵ | Jon Leighton | 2011-01-30 | 1 | -8/+5 |
| | | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved] | ||||
* | Nested attributes and in-memory changed values #first and #[] behaviour ↵ | Alexey Nayden | 2011-01-28 | 1 | -1/+1 |
| | | | | consistency fix | ||||
* | push !loaded? conditional up | Aaron Patterson | 2011-01-14 | 1 | -10/+8 |
| | |||||
* | return early in case the left or right side lists are empty | Aaron Patterson | 2011-01-14 | 1 | -5/+4 |
| | |||||
* | only find_target can raise the exception, so isolate the rescue around that call | Aaron Patterson | 2011-01-14 | 1 | -5/+9 |
| | |||||
* | we always have a target, so stop checking | Aaron Patterson | 2011-01-14 | 1 | -1/+1 |
| | |||||
* | we should use [] instead of Array.new | Aaron Patterson | 2011-01-14 | 1 | -1/+1 |
| | |||||
* | @target is always a list, so stop doing is_a? checks | Aaron Patterson | 2011-01-14 | 1 | -1/+1 |
| | |||||
* | move complex logic to it's own method | Aaron Patterson | 2011-01-14 | 1 | -15/+19 |
| | |||||
* | loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵ | Aaron Patterson | 2011-01-14 | 1 | -4/+4 |
| | | | | inside the conditional | ||||
* | include_in_memory? should check against @target list in case of new records. ↵ | Aaron Patterson | 2011-01-12 | 1 | -2/+2 |
| | | | | [#6257 state:resolved] | ||||
* | use array maths rather than *args | Aaron Patterson | 2011-01-12 | 1 | -2/+4 |
| | |||||
* | just use respond_to? and super rather than aliasing around methods | Aaron Patterson | 2011-01-12 | 1 | -1/+1 |
| | |||||
* | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+5 |
| | | | | replaced | ||||
* | Not really worth having the HasAssociation module for just a single method | Jon Leighton | 2011-01-07 | 1 | -2/+0 |
| | |||||
* | Construct an actual ActiveRecord::Relation object for the association scope, ↵ | Jon Leighton | 2011-01-07 | 1 | -17/+10 |
| | | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things. | ||||
* | no need to send a symbol to send() | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | |||||
* | Create the association scope directly rather than going through with_scope | Jon Leighton | 2011-01-03 | 1 | -1/+1 |
| | |||||
* | Use the association directly in other places too | Jon Leighton | 2011-01-03 | 1 | -5/+2 |
| | |||||
* | Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵ | Jon Leighton | 2011-01-03 | 1 | -39/+42 |
| | | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences. | ||||
* | Rename AssociationProxy#foreign_key_present to foreign_key_present? | Jon Leighton | 2011-01-03 | 1 | -1/+1 |
| | |||||
* | Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵ | Jon Leighton | 2010-12-31 | 1 | -4/+0 |
| | | | | inherit from it | ||||
* | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 1 | -1/+1 |
| | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | ||||
* | I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2. | Aaron Patterson | 2010-12-27 | 1 | -2/+2 |
| | |||||
* | Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵ | Jon Leighton | 2010-12-26 | 1 | -4/+2 |
| | | | | other things | ||||
* | Add a HasAssociation module for common code for has_* associations | Jon Leighton | 2010-12-26 | 1 | -0/+2 |
| | |||||
* | Associations: DRY up the code which is generating conditions, and make it ↵ | Jon Leighton | 2010-12-26 | 1 | -1/+1 |
| | | | | all use arel rather than SQL strings | ||||
* | scoped.where_values_hash is never nil | Jon Leighton | 2010-12-26 | 1 | -1/+1 |
| | |||||
* | When a has_many association is not :uniq, appending the same record multiple ↵ | Jon Leighton | 2010-12-23 | 1 | -2/+2 |
| | | | | times should append it to the @target multiple times [#5964 state:resolved] | ||||
* | no use for set, no need to to_ary, reduce extra objects | Aaron Patterson | 2010-12-20 | 1 | -3/+2 |
| | |||||
* | use array arithmetic rather than create sets | Aaron Patterson | 2010-12-20 | 1 | -4/+2 |
| | |||||
* | Refactor create_record and build_record in AssociationCollection | Jon Leighton | 2010-12-20 | 1 | -17/+5 |
| | |||||
* | Delete create, create! and create_record from HasManyThroughAssociation in ↵ | Jon Leighton | 2010-12-20 | 1 | -12/+14 |
| | | | | exchange for more generic versions in AssociationCollection | ||||
* | Specify insert_record with NotImplementedError in AssociationCollection, to ↵ | Jon Leighton | 2010-12-20 | 1 | -0/+11 |
| | | | | indicate that subclasses should implement it. Also add save_record to reduce duplication. | ||||
* | Replace rudimentary named_scope with scope. [#6052 state:resolved] | Pavel Gorbokon | 2010-12-15 | 1 | -8/+8 |
| | | | | | | | * rename method names (actually in tests) * rename instance variable @_named_scopes_cache to @_scopes_cache * rename references in doc comments * don't touch CHANGELOG :) | ||||
* | Partialy revert f1c13b0dd7b22b5f6289ca1a09f1d7a8c7c8584b | José Valim | 2010-11-28 | 1 | -11/+11 |
| | |||||
* | nil check unneeded ht. exviva | Santiago Pastorino | 2010-11-25 | 1 | -1/+1 |
| | |||||
* | Use ternary instead explicit return. | Emilio Tagua | 2010-11-25 | 1 | -2/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Remove return, we are already returning self. | Emilio Tagua | 2010-11-25 | 1 | -6/+6 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | class inheritable attributes is used no more! all internal use of class ↵ | Josh Kalderimis | 2010-11-20 | 1 | -1/+1 |
| | | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | super automatically passes on the implicit block | Aaron Patterson | 2010-11-16 | 1 | -5/+1 |
| | |||||
* | use unless instead of if ! | Aaron Patterson | 2010-11-16 | 1 | -1/+1 |
| | |||||
* | removing space errors | Aaron Patterson | 2010-11-16 | 1 | -3/+3 |
| | |||||
* | reloading an association will properly set attributes of instantiated ↵ | Aaron Patterson | 2010-11-16 | 1 | -1/+3 |
| | | | | objects. Thanks Brian Palmer [#5802 state:resolved] | ||||
* | refactoring uniq method | Aaron Patterson | 2010-11-16 | 1 | -7/+4 |
| | |||||
* | if association is already loaded and if a find operation is performed on the ↵ | Neeraj Singh | 2010-11-15 | 1 | -1/+2 |
| | | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved] | ||||
* | Execute less operations | Santiago Pastorino | 2010-11-09 | 1 | -2/+1 |
| |