Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor the implementations of AssociatioCollection#delete and #destroy to ↵ | Jon Leighton | 2011-02-07 | 1 | -15/+11 |
| | | | | be more consistent with each other, and to stop passing blocks around, thus making the execution easier to follow. | ||||
* | This string should continue | Jon Leighton | 2011-02-07 | 1 | -1/+1 |
| | |||||
* | Make record.association.destroy(*records) on habtm and hm:t only delete ↵ | Jon Leighton | 2011-02-07 | 1 | -1/+7 |
| | | | | records in the join table. This is to make the destroy method more consistent across the different types of associations. For more details see the CHANGELOG entry. | ||||
* | Make AssociationCollection#include? a bit more readable | Jon Leighton | 2011-01-30 | 1 | -4/+10 |
| | |||||
* | Don't use method_missing when we don't have to | Jon Leighton | 2011-01-30 | 1 | -2/+2 |
| | |||||
* | AssociationCollection#clear can basically just use #delete_all, except it ↵ | Jon Leighton | 2011-01-30 | 1 | -13/+7 |
| | | | | should return self. | ||||
* | AssociationCollection#to_ary should definitely dup the target! Also changed ↵ | Jon Leighton | 2011-01-30 | 1 | -3/+3 |
| | | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping. | ||||
* | Just use primary_key here, AR::Relation will resolve the ambiguity before it ↵ | Jon Leighton | 2011-01-30 | 1 | -1/+1 |
| | | | | is converted to SQL | ||||
* | Call sum on the scope directly, rather than relying on method_missing and ↵ | Jon Leighton | 2011-01-30 | 1 | -2/+2 |
| | | | | calculate | ||||
* | Condense first_or_last a bit more | Jon Leighton | 2011-01-30 | 1 | -7/+5 |
| | |||||
* | Get rid of separate reset_target! and reset_scopes_cache! methods | Jon Leighton | 2011-01-30 | 1 | -26/+17 |
| | |||||
* | target is always an array | Jon Leighton | 2011-01-30 | 1 | -5/+0 |
| | |||||
* | load_target will return the target. it also will not load if loaded? is true. | Jon Leighton | 2011-01-30 | 1 | -2/+1 |
| | |||||
* | DRY up first/last and hence make last benefit from the bugfix in first | Jon Leighton | 2011-01-30 | 1 | -15/+13 |
| | |||||
* | Use scoped.find directly rather than having a find_by_sql method | Jon Leighton | 2011-01-30 | 1 | -5/+1 |
| | |||||
* | Use scoped.first and scoped.last instead of find(:first, ...) and ↵ | Jon Leighton | 2011-01-30 | 1 | -2/+2 |
| | | | | find(:last, ...) | ||||
* | Try to make fetch_first_or_last_using_find? more readable | Jon Leighton | 2011-01-30 | 1 | -2/+20 |
| | |||||
* | load_target returns the target | Jon Leighton | 2011-01-30 | 1 | -2/+1 |
| | |||||
* | Rename AssociationProxy#loaded to loaded! as it mutates the association | Jon Leighton | 2011-01-30 | 1 | -1/+1 |
| | |||||
* | Abstract load_target conditional logic | Jon Leighton | 2011-01-30 | 1 | -1/+1 |
| | |||||
* | Let's be less blasé about method visibility on association proxies | Jon Leighton | 2011-01-30 | 1 | -37/+38 |
| | |||||
* | We shouldn't be using scoped.scoping { ... } to build associated records, as ↵ | Jon Leighton | 2011-01-30 | 1 | -8/+5 |
| | | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved] | ||||
* | Nested attributes and in-memory changed values #first and #[] behaviour ↵ | Alexey Nayden | 2011-01-28 | 1 | -1/+1 |
| | | | | consistency fix | ||||
* | push !loaded? conditional up | Aaron Patterson | 2011-01-14 | 1 | -10/+8 |
| | |||||
* | return early in case the left or right side lists are empty | Aaron Patterson | 2011-01-14 | 1 | -5/+4 |
| | |||||
* | only find_target can raise the exception, so isolate the rescue around that call | Aaron Patterson | 2011-01-14 | 1 | -5/+9 |
| | |||||
* | we always have a target, so stop checking | Aaron Patterson | 2011-01-14 | 1 | -1/+1 |
| | |||||
* | we should use [] instead of Array.new | Aaron Patterson | 2011-01-14 | 1 | -1/+1 |
| | |||||
* | @target is always a list, so stop doing is_a? checks | Aaron Patterson | 2011-01-14 | 1 | -1/+1 |
| | |||||
* | move complex logic to it's own method | Aaron Patterson | 2011-01-14 | 1 | -15/+19 |
| | |||||
* | loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵ | Aaron Patterson | 2011-01-14 | 1 | -4/+4 |
| | | | | inside the conditional | ||||
* | include_in_memory? should check against @target list in case of new records. ↵ | Aaron Patterson | 2011-01-12 | 1 | -2/+2 |
| | | | | [#6257 state:resolved] | ||||
* | use array maths rather than *args | Aaron Patterson | 2011-01-12 | 1 | -2/+4 |
| | |||||
* | just use respond_to? and super rather than aliasing around methods | Aaron Patterson | 2011-01-12 | 1 | -1/+1 |
| | |||||
* | Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵ | Jon Leighton | 2011-01-11 | 1 | -1/+5 |
| | | | | replaced | ||||
* | Not really worth having the HasAssociation module for just a single method | Jon Leighton | 2011-01-07 | 1 | -2/+0 |
| | |||||
* | Construct an actual ActiveRecord::Relation object for the association scope, ↵ | Jon Leighton | 2011-01-07 | 1 | -17/+10 |
| | | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things. | ||||
* | no need to send a symbol to send() | Aaron Patterson | 2011-01-05 | 1 | -1/+1 |
| | |||||
* | Create the association scope directly rather than going through with_scope | Jon Leighton | 2011-01-03 | 1 | -1/+1 |
| | |||||
* | Use the association directly in other places too | Jon Leighton | 2011-01-03 | 1 | -5/+2 |
| | |||||
* | Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵ | Jon Leighton | 2011-01-03 | 1 | -39/+42 |
| | | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences. | ||||
* | Rename AssociationProxy#foreign_key_present to foreign_key_present? | Jon Leighton | 2011-01-03 | 1 | -1/+1 |
| | |||||
* | Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵ | Jon Leighton | 2010-12-31 | 1 | -4/+0 |
| | | | | inherit from it | ||||
* | Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵ | Jon Leighton | 2010-12-31 | 1 | -1/+1 |
| | | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query. | ||||
* | I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2. | Aaron Patterson | 2010-12-27 | 1 | -2/+2 |
| | |||||
* | Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵ | Jon Leighton | 2010-12-26 | 1 | -4/+2 |
| | | | | other things | ||||
* | Add a HasAssociation module for common code for has_* associations | Jon Leighton | 2010-12-26 | 1 | -0/+2 |
| | |||||
* | Associations: DRY up the code which is generating conditions, and make it ↵ | Jon Leighton | 2010-12-26 | 1 | -1/+1 |
| | | | | all use arel rather than SQL strings | ||||
* | scoped.where_values_hash is never nil | Jon Leighton | 2010-12-26 | 1 | -1/+1 |
| | |||||
* | When a has_many association is not :uniq, appending the same record multiple ↵ | Jon Leighton | 2010-12-23 | 1 | -2/+2 |
| | | | | times should append it to the @target multiple times [#5964 state:resolved] |