aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/association_collection.rb
Commit message (Collapse)AuthorAgeFilesLines
* Make AssociationCollection#include? a bit more readableJon Leighton2011-01-301-4/+10
|
* Don't use method_missing when we don't have toJon Leighton2011-01-301-2/+2
|
* AssociationCollection#clear can basically just use #delete_all, except it ↵Jon Leighton2011-01-301-13/+7
| | | | should return self.
* AssociationCollection#to_ary should definitely dup the target! Also changed ↵Jon Leighton2011-01-301-3/+3
| | | | #replace which was previously incorrect, but the test passed due to the fact that to_a was not duping.
* Just use primary_key here, AR::Relation will resolve the ambiguity before it ↵Jon Leighton2011-01-301-1/+1
| | | | is converted to SQL
* Call sum on the scope directly, rather than relying on method_missing and ↵Jon Leighton2011-01-301-2/+2
| | | | calculate
* Condense first_or_last a bit moreJon Leighton2011-01-301-7/+5
|
* Get rid of separate reset_target! and reset_scopes_cache! methodsJon Leighton2011-01-301-26/+17
|
* target is always an arrayJon Leighton2011-01-301-5/+0
|
* load_target will return the target. it also will not load if loaded? is true.Jon Leighton2011-01-301-2/+1
|
* DRY up first/last and hence make last benefit from the bugfix in firstJon Leighton2011-01-301-15/+13
|
* Use scoped.find directly rather than having a find_by_sql methodJon Leighton2011-01-301-5/+1
|
* Use scoped.first and scoped.last instead of find(:first, ...) and ↵Jon Leighton2011-01-301-2/+2
| | | | find(:last, ...)
* Try to make fetch_first_or_last_using_find? more readableJon Leighton2011-01-301-2/+20
|
* load_target returns the targetJon Leighton2011-01-301-2/+1
|
* Rename AssociationProxy#loaded to loaded! as it mutates the associationJon Leighton2011-01-301-1/+1
|
* Abstract load_target conditional logicJon Leighton2011-01-301-1/+1
|
* Let's be less blasé about method visibility on association proxiesJon Leighton2011-01-301-37/+38
|
* We shouldn't be using scoped.scoping { ... } to build associated records, as ↵Jon Leighton2011-01-301-8/+5
| | | | this can affect validations/callbacks/etc inside the record itself [#6252 state:resolved]
* Nested attributes and in-memory changed values #first and #[] behaviour ↵Alexey Nayden2011-01-281-1/+1
| | | | consistency fix
* push !loaded? conditional upAaron Patterson2011-01-141-10/+8
|
* return early in case the left or right side lists are emptyAaron Patterson2011-01-141-5/+4
|
* only find_target can raise the exception, so isolate the rescue around that callAaron Patterson2011-01-141-5/+9
|
* we always have a target, so stop checkingAaron Patterson2011-01-141-1/+1
|
* we should use [] instead of Array.newAaron Patterson2011-01-141-1/+1
|
* @target is always a list, so stop doing is_a? checksAaron Patterson2011-01-141-1/+1
|
* move complex logic to it's own methodAaron Patterson2011-01-141-15/+19
|
* loaded? will not raise an AR::RecordNotFound exception, so move the rescue ↵Aaron Patterson2011-01-141-4/+4
| | | | inside the conditional
* include_in_memory? should check against @target list in case of new records. ↵Aaron Patterson2011-01-121-2/+2
| | | | [#6257 state:resolved]
* use array maths rather than *argsAaron Patterson2011-01-121-2/+4
|
* just use respond_to? and super rather than aliasing around methodsAaron Patterson2011-01-121-1/+1
|
* Raise ActiveRecord::RecordNotSaved if an AssociationCollection fails to be ↵Jon Leighton2011-01-111-1/+5
| | | | replaced
* Not really worth having the HasAssociation module for just a single methodJon Leighton2011-01-071-2/+0
|
* Construct an actual ActiveRecord::Relation object for the association scope, ↵Jon Leighton2011-01-071-17/+10
| | | | rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
* no need to send a symbol to send()Aaron Patterson2011-01-051-1/+1
|
* Create the association scope directly rather than going through with_scopeJon Leighton2011-01-031-1/+1
|
* Use the association directly in other places tooJon Leighton2011-01-031-5/+2
|
* Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵Jon Leighton2011-01-031-39/+42
| | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
* Rename AssociationProxy#foreign_key_present to foreign_key_present?Jon Leighton2011-01-031-1/+1
|
* Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵Jon Leighton2010-12-311-4/+0
| | | | inherit from it
* Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵Jon Leighton2010-12-311-1/+1
| | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query.
* I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2.Aaron Patterson2010-12-271-2/+2
|
* Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵Jon Leighton2010-12-261-4/+2
| | | | other things
* Add a HasAssociation module for common code for has_* associationsJon Leighton2010-12-261-0/+2
|
* Associations: DRY up the code which is generating conditions, and make it ↵Jon Leighton2010-12-261-1/+1
| | | | all use arel rather than SQL strings
* scoped.where_values_hash is never nilJon Leighton2010-12-261-1/+1
|
* When a has_many association is not :uniq, appending the same record multiple ↵Jon Leighton2010-12-231-2/+2
| | | | times should append it to the @target multiple times [#5964 state:resolved]
* no use for set, no need to to_ary, reduce extra objectsAaron Patterson2010-12-201-3/+2
|
* use array arithmetic rather than create setsAaron Patterson2010-12-201-4/+2
|
* Refactor create_record and build_record in AssociationCollectionJon Leighton2010-12-201-17/+5
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-06 15:24:33 +0000