aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/association_collection.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use the association directly in other places tooJon Leighton2011-01-031-5/+2
|
* Let AssociationCollection#find use #scoped to do its finding. Note that I am ↵Jon Leighton2011-01-031-39/+42
| | | | removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
* Rename AssociationProxy#foreign_key_present to foreign_key_present?Jon Leighton2011-01-031-1/+1
|
* Refactor BelongsToAssociation to allow BelongsToPolymorphicAssociation to ↵Jon Leighton2010-12-311-4/+0
| | | | inherit from it
* Specify the STI type condition using SQL IN rather than a whole load of ORs. ↵Jon Leighton2010-12-311-1/+1
| | | | Required a fix to ActiveRecord::Relation#merge for properly merging create_with_value. This also fixes a situation where the type condition was appearing twice in the resultant SQL query.
* I N C E P T I O N: flatten_deeper works around a bug in Ruby 1.8.2.Aaron Patterson2010-12-271-2/+2
|
* Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵Jon Leighton2010-12-261-4/+2
| | | | other things
* Add a HasAssociation module for common code for has_* associationsJon Leighton2010-12-261-0/+2
|
* Associations: DRY up the code which is generating conditions, and make it ↵Jon Leighton2010-12-261-1/+1
| | | | all use arel rather than SQL strings
* scoped.where_values_hash is never nilJon Leighton2010-12-261-1/+1
|
* When a has_many association is not :uniq, appending the same record multiple ↵Jon Leighton2010-12-231-2/+2
| | | | times should append it to the @target multiple times [#5964 state:resolved]
* no use for set, no need to to_ary, reduce extra objectsAaron Patterson2010-12-201-3/+2
|
* use array arithmetic rather than create setsAaron Patterson2010-12-201-4/+2
|
* Refactor create_record and build_record in AssociationCollectionJon Leighton2010-12-201-17/+5
|
* Delete create, create! and create_record from HasManyThroughAssociation in ↵Jon Leighton2010-12-201-12/+14
| | | | exchange for more generic versions in AssociationCollection
* Specify insert_record with NotImplementedError in AssociationCollection, to ↵Jon Leighton2010-12-201-0/+11
| | | | indicate that subclasses should implement it. Also add save_record to reduce duplication.
* Replace rudimentary named_scope with scope. [#6052 state:resolved]Pavel Gorbokon2010-12-151-8/+8
| | | | | | | * rename method names (actually in tests) * rename instance variable @_named_scopes_cache to @_scopes_cache * rename references in doc comments * don't touch CHANGELOG :)
* Partialy revert f1c13b0dd7b22b5f6289ca1a09f1d7a8c7c8584bJosé Valim2010-11-281-11/+11
|
* nil check unneeded ht. exvivaSantiago Pastorino2010-11-251-1/+1
|
* Use ternary instead explicit return.Emilio Tagua2010-11-251-2/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Remove return, we are already returning self.Emilio Tagua2010-11-251-6/+6
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* class inheritable attributes is used no more! all internal use of class ↵Josh Kalderimis2010-11-201-1/+1
| | | | | | inheritable has been changed to class_attribute. class inheritable attributes has been deprecated. Signed-off-by: José Valim <jose.valim@gmail.com>
* super automatically passes on the implicit blockAaron Patterson2010-11-161-5/+1
|
* use unless instead of if !Aaron Patterson2010-11-161-1/+1
|
* removing space errorsAaron Patterson2010-11-161-3/+3
|
* reloading an association will properly set attributes of instantiated ↵Aaron Patterson2010-11-161-1/+3
| | | | objects. Thanks Brian Palmer [#5802 state:resolved]
* refactoring uniq methodAaron Patterson2010-11-161-7/+4
|
* if association is already loaded and if a find operation is performed on the ↵Neeraj Singh2010-11-151-1/+2
| | | | | | already loaded association list with an empty hash then do not perform another sql [#5972 state:resolved]
* Execute less operationsSantiago Pastorino2010-11-091-2/+1
|
* use persisted? instead of new_record? wherever possibleDavid Chelimsky2010-11-091-10/+11
| | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Refactoring: replace the mix of variables like @finder_sql, @counter_sql, ↵Jon Leighton2010-10-301-37/+29
| | | | etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly.
* Refactor AssociationCollection#include? with objects in memoryCarlos Antonio da Silva2010-10-021-4/+3
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* AssociationCollection#include? working properly for objects added with build ↵Marcelo Giorgi2010-09-301-0/+13
| | | | method [#3472 state:resolved]
* Refactor association_collection uniq method.Emilio Tagua2010-09-221-4/+3
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use scoped here to get the scoped whereSantiago Pastorino2010-09-051-5/+3
|
* While creating a new record using has_many create method default scope of ↵Neeraj Singh2010-08-191-1/+6
| | | | | | | | | | | child should be respected. author.posts.create should take into account default_scope defined on post. [#3939: state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* fixed joining of attributes when using find_or_create_by with multiple ↵Jon Buda2010-07-281-1/+1
| | | | | | attributes through an association Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* No need to check for :uniqNeeraj Singh2010-07-261-6/+3
| | | | | | [#5170 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Make use of tap to return a previously used varSantiago Pastorino2010-07-211-4/+4
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* association load target shouldn't replace recordsSzetobo2010-07-211-3/+4
| | | | | | | | from db if it is already loaded by nested attributes assignment [#5053 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* In nested_attributes when association is not loaded and associationSubba Rao Pasupuleti2010-07-211-1/+8
| | | | | | | | record is saved and then in memory record attributes should be saved [#5053 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Removed warnings when a variable is shadowedŁukasz Strzałkowski2010-07-191-3/+3
|
* Remove unintentional API changes. [#1108]Pratik Naik2010-07-141-9/+4
|
* count method should not take options if it is operated on has_many ↵Neeraj Singh2010-07-131-2/+5
| | | | | | | | association which has finder_sql or counter_sql [#2395 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* fix ActiveRecord `destroy_all` so it returns destroyed recordsMislav Marohnić2010-07-081-3/+4
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Don't remove scheduled destroys when loading an association. [#4642 ↵James Le Cuirot2010-07-011-1/+6
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* AssociationCollection#create_by_*, find_or_create_by_* work properly now. ↵Aaron Patterson2010-06-291-0/+11
| | | | | | [#1108 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Don't define block, just yield if block is given.Emilio Tagua2010-06-241-7/+7
|
* Merge remote branch 'rails/master'Xavier Noria2010-06-201-1/+5
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb
| * Don't overwrite unsaved updates when loading an association but preserve the ↵James Le Cuirot2010-06-201-1/+5
| | | | | | | | | | | | | | | | order of the loaded records. Reapplied from before but now allows already-saved records to be refreshed. [#4830 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>