aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/associations/association.rb
Commit message (Collapse)AuthorAgeFilesLines
...
* remove the nil check from set_inverse_instanceAaron Patterson2013-12-121-1/+2
| | | | | methods that call set_inverse_instance with a record will not have to pay the cost of a nil check on every call
* fix typo, "state_state" should be "stale_state" [ci skip]Scott M2013-12-071-1/+1
|
* Checks to see if the record contains the foreign_key to set the inverse ↵Edo Balvers2013-11-161-1/+6
| | | | automatically
* add inversed accessor to association classDmitry Polushkin2013-10-131-2/+3
|
* inversed instance should not be reloaded after stale state was changedDmitry Polushkin2013-10-131-2/+5
| | | check at association reader that record is inverted and should not be reloaded because of stale was changed at target record
* remove HABTM associationsAaron Patterson2013-10-021-1/+0
|
* add a specific factory method rather than using newAaron Patterson2013-07-231-1/+1
|
* Removed deprecated method scopedNeeraj Singh2013-07-011-5/+0
|
* Simplify/fix implementation of default scopesJon Leighton2013-06-281-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous implementation was necessary in order to support stuff like: class Post < ActiveRecord::Base default_scope where(published: true) scope :ordered, order("created_at") end If we didn't evaluate the default scope at the last possible moment before sending the SQL to the database, it would become impossible to do: Post.unscoped.ordered This is because the default scope would already be bound up in the "ordered" scope, and therefore wouldn't be removed by the "Post.unscoped" part. In 4.0, we have deprecated all "eager" forms of scopes. So now you must write: class Post < ActiveRecord::Base default_scope { where(published: true) } scope :ordered, -> { order("created_at") } end This prevents the default scope getting bound up inside the "ordered" scope, which means we can now have a simpler/better/more natural implementation of default scoping. A knock on effect is that some things that didn't work properly now do. For example it was previously impossible to use #except to remove a part of the default scope, since the default scope was evaluated after the call to #except.
* enhanced comments for foreign_key_present? methodNeeraj Singh2013-05-231-3/+4
|
* Set the inverse when association queries are refinedJon Leighton2013-05-101-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Suppose Man has_many interests, and inverse_of is used. Man.first.interests.first.man will correctly execute two queries, avoiding the need for a third query when Interest#man is called. This is because CollectionAssociation#first calls set_inverse_instance. However Man.first.interests.where("1=1").first.man will execute three queries, even though this is obviously a subset of the records in the association. This is because calling where("1=1") spawns a new Relation object from the CollectionProxy object, and the Relation has no knowledge of the association, so it cannot set the inverse instance. This commit solves the problem by making relations spawned from CollectionProxies return a new Relation subclass called AssociationRelation, which does know about associations. Records loaded from this class will get the inverse instance set properly. Fixes #5717. Live commit from La Conf! :sparkles:
* Do not overwrite manually built records during one-to-one nested attribute ↵Olek Janiszewski2013-05-031-4/+8
| | | | | | | | | | | | | | | | | | | | | assignment For one-to-one nested associations, if you build the new (in-memory) child object yourself before assignment, then the NestedAttributes module will not overwrite it, e.g.: class Member < ActiveRecord::Base has_one :avatar accepts_nested_attributes_for :avatar def avatar super || build_avatar(width: 200) end end member = Member.new member.avatar_attributes = {icon: 'sad'} member.avatar.width # => 200
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-04-111-1/+1
|\ | | | | | | | | Conflicts: guides/source/action_mailer_basics.md
| * minor copy editingNeeraj Singh2013-03-301-1/+1
| |
* | Merge pull request #9996 from mikz/masterJon Leighton2013-04-051-0/+1
|\ \ | |/ |/| Association with inverse_of does not set the parent in association building block
| * fix inverse_of association in block of new childMichal Cichra2013-04-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes inconsistency when building children of association which has inverse_of set properly. When creating new association object with a block: parent.association.build do |child| child.parent.equal?(parent) # false end So the block the `child.parent` did not point to the same object. But when the object is created it points to same instance: child = parent.association.build child.parent.equal?(parent) # true
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-301-1/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip]
| * | explain method invertible_for [ci skip]Neeraj Singh2013-03-291-1/+2
| | |
* | | Do not use deprecate method [ci skip]Neeraj Singh2013-03-291-1/+1
| | |
* | | fix broken sentence [ci skip]Neeraj Singh2013-03-291-1/+1
| |/ |/|
* | Adding a bang to method name of raise_on_type_mismatch.wangjohn2013-03-211-1/+1
|/
* No need to send public methodsAkira Matsuda2013-02-261-1/+1
|
* prevent mass assignment of polymorphic type when using `build`Yves Senn2012-11-221-1/+2
| | | | Closes #8265
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-11-031-1/+1
|\ | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md
| * fix a typo in comments to ActiveRecord::Associations::Association.stale_stateAndrii Dovgaliuk2012-10-241-1/+1
| |
* | Make caller attribute in deprecation methods optionalAlexey Gaziev2012-10-301-1/+1
| |
* | Provide a call stack for deprecation warnings where needed.Nikita Afanasenko2012-10-291-1/+1
|/ | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
* Fix destructive side effects from marshaling an association caused by ↵Jeremy Kemper2012-09-251-5/+2
| | | | 65843e1acc0c8d285ff79f8c9c49d4d1215440be
* Remove mass_assignment_options from ActiveRecordGuillermo Iguaran2012-09-161-3/+3
|
* removes usage of Object#in? from the code base (the method remains defined ↵Xavier Noria2012-08-061-1/+1
| | | | | | | | | | | | | | | | | | | by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in https://github.com/rails/rails/commit/5ea6b0df9a36d033f21b52049426257a4637028d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case.
* load active_support/deprecation in active_support/railsXavier Noria2012-08-021-1/+0
|
* load active_support/core_ext/object/inclusion in active_support/railsXavier Noria2012-08-021-1/+0
|
* s/scoped/scope/Jon Leighton2012-08-011-1/+7
|
* Revert "Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql."Jon Leighton2012-08-011-0/+8
| | | | | | | | | This reverts commit 3803fcce26b837c0117f7d278b83c366dc4ed370. Conflicts: activerecord/CHANGELOG.md It will be deprecated only in 4.0, and removed properly in 4.1.
* Deprecate ActiveRecord::Base.scoped.Jon Leighton2012-07-271-1/+1
| | | | | | | It doesn't serve much purpose now that ActiveRecord::Base.all returns a Relation. The code is moved to active_record_deprecated_finders.
* Remove :finder_sql, :counter_sql, :insert_sql, :delete_sql.Jon Leighton2012-07-201-8/+0
|
* Represent association scope options as AR::Relations insternally.Jon Leighton2012-07-131-5/+16
|
* Allow associations to take a lambda which builds the scopeJon Leighton2012-07-131-1/+5
|
* Fix #5563. Should reflect the most recent change to either of association / id.kennyj2012-04-131-1/+2
|
* Some refactor for association.kennyj2012-04-121-7/+1
| | | | | | | * Remove unused association_class method. * Remove a unnecessary assignment. * Move @updated to BelongsToAssociation that only reference this instance variable. * Reset @stale_state at the reset method. I think this place is right place.
* Get a properly aliased_table_name, when we use a polymorphic association.kennyj2012-04-041-1/+1
|
* Remove IdentityMapCarlos Antonio da Silva2012-03-131-12/+1
|
* Fix #5069 - Protect foreign key from mass assignment throught association ↵Jean Boussier2012-03-051-1/+2
| | | | builder
* Initialize @stale_state to nil in associationCarlos Antonio da Silva2012-03-041-0/+1
| | | | | | | | | | | | | This apparently fix the warning related to @new_record variable not being initialized in AR's test suit, when an association is built and the object is marshalled/loaded. See these tests in AR's base_test.rb: test_marshalling_with_associations test_marshalling_new_record_round_trip_with_associations Closes #3720.
* added failing tests for has_many, has_one and belongs_to associations with ↵Jakub Kuźma2011-12-211-6/+1
| | | | strict mass assignment sanitizer, fixed build_record to not merge creation_attributes, removed failing nested attributes tests (that feature was broken anyway) #4051
* Allow nested attributes in associations to update values in it's owner ↵Andrew Kaspick2011-12-141-0/+2
| | | | object. Fixes a regression from 3.0.x
* Fix private methods which are delegated to. This previously worked because ↵Jon Leighton2011-08-151-8/+8
| | | | Module#delegate previously ignored method visibility.
* Don't construct association scope in initializer. This yields a big ↵Jon Leighton2011-07-071-6/+10
| | | | performance gain for cases where the association is never used to load the target, for example with preloading. Related: #1873.
* Assign the association attributes to the associated record before the ↵Jon Leighton2011-06-301-0/+9
| | | | before_initialize callback of the record runs. Fixes #1842.
* Allow polymorphic has_one to work when the association is set before the ↵Jon Leighton2011-06-081-3/+1
| | | | owner has been saved. Fixes #1524.
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 23:55:04 +0000