Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | we should mark sql strings as sql literals | Aaron Patterson | 2010-08-23 | 1 | -1/+1 |
| | |||||
* | removing unused code | Aaron Patterson | 2010-08-22 | 1 | -3/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -4/+4 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | ensuring that documentation does not exceed 100 columns | Neeraj Singh | 2010-08-01 | 1 | -7/+9 |
| | |||||
* | eagerly loaded association records should respect default_scope [#2931 ↵ | Subba Rao Pasupuleti | 2010-07-21 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Removed warnings when a variable is shadowed | Łukasz Strzałkowski | 2010-07-19 | 1 | -2/+2 |
| | |||||
* | Eager loading :through associations will join the :source model if there are ↵ | Grant Ammons | 2010-07-08 | 1 | -1/+6 |
| | | | | | | :conditions. [#2362 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -6/+6 |
| | | | | not "ActiveRecord" | ||||
* | refactor evals and adds some __FILE__ and __LINE__ | Santiago Pastorino | 2010-05-20 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Dont try to load the record from the db if preloading didn't find anything | Pratik Naik | 2010-03-31 | 1 | -0/+5 |
| | |||||
* | Fix honoring :primary_key option when joining or eager loading a belongs_to ↵ | Ernie Miller | 2010-03-29 | 1 | -1/+1 |
| | | | | | | | | association [#765 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | no more warning interpreted as argument prefix on association_preload.rb | Santiago Pastorino | 2010-02-26 | 1 | -1/+1 |
| | |||||
* | Use unscoped instead of with_exclusive_scope for preloading | Pratik Naik | 2010-01-20 | 1 | -14/+13 |
| | |||||
* | Use new finder methods for association preloading | Pratik Naik | 2010-01-16 | 1 | -17/+16 |
| | |||||
* | Ruby 1.9.2: avoid #flatten | Jeremy Kemper | 2009-11-13 | 1 | -8/+12 |
| | |||||
* | Merge docrails | Pratik Naik | 2009-07-25 | 1 | -2/+2 |
| | |||||
* | Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵ | Joshua Peek | 2009-05-28 | 1 | -1/+1 |
| | | | | "included" block DSL into separate modules. But, unify both approaches under AS::Concern. | ||||
* | Use DependencyModule for included hooks in ActiveRecord | Bryan Helmkamp | 2009-05-11 | 1 | -3/+1 |
| | |||||
* | honour inverse_of when preloading associations | Frederick Cheung | 2009-05-10 | 1 | -1/+3 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Fix :include of has_one with :primary_key option | Frederick Cheung | 2008-12-26 | 1 | -1/+1 |
| | |||||
* | Fix :include of has_many associations with :primary_key option | Frederick Cheung | 2008-12-26 | 1 | -1/+1 |
| | |||||
* | Preload uses exclusive scope [#643 state:resolved] | Frederick Cheung | 2008-12-26 | 1 | -13/+18 |
| | | | | | | | | | With self referential associations, the scope for the the top level should not affect fetching of associations, for example when doing Person.male.find :all, :include => :friends we should load all of the friends for each male, not just the male friends. | ||||
* | Association preloading no longer stops if it hits a nil object [#1630 ↵ | Pivotal Labs | 2008-12-26 | 1 | -2/+2 |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix preloading of has_one :through associations on belongs_to [#1507 ↵ | Matt Jones | 2008-12-18 | 1 | -3/+12 |
| | | | | | | state:resolved] Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com> | ||||
* | Fix preloading of belongs_to with null foreign key generating useless query ↵ | Frederick Cheung | 2008-12-18 | 1 | -0/+1 |
| | | | | [#1027 state:resolved] | ||||
* | Removed extra 'as' in :joins clause for habtm preloading | Foliosus | 2008-12-01 | 1 | -1/+1 |
| | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1405 state:committed] | ||||
* | Remove redundant uniq | Frederick Cheung | 2008-11-11 | 1 | -1/+1 |
| | |||||
* | explicitly including child associations that are also included in the parent ↵ | Will Bryant | 2008-10-10 | 1 | -0/+3 |
| | | | | | | | association definition should not result in double records in the collection/double loads (#1110) Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1110 state:committed] | ||||
* | Merge docrails | Pratik Naik | 2008-10-05 | 1 | -3/+87 |
| | |||||
* | Remove HasManyAssociationStrategy and move the logic to ↵ | Pratik Naik | 2008-10-04 | 1 | -26/+4 |
| | | | | ActiveRecord::Reflection::ThroughReflection. | ||||
* | Fix has_many :through when the source is a belongs_to association. [#323 ↵ | Zach Dennis | 2008-10-04 | 1 | -10/+34 |
| | | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | fix eager loading's :condition sanitizing expanding against the wrong table | Will Bryant | 2008-09-29 | 1 | -5/+5 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | fixed association preloading to use = instead of IN when there's only one record | rsl | 2008-09-10 | 1 | -5/+8 |
| | | | | | | [#1013 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix preloading of has_one through associations | Frederick Cheung | 2008-08-25 | 1 | -6/+2 |
| | | | | | | [#903 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Make sure association preloading works with full STI class name [#465 ↵ | Joachim Garth | 2008-07-18 | 1 | -1/+1 |
| | | | | | | state:Resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Merge with docrails. | Pratik Naik | 2008-07-16 | 1 | -1/+1 |
| | |||||
* | Fix integer quoting issues in association preload. [#602 state:resolved] | Tiago Macedo | 2008-07-14 | 1 | -3/+12 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed non-standard SQL generated by preloading has_and_belongs_to_many ↵ | Antonio Cangiano | 2008-06-11 | 1 | -2/+2 |
| | | | | association | ||||
* | When preloading group by reflection rather than by class [#125 state:resolved] | Frederick Cheung | 2008-05-11 | 1 | -6/+6 |
| | | | | | | | | This avoids extra queries when several subclasses inherit the association from their parent class, while still coping with subclasses redefining associations. Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure hm:t preloading honours reflection options. [#137 state:resolved] | Frederick Cheung | 2008-05-11 | 1 | -5/+6 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Ensure correct record is returned when preloading has_one where more than ↵ | Frederick Cheung | 2008-05-06 | 1 | -1/+6 |
| | | | | | | | one row exists Signed-off-by: Michael Koziarski <michael@koziarski.com> [#73 state:closed] | ||||
* | Fixed AssociationsPreload such that it doesnt require foreign keys to be ↵ | David Heinemeier Hansson | 2008-04-30 | 1 | -11/+15 |
| | | | | integers (fcheung) [#33 state:resolved] | ||||
* | Ensure table names are quoted by the association preloading code. | Frederick Cheung | 2008-04-26 | 1 | -9/+7 |
| | | | | | | [#45 state:resolved] Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | More efficient association preloading code that compacts a through_records ↵ | Rick Olson | 2008-03-26 | 1 | -8/+11 |
| | | | | | | array in a central location. Closes #11427 [danger] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | has_one :through supports :source_type. Fix up some tests. References #4756. | Jeremy Kemper | 2008-03-22 | 1 | -2/+7 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9075 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Add has_one :through support, finally. Closes #4756 [thechrisoshow] | Rick Olson | 2008-03-21 | 1 | -5/+29 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Fix that batched :include would pull in duplicate records in some cases. ↵ | Jeremy Kemper | 2008-02-28 | 1 | -1/+1 |
| | | | | | | Closes #11215 [Catfish] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Fix preloading nil polymorphic belongs_to. Closes #11218 [matrix9180] | Jeremy Kemper | 2008-02-27 | 1 | -5/+6 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Don't assume all records from nested include are of same class. Closes ↵ | Jeremy Kemper | 2008-02-19 | 1 | -1/+5 |
| | | | | | | #11154 [acechase] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Ensure nested preloading works when associations return nil. Closes #11145 ↵ | Michael Koziarski | 2008-02-18 | 1 | -1/+1 |
| | | | | | | [GMFlash] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |