Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | we have a method for setting preloaded records, so use it | Aaron Patterson | 2011-01-18 | 1 | -6/+2 |
| | |||||
* | reduce objects, reduce loops and function calls while building the conditional | Aaron Patterson | 2011-01-18 | 1 | -4/+2 |
| | |||||
* | keys will always be strings in the id => record map | Aaron Patterson | 2011-01-18 | 1 | -1/+1 |
| | |||||
* | reduce method calls and loops when dealing with custom conditions | Aaron Patterson | 2011-01-18 | 1 | -4/+3 |
| | |||||
* | ony bother with record map keys when we need them | Aaron Patterson | 2011-01-18 | 1 | -9/+9 |
| | |||||
* | refactor elaborate group_by in to a normal group_by | Aaron Patterson | 2011-01-18 | 1 | -8/+3 |
| | |||||
* | lazily instantiate AR objects in order to avoid NoMethodErrors | Aaron Patterson | 2011-01-11 | 1 | -8/+14 |
| | |||||
* | Get rid of set_association_target and association_loaded? as the parts of ↵ | Jon Leighton | 2011-01-11 | 1 | -6/+13 |
| | | | | the code that need that can now just use association_proxy(:name).loaded?/target= | ||||
* | avoid splatting arrays by using concat | Aaron Patterson | 2011-01-11 | 1 | -3/+3 |
| | |||||
* | only use one array when collecting split up queries | Aaron Patterson | 2011-01-10 | 1 | -1/+1 |
| | |||||
* | When preloading a belongs_to, the target should still be set (to nil) if ↵ | Jon Leighton | 2011-01-03 | 1 | -9/+14 |
| | | | | there is no foreign key present. And the loaded flag should be set on the association proxy. This then allows us to remove the foreign_key_present? check from BelongsToAssociation#find_target. Also added a test for the same thing on polymorphic associations. | ||||
* | Have a proper AssociationReflection#foreign_type method rather than using ↵ | Jon Leighton | 2011-01-03 | 1 | -7/+4 |
| | | | | options[:foreign_type] | ||||
* | Rename AssociationReflection#primary_key_name to foreign_key, since the ↵ | Jon Leighton | 2010-12-31 | 1 | -11/+11 |
| | | | | options key which it relates to is :foreign_key | ||||
* | try not to make so many funcalls | Aaron Patterson | 2010-12-26 | 1 | -3/+6 |
| | |||||
* | make our hash of klasses and ids actually have classes for keys | Aaron Patterson | 2010-12-26 | 1 | -8/+6 |
| | |||||
* | Refactor we_can_set_the_inverse_on_this? to use a less bizarre name amongst ↵ | Jon Leighton | 2010-12-26 | 1 | -3/+2 |
| | | | | other things | ||||
* | refactor to use group_by | Aaron Patterson | 2010-12-25 | 1 | -3/+3 |
| | |||||
* | arel will deal with casting the ids, so we can delete this | Aaron Patterson | 2010-12-25 | 1 | -13/+1 |
| | |||||
* | use arel to determine selection column | Aaron Patterson | 2010-12-25 | 1 | -2/+1 |
| | |||||
* | refactoring method selection | Aaron Patterson | 2010-12-25 | 1 | -10/+5 |
| | |||||
* | using arel to compile sql statements | Aaron Patterson | 2010-12-25 | 1 | -8/+17 |
| | |||||
* | use sql literal factory method | Aaron Patterson | 2010-12-25 | 1 | -1/+1 |
| | |||||
* | take more advantage of arel sql compiler | Aaron Patterson | 2010-12-25 | 1 | -12/+20 |
| | |||||
* | refactoring AST building | Aaron Patterson | 2010-12-25 | 1 | -5/+3 |
| | |||||
* | use arel to compile SQL statements | Aaron Patterson | 2010-12-25 | 1 | -6/+15 |
| | |||||
* | avoid duping and new objects | Aaron Patterson | 2010-12-23 | 1 | -2/+3 |
| | |||||
* | probably should use the some_ids variable here. o_O | Aaron Patterson | 2010-12-22 | 1 | -1/+1 |
| | |||||
* | removing SQL interpolation, please use scoping and attribute conditionals as ↵ | Aaron Patterson | 2010-12-22 | 1 | -6/+1 |
| | | | | a replacement | ||||
* | use arel to compile SQL rather than build strings | Aaron Patterson | 2010-12-22 | 1 | -1/+8 |
| | |||||
* | build an AST rather than build SQL strings | Aaron Patterson | 2010-12-22 | 1 | -1/+10 |
| | |||||
* | Fix problem with duplicated records when a :uniq :through association is ↵ | Jon Leighton | 2010-12-15 | 1 | -0/+1 |
| | | | | preloaded [#2447 state:resolved] | ||||
* | Removed ids_in_list_limit in favor of in_clause_length defined in ↵ | Alex Rothenberg | 2010-11-23 | 1 | -2/+2 |
| | | | | database_limits.rb | ||||
* | removing space errors | Aaron Patterson | 2010-11-18 | 1 | -1/+1 |
| | |||||
* | Adapters can specify maximum number of ids they support in a list of expressions | Alex Rothenberg | 2010-11-18 | 1 | -5/+21 |
| | | | | | (default is nil meaning unlimited but Oracle imposes a limit of 1000) Limit is used to make multiple queries when preloading associated has_many or habtm records | ||||
* | Convert :primary_key in association to a string before comparing to column ↵ | Denis Odorcic | 2010-10-30 | 1 | -1/+1 |
| | | | | names, so that for example :primary_key => :another_pk works as well [#5605 state:resolved] | ||||
* | refactor to remove `through_records` | Aaron Patterson | 2010-10-23 | 1 | -10/+7 |
| | |||||
* | removing dead code | Aaron Patterson | 2010-10-23 | 1 | -2/+0 |
| | |||||
* | Revert "porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks ↵ | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | | | | | | Marcelo Giorgi" This reverts commit 9eca11a4a564f44675cca951216e917b8f610eab. | ||||
* | porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵ | Aaron Patterson | 2010-09-28 | 1 | -1/+1 |
| | | | | Giorgi | ||||
* | Prevent shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -3/+3 |
| | |||||
* | remove more codes | Aaron Patterson | 2010-09-21 | 1 | -6/+4 |
| | |||||
* | deleting more code | Aaron Patterson | 2010-09-21 | 1 | -4/+1 |
| | |||||
* | use each properly to avoid splatting a variable | Aaron Patterson | 2010-09-21 | 1 | -2/+1 |
| | |||||
* | deleting repeated codes | Aaron Patterson | 2010-09-21 | 1 | -13/+10 |
| | |||||
* | we should mark sql strings as sql literals | Aaron Patterson | 2010-08-23 | 1 | -1/+1 |
| | |||||
* | removing unused code | Aaron Patterson | 2010-08-22 | 1 | -3/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -4/+4 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | ensuring that documentation does not exceed 100 columns | Neeraj Singh | 2010-08-01 | 1 | -7/+9 |
| | |||||
* | eagerly loaded association records should respect default_scope [#2931 ↵ | Subba Rao Pasupuleti | 2010-07-21 | 1 | -1/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Removed warnings when a variable is shadowed | Łukasz Strzałkowski | 2010-07-19 | 1 | -2/+2 |
| |