aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/lib/active_record/aggregations.rb
Commit message (Collapse)AuthorAgeFilesLines
* Push multi-parameter assignement into the typesSean Griffin2015-02-071-1/+2
| | | | | | | | | | | | This allows us to remove `Type::Value#klass`, as it was only used for multi-parameter assignment to reach into the types internals. The relevant type objects now accept a hash in addition to their previous accepted arguments to `type_cast_from_user`. This required minor modifications to the tests, since previously they were relying on the fact that mulit-parameter assignement was reaching into the internals of time zone aware attributes. In reaility, changing those properties at runtime wouldn't change the accessor methods for all other forms of assignment.
* Improve the performance of reading attributesSean Griffin2014-11-181-2/+2
| | | | | | | We added a comparison to "id", and call to `self.class.primary_key` a *lot*. We also have performance hits from `&block` all over the place. We skip the check in a new method, in order to avoid breaking the behavior of `read_attribute`
* Merge pull request #15542 from Gaurav2728/gaurav-remove_shutdown_linkArthur Nogueira Neves2014-06-061-4/+4
|\ | | | | remove rubyforge.org that was shut down [ci skip]
| * remove rubyforge.org that was shut down [ci skip]Gaurav Sharma2014-06-061-4/+4
| |
* | Remove composed_of special case from multi-parameter attributesSean Griffin2014-06-061-0/+4
|/ | | | | As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case.
* Use destructured arguments when looping through pairsSean Griffin2014-05-171-4/+4
| | | | Minor refactoring of looping behavior for aggregation
* Remove conditional adding a new methodRafael Mendonça França2013-09-111-1/+1
| | | | | | At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method
* factory methods should not have side effects.Aaron Patterson2013-07-231-1/+2
| | | | Move model mutation to the methods that are called on the model.
* AR::Base does not need to know how to create reflection objectsAaron Patterson2013-07-221-1/+1
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-01-091-1/+1
|\ | | | | | | | | Conflicts: guides/source/getting_started.md
| * remove meaningless use of Relation#allAkira Matsuda2013-01-031-1/+1
| | | | | | | | particularly, `all(options)` would warn
* | remove meaningless AS::FrozenObjectErrorAkira Matsuda2013-01-021-1/+1
|/
* 1.9 hash syntax changesAvnerCohen2012-11-081-18/+18
|
* Revert "Removing composed_of from ActiveRecord."Rafael Mendonça França2012-07-271-0/+261
| | | | | | | | | | | This reverts commit 14fc8b34521f8354a17e50cd11fa3f809e423592. Reason: we need to discuss a better path from this removal. Conflicts: activerecord/lib/active_record/reflection.rb activerecord/test/cases/base_test.rb activerecord/test/models/developer.rb
* Removing composed_of from ActiveRecord.Steve Klabnik2012-06-181-261/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-231-3/+3
|\
| * Revert "Remove blank trailing comments"Vijay Dev2012-05-231-0/+2
| | | | | | | | | | | | | | | | | | | | This reverts commit fa6d921e11363e9b8c4bc10f7aed0b9faffdc33a. Reason: Not a fan of such massive changes. We usually close such changes if made to Rails master as a pull request. Following the same principle here and reverting. [ci skip]
| * Remove blank trailing commentsHenrik Hodne2012-05-201-2/+0
| | | | | | | | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed.
| * Revert typoOscar Del Ben2012-05-191-1/+1
| |
| * TypoOscar Del Ben2012-05-191-4/+4
| |
* | Refactor aggregation writer methodCarlos Antonio da Silva2012-05-211-4/+3
| | | | | | | | Only constantize class_name once.
* | Merge pull request #6143 from senny/composed_of_converter_returns_nilAaron Patterson2012-05-211-7/+8
|\ \ | |/ |/| allow the :converter Proc form composed_of to return nil
| * allow the :converter Proc form composed_of to return nilYves Senn2012-05-031-7/+8
| | | | | | | | | | | | | | This makes it possible to filter invalid input values before they are passed into the value-object (like empty strings). This behaviour is only relevant if the :allow_nil options is set to true. Otherwise you will get the resulting NoMethodError.
* | missing 'with'Hrvoje Šimić2012-05-111-1/+1
| |
* | Add empty rows to improve readability. [ci skip]Edward Tsech2012-05-011-0/+2
| |
* | Add few lines to describe how aggregation part caching works. [ci skip]Edward Tsech2012-05-011-0/+4
| |
* | simpler wording and explanationsHrvoje Šimić2012-05-011-3/+3
| |
* | Fixed typo in composed_of example with Money#<=>, was comparing amount ↵Noah Hendrix2012-02-241-1/+1
| | | | | | | | itself instead of other_money.amount
* | minor fixes in the composed_of docVijay Dev2011-10-221-3/+4
| |
* | Remove extra white spaces on ActiveRecord docs.Sebastian Martinez2011-05-231-1/+1
|/
* remove unnecessary module_evalAaron Patterson2011-01-181-25/+20
|
* send() will raise an ArgumentError, so we should leverage rubyAaron Patterson2011-01-071-16/+6
|
* no need for parensAaron Patterson2011-01-071-1/+1
|
* use a hash for caching aggregations rather than ivarsAaron Patterson2011-01-071-12/+6
|
* method is never called with argumentsAaron Patterson2011-01-071-4/+2
|
* use persisted? instead of new_record? wherever possibleDavid Chelimsky2010-11-091-1/+1
| | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use new finders syntax in docs.Emilio Tagua2010-09-011-1/+1
|
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-141-48/+48
| | | | 's/[ \t]*$//' -i {} \;)
* ensuring that documentation does not exceed 100 columnsNeeraj Singh2010-08-011-7/+6
|
* ensuring that documentation does not exceed 100 columnsNeeraj Singh2010-07-311-51/+65
|
* Remove deprecated block usage in composed_of.Emilio Tagua2010-06-241-4/+2
|
* Adds title and basic description where needed.Rizwan Reza2010-06-151-0/+1
|
* eliminate alias_method_chain from ActiveRecordwycats2010-05-091-0/+1
|
* fisting uninitialized ivar warnings. [#4198 state:resolved]Aaron Patterson2010-03-161-0/+5
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵Joshua Peek2009-05-281-1/+1
| | | | "included" block DSL into separate modules. But, unify both approaches under AS::Concern.
* Use DependencyModule for included hooks in ActiveRecordBryan Helmkamp2009-05-111-3/+1
|
* Merge docrailsPratik Naik2008-10-051-2/+2
|
* Expanded documentation for new composed_of optionsRob Anderton2008-09-101-10/+53
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#892 state:committed]
* Added :constructor and :converter options to composed_of and deprecated the ↵Rob Anderton2008-09-101-31/+60
| | | | | | conversion block Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Merge docrails.Pratik Naik2008-05-251-9/+9
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 02:46:27 +0000