Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #15542 from Gaurav2728/gaurav-remove_shutdown_link | Arthur Nogueira Neves | 2014-06-06 | 1 | -4/+4 |
|\ | | | | | remove rubyforge.org that was shut down [ci skip] | ||||
| * | remove rubyforge.org that was shut down [ci skip] | Gaurav Sharma | 2014-06-06 | 1 | -4/+4 |
| | | |||||
* | | Remove composed_of special case from multi-parameter attributes | Sean Griffin | 2014-06-06 | 1 | -0/+4 |
|/ | | | | | As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case. | ||||
* | Use destructured arguments when looping through pairs | Sean Griffin | 2014-05-17 | 1 | -4/+4 |
| | | | | Minor refactoring of looping behavior for aggregation | ||||
* | Remove conditional adding a new method | Rafael Mendonça França | 2013-09-11 | 1 | -1/+1 |
| | | | | | | At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method | ||||
* | factory methods should not have side effects. | Aaron Patterson | 2013-07-23 | 1 | -1/+2 |
| | | | | Move model mutation to the methods that are called on the model. | ||||
* | AR::Base does not need to know how to create reflection objects | Aaron Patterson | 2013-07-22 | 1 | -1/+1 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-01-09 | 1 | -1/+1 |
|\ | | | | | | | | | Conflicts: guides/source/getting_started.md | ||||
| * | remove meaningless use of Relation#all | Akira Matsuda | 2013-01-03 | 1 | -1/+1 |
| | | | | | | | | particularly, `all(options)` would warn | ||||
* | | remove meaningless AS::FrozenObjectError | Akira Matsuda | 2013-01-02 | 1 | -1/+1 |
|/ | |||||
* | 1.9 hash syntax changes | AvnerCohen | 2012-11-08 | 1 | -18/+18 |
| | |||||
* | Revert "Removing composed_of from ActiveRecord." | Rafael Mendonça França | 2012-07-27 | 1 | -0/+261 |
| | | | | | | | | | | | This reverts commit 14fc8b34521f8354a17e50cd11fa3f809e423592. Reason: we need to discuss a better path from this removal. Conflicts: activerecord/lib/active_record/reflection.rb activerecord/test/cases/base_test.rb activerecord/test/models/developer.rb | ||||
* | Removing composed_of from ActiveRecord. | Steve Klabnik | 2012-06-18 | 1 | -261/+0 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807 | ||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-23 | 1 | -3/+3 |
|\ | |||||
| * | Revert "Remove blank trailing comments" | Vijay Dev | 2012-05-23 | 1 | -0/+2 |
| | | | | | | | | | | | | | | | | | | | | This reverts commit fa6d921e11363e9b8c4bc10f7aed0b9faffdc33a. Reason: Not a fan of such massive changes. We usually close such changes if made to Rails master as a pull request. Following the same principle here and reverting. [ci skip] | ||||
| * | Remove blank trailing comments | Henrik Hodne | 2012-05-20 | 1 | -2/+0 |
| | | | | | | | | | | | | | | For future reference, this is the regex I used: ^\s*#\s*\n(?!\s*#). Replace with the first match, and voilà! Note that the regex matches a little bit too much, so you probably want to `git add -i .` and go through every single diff to check if it actually should be changed. | ||||
| * | Revert typo | Oscar Del Ben | 2012-05-19 | 1 | -1/+1 |
| | | |||||
| * | Typo | Oscar Del Ben | 2012-05-19 | 1 | -4/+4 |
| | | |||||
* | | Refactor aggregation writer method | Carlos Antonio da Silva | 2012-05-21 | 1 | -4/+3 |
| | | | | | | | | Only constantize class_name once. | ||||
* | | Merge pull request #6143 from senny/composed_of_converter_returns_nil | Aaron Patterson | 2012-05-21 | 1 | -7/+8 |
|\ \ | |/ |/| | allow the :converter Proc form composed_of to return nil | ||||
| * | allow the :converter Proc form composed_of to return nil | Yves Senn | 2012-05-03 | 1 | -7/+8 |
| | | | | | | | | | | | | | | This makes it possible to filter invalid input values before they are passed into the value-object (like empty strings). This behaviour is only relevant if the :allow_nil options is set to true. Otherwise you will get the resulting NoMethodError. | ||||
* | | missing 'with' | Hrvoje Šimić | 2012-05-11 | 1 | -1/+1 |
| | | |||||
* | | Add empty rows to improve readability. [ci skip] | Edward Tsech | 2012-05-01 | 1 | -0/+2 |
| | | |||||
* | | Add few lines to describe how aggregation part caching works. [ci skip] | Edward Tsech | 2012-05-01 | 1 | -0/+4 |
| | | |||||
* | | simpler wording and explanations | Hrvoje Šimić | 2012-05-01 | 1 | -3/+3 |
| | | |||||
* | | Fixed typo in composed_of example with Money#<=>, was comparing amount ↵ | Noah Hendrix | 2012-02-24 | 1 | -1/+1 |
| | | | | | | | | itself instead of other_money.amount | ||||
* | | minor fixes in the composed_of doc | Vijay Dev | 2011-10-22 | 1 | -3/+4 |
| | | |||||
* | | Remove extra white spaces on ActiveRecord docs. | Sebastian Martinez | 2011-05-23 | 1 | -1/+1 |
|/ | |||||
* | remove unnecessary module_eval | Aaron Patterson | 2011-01-18 | 1 | -25/+20 |
| | |||||
* | send() will raise an ArgumentError, so we should leverage ruby | Aaron Patterson | 2011-01-07 | 1 | -16/+6 |
| | |||||
* | no need for parens | Aaron Patterson | 2011-01-07 | 1 | -1/+1 |
| | |||||
* | use a hash for caching aggregations rather than ivars | Aaron Patterson | 2011-01-07 | 1 | -12/+6 |
| | |||||
* | method is never called with arguments | Aaron Patterson | 2011-01-07 | 1 | -4/+2 |
| | |||||
* | use persisted? instead of new_record? wherever possible | David Chelimsky | 2010-11-09 | 1 | -1/+1 |
| | | | | | | | | | | | - persisted? is the API defined in ActiveModel - makes it easier for extension libraries to conform to ActiveModel APIs without concern for whether the extended object is specifically ActiveRecord [#5927 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Use new finders syntax in docs. | Emilio Tagua | 2010-09-01 | 1 | -1/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -48/+48 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | ensuring that documentation does not exceed 100 columns | Neeraj Singh | 2010-08-01 | 1 | -7/+6 |
| | |||||
* | ensuring that documentation does not exceed 100 columns | Neeraj Singh | 2010-07-31 | 1 | -51/+65 |
| | |||||
* | Remove deprecated block usage in composed_of. | Emilio Tagua | 2010-06-24 | 1 | -4/+2 |
| | |||||
* | Adds title and basic description where needed. | Rizwan Reza | 2010-06-15 | 1 | -0/+1 |
| | |||||
* | eliminate alias_method_chain from ActiveRecord | wycats | 2010-05-09 | 1 | -0/+1 |
| | |||||
* | fisting uninitialized ivar warnings. [#4198 state:resolved] | Aaron Patterson | 2010-03-16 | 1 | -0/+5 |
| | | | | Signed-off-by: wycats <wycats@gmail.com> | ||||
* | Break up DependencyModule's dual function of providing a "depend_on" DSL and ↵ | Joshua Peek | 2009-05-28 | 1 | -1/+1 |
| | | | | "included" block DSL into separate modules. But, unify both approaches under AS::Concern. | ||||
* | Use DependencyModule for included hooks in ActiveRecord | Bryan Helmkamp | 2009-05-11 | 1 | -3/+1 |
| | |||||
* | Merge docrails | Pratik Naik | 2008-10-05 | 1 | -2/+2 |
| | |||||
* | Expanded documentation for new composed_of options | Rob Anderton | 2008-09-10 | 1 | -10/+53 |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#892 state:committed] | ||||
* | Added :constructor and :converter options to composed_of and deprecated the ↵ | Rob Anderton | 2008-09-10 | 1 | -31/+60 |
| | | | | | | conversion block Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Merge docrails. | Pratik Naik | 2008-05-25 | 1 | -9/+9 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Partial updates include only unsaved attributes. Off by default; set ↵ | Jeremy Kemper | 2008-03-31 | 1 | -2/+2 |
| | | | | | | YourClass.partial_updates = true to enable. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Support aggregations in finder conditions. Closes #10572. | Jeremy Kemper | 2008-01-19 | 1 | -0/+9 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |