aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/Rakefile
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Style/RedundantBegin` cop to avoid newly adding redundant begin blockRyuta Kamizono2018-12-211-5/+3
| | | | | | | | | | Currently we sometimes find a redundant begin block in code review (e.g. https://github.com/rails/rails/pull/33604#discussion_r209784205). I'd like to enable `Style/RedundantBegin` cop to avoid that, since rescue/else/ensure are allowed inside do/end blocks in Ruby 2.5 (https://bugs.ruby-lang.org/issues/12906), so we'd probably meets with that situation than before.
* Use utf8mb4 character set by default for MySQL database (#33608)Yasuo Honda2018-09-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use utf8mb4 character set by default `utf8mb4` character set supports supplementary characters including emoji. `utf8` character set with 3-Byte encoding is not enough to support them. There was a downside of 4-Byte length character set with MySQL 5.5 and 5.6: "ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes" for Rails string data type which is mapped to varchar(255) type. MySQL 5.7 supports 3072 byte key prefix length by default. * Remove `DEFAULT COLLATE` from Active Record unit test databases There should be no "one size fits all" collation in MySQL 5.7. Let MySQL server choose the default collation for Active Record unit test databases. Users can choose their best collation for their databases by setting `options[:collation]` based on their requirements. * InnoDB FULLTEXT indexes support since MySQL 5.6 it does not have to use MyISAM storage engine whose maximum key length is 1000 bytes. Using MyISAM storag engine with utf8mb4 character set would cause "Specified key was too long; max key length is 1000 bytes" https://dev.mysql.com/doc/refman/5.6/en/innodb-fulltext-index.html * References "10.9.1 The utf8mb4 Character Set (4-Byte UTF-8 Unicode Encoding)" https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8mb4.html "10.9.2 The utf8mb3 Character Set (3-Byte UTF-8 Unicode Encoding)" https://dev.mysql.com/doc/refman/5.7/en/charset-unicode-utf8.html "14.8.1.7 Limits on InnoDB Tables" https://dev.mysql.com/doc/refman/5.7/en/innodb-restrictions.html > If innodb_large_prefix is enabled (the default), the index key prefix limit is 3072 bytes > for InnoDB tables that use DYNAMIC or COMPRESSED row format. * CI against MySQL 5.7 Followed this instruction and changed root password to empty string. https://docs.travis-ci.com/user/database-setup/#MySQL-57 * The recommended minimum version of MySQL is 5.7.9 to support utf8mb4 character set and `innodb_default_row_format` MySQL 5.7.9 introduces `innodb_default_row_format` to support 3072 byte length index by default. Users do not have to change MySQL database configuration to support Rails string type. https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_default_row_format https://dev.mysql.com/doc/refman/5.7/en/innodb-restrictions.html > If innodb_large_prefix is enabled (the default), > the index key prefix limit is 3072 bytes for InnoDB tables that use DYNAMIC or COMPRESSED row format. * The recommended minimum version of MariaDB is 10.2.2 MariaDB 10.2.2 is the first version of MariaDB supporting `innodb_default_row_format` Also MariaDB says "MySQL 5.7 is compatible with MariaDB 10.2". - innodb_default_row_format https://mariadb.com/kb/en/library/xtradbinnodb-server-system-variables/#innodb_default_row_format - "MariaDB versus MySQL - Compatibility" https://mariadb.com/kb/en/library/mariadb-vs-mysql-compatibility/ > MySQL 5.7 is compatible with MariaDB 10.2 - "Supported Character Sets and Collations" https://mariadb.com/kb/en/library/supported-character-sets-and-collations/
* Display db:drop description in ActiveRecordYoshiyuki Hirano2018-04-031-1/+3
|
* Enable `Layout/SpaceBeforeComma` rubocop rule, and fixed moreRyuta Kamizono2017-12-121-1/+1
| | | | Follow up of #31390.
* Use frozen-string-literal in ActiveRecordKir Shatrov2017-07-191-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Use `require_relative` instead of `require` with full pathbogdanvlviv2017-06-141-2/+2
|
* Define path with __dir__bogdanvlviv2017-05-231-3/+3
| | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* Merge pull request #25927 from y-yagi/remove_needless_warning_for_hstoreSean Griffin2017-01-031-5/+0
|\ | | | | remove needless warning for hstore
| * remove needless warning for hstoreyuuji.yaginuma2016-08-151-5/+0
| | | | | | | | | | Rails 5 supports only Postgresql 9.1 or higher, warning is needless because in the case of Postgresql 9.0 or less does not work.
* | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-2/+2
| |
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-011-1/+1
|/
* modernizes hash syntax in activerecordXavier Noria2016-08-061-13/+13
|
* applies new string literal convention to the rest of the projectXavier Noria2016-08-061-38/+38
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* systematic revision of =~ usage in ARXavier Noria2016-07-231-2/+2
| | | | | Where appropriatei, prefer the more concise Regexp#match?, String#include?, String#start_with?, or String#end_with?
* Remove package:clean taskJavan Makhmali2016-05-241-1/+0
| | | | Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
* Wrangle the asset build into something that sounds more generalMatthew Draper2016-02-011-0/+3
|
* Remove legacy mysql adapterAbdelkader Boudih2015-12-171-7/+7
|
* Allow mysql and mysql2 tests run by database user with passwordYasuo Honda2015-08-181-4/+4
|
* Merge pull request #20256 from ↵Sean Griffin2015-07-241-9/+0
|\ | | | | | | | | arunagw/aa-remove-unused-rule-and-task-activerecord Remove unused rule and task from activerecord
| * Remove unused rule and task from activerecordArun Agrawal2015-05-221-9/+0
| |
* | Remove unused package tasksArun Agrawal2015-05-281-7/+0
| | | | | | | | We are using `all:build` now.
* | Remove broken and unused release taskArun Agrawal2015-05-221-9/+0
|/ | | | | - We do release with release.rb - There is no `rake/gemcutter`
* Updated postgresql documentation link to use latest version [ci skip]Ronak Jangir2015-05-201-1/+1
|
* Revert "For now, we will keep sorting the tests."Matthew Draper2015-03-061-1/+1
| | | | This reverts commit 7025d7769dc53f0a3ffab8b537727ef3fee367fc.
* Follow up to #16613Robin Dupret2014-09-281-0/+1
| | | | | | | | | | | | Since we want this flag to be enabled anytime we are running the tests under JRuby, let's enable this at the Rakefile level so people get the performance boost on their local checkout. Moreover, we avoid having to update this particular line anytime the option changes on the JRuby side. The only drawback is that we have to define it in every Rakefile but there's no big deal, this is already the case for other options.
* For now, we will keep sorting the tests.Matthew Draper2014-09-051-1/+1
| | | | | This reverts commits e969c928463e329fd6529ac59cad96385c538ffb and bd2b3fbe54e750ba97469a7896e8d143d6dfd465.
* No need to sort testsAkira Matsuda2014-08-281-1/+1
| | | | Dir.glob result must be already sorted anyway
* Encapsulate rake lines from ActiveRecord/ActionPack as CodeTools::LineStatisticsBenjamin Fleischer2014-07-251-21/+3
| | | | [ci skip]
* Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-161-71/+74
|
* Remove code related to adapter which are no longer in repoArun Agrawal2014-05-161-1/+1
| | | | As we have remove code for these adapters so no need to have tasks
* rake, remove frontbase related tasks from Active Record Rakefile.Yves Senn2014-05-141-46/+0
|
* Revert "Merge pull request #14940 from arunagw/hbakhtiyor-test-db-namespaces-ar"Yves Senn2014-05-031-107/+95
| | | | | This reverts commit fe9859600824268ff614cb3eb48b62c7165a1fbd, reversing changes made to add9560643ef79830febf47fa1228752d1df3502.
* Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi]Arun Agrawal2014-05-031-95/+107
|
* Add description for db:create and db:drop test tasks in ARCarlos Antonio da Silva2013-11-171-2/+4
| | | | | This will help identify these tasks exists, since they are easier to setup things for running all AR tests.
* grab executable from rubygemsArun Agrawal2013-07-261-2/+1
| | | As done here d7fc97d3f90c0e30865d32ce202658f03248cacc
* Cleanup task for informing about hstoreVipul A M2013-07-251-6/+3
|
* Merge pull request #11046 from arunagw/verbose_mode_onCarlos Antonio da Silva2013-06-251-1/+1
|\ | | | | Verbose mode on when running tests
| * Adding verbose in isolated test.Arun Agrawal2013-06-211-1/+1
| |
* | Saying gemcutter => rubygems [ci skip]Arun Agrawal2013-06-211-1/+1
|/
* No need to load 'rake/packagetask' as it's alreadyArun Agrawal2013-06-021-1/+0
| | | | | in 'rubygems/package_task'
* Remove unnecessary code, because this extension is created on demand in ↵kennyj2013-05-151-2/+0
| | | | hstore_test.rb.
* added db:drop task that executes mysql:drop_databses and ↵Ranjay Krishna2013-01-201-0/+1
| | | | postgresql:drop_databases
* removed the puts statement and simplified the execute statementRanjay Krishna2013-01-201-6/+1
|
* added rake db:create that executes mysql:build_databases and ↵Ranjay Krishna2013-01-201-0/+9
| | | | postgresql:build_databases
* use template0 option for creating activerecord test databases in postgres ↵Bobby Wilson2012-08-191-2/+2
| | | | build_database task
* Create hstore extension when building PostgreSQL databases.kennyj2012-06-121-0/+10
|
* Rakefile executable attributes and shebang lines has been removedRoman V. Babenko2012-05-021-1/+0
|
* Verbose output for tests.Arun Agrawal2012-02-031-0/+1
| | | | | See #3892
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-15 19:57:40 +0000