aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/CHANGELOG.md
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #12588 from jetthoughts/12586_subquery_with_unprepared_sqlRafael Mendonça França2013-10-211-2/+11
|\ | | | | | | | | | | | | Inline bind values for sub-queries generated for Relation in where Conflicts: activerecord/CHANGELOG.md
| * Process sub-query relation's binding valuesPaul Nikitochkin2013-10-201-0/+9
| | | | | | | | | | | | | | | | | | Generated sub-query for Relation as array condition for `where` method did not take in account its bind values, in result generates invalid SQL query. Fixed by adding sub-query relation's binding values to base relation Closes: #12586
* | Fix loading a sql structure file on postgres when the file's path has ↵Kevin Mook2013-10-211-0/+5
| | | | | | | | whitespace in it
* | Allow unscope to work with `where.not`Eric Hankins2013-10-211-0/+8
| | | | | | | | | | | | Allows you to call #unscope on a relation with negative equality operators, i.e. Arel::Nodes::NotIn and Arel::Nodes::NotEqual that have been generated through the use of where.not.
* | Raise an exception when model without primary key calls .find_with_idsShimpei Makimoto2013-10-211-0/+4
| |
* | In Relation#empty? use #exists? instead of #count.Szymon Nowak2013-10-191-0/+4
|/
* Convert Fixnum into String the port number in MySQLKenta Okamoto2013-10-181-0/+4
|
* Fix code blocks identation on AR and AS CHANGELOGsLucas Mazza2013-10-161-6/+6
|
* Merge pull request #12547 from derekprior/dp-fix-null-relation-pluckRafael Mendonça França2013-10-151-0/+7
|\ | | | | Pluck on NullRelation should accept a list of columns
| * Pluck on NullRelation accepts a list of columnsDerek Prior2013-10-151-0/+7
| | | | | | | | | | | | `pluck` was updated to accept a list of columns, but the `NullRelation` was never updated to match that signature. As a result, calling `pluck` on a `NullRelation` results in an `ArgumentError`.
* | grammar fix (reverted in e9a1ecd)Vijay Dev2013-10-151-1/+1
|/
* scope_chain should not be mutated for other reflectionsNeeraj Singh2013-10-141-0/+13
| | | | | | | | | | | Currently `scope_chain` uses same array for building different `scope_chain` for different associations. During processing these arrays are sometimes mutated and because of in-place mutation the changed `scope_chain` impacts other reflections. Fix is to dup the value before adding to the `scope_chain`. Fixes #3882.
* Merge pull request #9499 from ↵Rafael Mendonça França2013-10-141-0/+6
|\ | | | | | | | | | | | | | | | | dmitry/inverse_instance_should_not_be_reloaded_after_stale_state_change Inversed instance should not be reloaded after stale state was changed Conflicts: activerecord/CHANGELOG.md
| * Add a note to the changelog for #9499Dmitry Polushkin2013-10-131-0/+6
| |
* | cleanup changelog entry format. [ci skip]Yves Senn2013-10-141-2/+4
|/
* Merge pull request #12508 from ↵Rafael Mendonça França2013-10-131-0/+17
|\ | | | | | | | | | | | | | | | | jetthoughts/12415_generate_subqueries_for_relation_from_binding_params Generate subquery for Relation passed as array condition for where Conflicts: activerecord/CHANGELOG.md
| * Generate subquery for Relation passed as array condition for wherePaul Nikitochkin2013-10-131-0/+17
| | | | | | | | | | | | | | | | | | Instead of executing 2 queries for fetching records filtered by array condition with Relation, added generation of subquery to current query. This behaviour will be consistent when passes Relation as hash condition to where Closes: #12415
* | Merge pull request #12511 from ↵Rafael Mendonça França2013-10-131-0/+6
|\ \ | | | | | | | | | | | | jetthoughts/informative_raise_message_for_incorrect_association Make missed association exception message more informative
| * | Make missed association exception message more informativePaul Nikitochkin2013-10-131-0/+6
| |/ | | | | | | | | Add target class name, which should have missed association on preload, into exception message to simplify detecting problem part.
* / Fixes #11773 when using includes combined with select, the select statement ↵Edo Balvers2013-10-081-0/+6
|/ | | | was overwritten.
* `intiantiated` => `instantiated` [ci-skip]Vipul A M2013-10-031-1/+1
|
* add a note to the changelogAaron Patterson2013-10-021-0/+3
|
* unify `Fixes` notes in AR changelog. [ci skip].Yves Senn2013-10-021-7/+7
|
* change the savepoint interface to allow passing the name.Yves Senn2013-09-301-0/+5
|
* Make `.next_migration_number` reusable for third party AR generators.Yves Senn2013-09-301-0/+4
|
* Removed where_values_hash from AR::NullRelationPaul Nikitochkin2013-09-281-0/+7
| | | | | | | | | | | | | | | | | | | In order to build associated records for owners which has not been saved need to get where values to use as default attributes. But for new record owner uses `ActiveRecord::NullRelation` which override `where_values_hash` to return empty hash stub. `where_values_hash` is not used to invoke any sql query, but good to build others chains (even will be never executed) like: ```ruby post = Post.new admin_comment = post.admin_comments.build assert_equal 'Admin', admin_comment.author ``` Closes #11376, #11676, #11675
* changelog entryArthur Neves2013-09-251-0/+6
|
* update changelog for #12359Arthur Neves2013-09-251-1/+5
|
* ActiveRecord::ConnectionAdapters::Column.string_to_time method respects ↵kennyj2013-09-251-0/+7
| | | | string with timezone. Closes #12278.
* Merge pull request #9860 from wangjohn/update_attributes_throws_error_with_nilRafael Mendonça França2013-09-241-0/+10
|\ | | | | | | | | | | | | Raising an error when nil is passed to update_attributes. Conflicts: activerecord/CHANGELOG.md
| * Raising an error when nil or non-hash is passed to update_attributes.wangjohn2013-06-251-0/+10
| |
* | Deprecate unused quoted_locking_column method.kennyj2013-09-241-0/+4
| |
* | Merge pull request #11382 from kennyj/fix_10751-2Rafael Mendonça França2013-09-221-0/+6
|\ \ | | | | | | | | | | | | | | | | | | Dump UUID default functions to schema.rb [2nd version]. Fixes #10751. Conflicts: activerecord/CHANGELOG.md
| * | Migration dump UUID default functions to schema.rb. Fixes #10751.kennyj2013-07-101-0/+5
| | |
* | | Give the credits [ci skip]Rafael Mendonça França2013-09-221-0/+2
| | |
* | | Merge pull request #10500 from kennyj/fix_10450Rafael Mendonça França2013-09-221-0/+7
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixed a bug in when using has_many association with :inverse_of option and UUID primary key. Conflicts: activerecord/CHANGELOG.md
| * | | Fixed a bug in when using has_many association with :inverse_of option and ↵kennyj2013-05-081-0/+5
| | | | | | | | | | | | | | | | UUID primary key.
* | | | ActiveRecord::Base#<=> has been removed. Primary keys may not be in order,Aaron Patterson2013-09-181-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | or even be numbers, so sorting by id doesn't make sense. Please use `sort_by` and specify the attribute you wish to sort with. For example, change: Post.all.to_a.sort to: Post.all.to_a.sort_by(&:id)
* | | | Merge pull request #12011 from jetthoughts/11963_fix_join_with_association_scopeRafael Mendonça França2013-09-161-0/+8
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Collapse where constraints to the Arel::Nodes::And node Conflicts: activerecord/CHANGELOG.md
| * | | | Collapse where constraints to one where constraintPaul Nikitochkin2013-09-131-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to remove duplication with joining arel where constraints with `AND`, all constraints on `build_arel` are collapsed into one head node: `Arel::Nodes::And` Closes: #11963
* | | | | Merge pull request #12129 from Empact/deprecate-array-bang-delegationRafael Mendonça França2013-09-121-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Deprecate the delegation of Array bang methods in ActiveRecord::Delegation Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/relation_test.rb
| * | | | | Deprecate the delegation of Array bang methods in ActiveRecord::DelegationBen Woosley2013-09-041-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The primary means of returning results for Array bang methods is to modify the array in-place. When you call these methods on a relation, that array is created, modified, and then thrown away. Only the secondary return value is exposed to the caller. Removing this delegation is a straight-forward way to reduce user error by forcing callers to first explicitly call #to_a in order to expose the array to be acted on by the bang method.
* | | | | | Merge pull request #12137 from lann/fix_association_first_lastRafael Mendonça França2013-09-121-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md
| * | | | | | Make CollectionAssociation first/last with integer fetch with queryLann Martin2013-09-091-0/+5
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When first or last is called with an integer on an unloaded association, the entire collection is loaded. This differs surprisingly from the behavior of Relation#first/last, which translate the call into a limit query. For large collections this can make a big difference in performance. Change CollectionAssociation#fetch_first_or_last_using_find? to make this kind of call delegate to Relation.
* | | | | | Add CHANGELOG entry for #11698Rafael Mendonça França2013-09-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | Merge pull request #12156 from rywall/from-copy-bindsRafael Mendonça França2013-09-121-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow Relation#from to accept other relations with bind values. Conflicts: activerecord/CHANGELOG.md
| * | | | | | Allow Relation#from to accept other relations with bind values.Ryan Wallace2013-09-081-0/+4
| |/ / / / /
* | | | | | Check if the SQL is not a prepared statementRafael Mendonça França2013-09-111-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
* | | | | | Merge pull request #12135 from dylanahsmith/avoid_empty_transactionRafael Mendonça França2013-09-111-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md
| * | | | | | Avoid empty transaction from setting has_one association on new record.Dylan Thacker-Smith2013-09-111-0/+5
| | | | | | |