| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Only one constraint option can be used at a time (except for the minimum
and maximum ones that can eventually be combined). However, other
options can be used with them (e.g. the validation failure message).
So let's make the distinction between these two different options
categories.
[Yves Senn, Matthew Draper & Robin Dupret]
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The heading "Active Model Length Validator" was shown on the
"ActiveModel::Validations" page without any text following it.
|
|
|
|
|
|
| |
Closes #11209
[Roque Pinel & Steven Yang]
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This adds a script `bin/test` to most Rails framework components. The
script uses the rails minitest plugin to augment the runner.
See https://github.com/rails/rails/pull/19571 for details about the
plugin.
I did not yet add `bin/test` for activerecord, activejob and railties.
These components rely on specific setup performed in the rake-tasks.
|
|
|
|
|
|
|
|
| |
AM::Serialization#serializable_hash"
This reverts commit 3d949f34816d6eca0a6b59cfa08d91f36e8e64dd.
This was already documented in other PR.
|
| |
|
| |
|
| |
|
|\
| |
| | |
add docs to include option at ActiveModel::Serialization [ci skip]
|
| |
| |
| |
| | |
[ci skip]
|
| |
| |
| |
| |
| | |
It was removed when we removed mocha at
5a6ae7f7539216931f2b3f4aa53394ac4136c74e
|
| | |
|
| | |
|
| |
| |
| |
| | |
We are using `all:build` now.
|
|\ \
| | |
| | | |
Remove broken and unused release task
|
| | |
| | |
| | |
| | |
| | | |
- We do release with release.rb
- There is no `rake/gemcutter`
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
spelling fix [ci skip]
example to be consistent [ci skip]
grammatical fix
typo fixes [ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I think we are better off leaving `sudo` outside of the documented
way of installing gems (`activerecord`, `actionpack`, …).
We don’t want newbies to think that `sudo` is required or, even worse, than
they actually have to type `[sudo] gem install`.
In most scenarios, `sudo` is not needed to install gems, and people who do
need it, probably already know about it.
What do you think? :grin:
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The test was skipped because of an issue that, in the meantime,
has been fixed: https://github.com/rubinius/rubinius/issues/3328.
Using the latest Rubinius (the one currently on Travis CI), this
is the result:
```sh
$ ruby --version
rubinius 2.5.3 (2.1.0 2482b093 2015-05-10 3.5.1 JI) [x86_64-darwin14.3.0]
```
**Before this PR**
```sh
$ ruby -Itest test/cases/attribute_assignment_test.rb
Run options: --seed 58569
.....S...
Finished in 0.048278s, 186.4203 runs/s, 269.2738 assertions/s.
9 runs, 13 assertions, 0 failures, 0 errors, 1 skips
You have skipped tests. Run with --verbose for details.
```
**After this PR**
$ ruby -Itest test/cases/attribute_assignment_test.rb
Run options: --seed 35720
.........
Finished in 0.029441s, 305.6961 runs/s, 475.5273 assertions/s.
9 runs, 14 assertions, 0 failures, 0 errors, 0 skips
```
|
| | |
|
|/
|
|
|
| |
I believe this is a use case that was supposed to be supported, and it's
a small fix.
|
|
|
|
| |
`ActiveModel::Serialization#serializable_hash`
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
| |
A conjunction was needed to make these sentences correct. Breaking them
up seemed like a better option.
[ci skip]
|
|
|
|
| |
[ci skip]
|
| |
|
|
|
|
|
|
|
|
| |
`ActiveModel::Dirty#[attr_name]_previous_change` to improve access
to recorded changes after the model has been saved.
It makes the dirty-attributes query methods consistent before and after
saving.
|
|\
| |
| | |
Upgrade to Ruby 2.2.2
|
| |
| |
| |
| | |
and fix the grammar in the ruby_version_check.rb user message.
|
|\ \
| | |
| | | |
Fix AS::Callbacks raising an error when `:run` callback is defined.
|
| | |
| | |
| | |
| | | |
This reverts commit 796cab45561fce268aa74e6587cdb9cae3bb243e.
|
| | | |
|
| |/
|/| |
|
|\ \
| | |
| | | |
Require Module#delegate core ext in ActiveModel::Naming
|
| | | |
|
|\ \ \
| | | |
| | | | |
Simplify and alias ActiveModel::Errors methods where possible
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As demonstrated by #19570, this option is severely limited, and
satisfies an extremely specific use case. Realistically, there's not
much reason for this option to exist. Its functionality can be trivially
replicated with a normal Ruby method. Let's deprecate this option, in
favor of the simpler solution.
|
| | | |
| | | |
| | | |
| | | | |
The expected value comes first. Related to #19465.
|
| |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rails 5.0 changes to ActiveModel::Errors include addition of `details`
that also accidentally changed the return value of `delete`. Since
there was no test for that behavior it went unnoticed. This commit
adds a test and fixes the regression.
Small improvements to comments have also been made. Since `get` is
getting deprecated it is better to use `[]` in other methods' code
examples. Also, in the module usage example, `def Person.method`
was replaced with a more commonly used `def self.method` code style.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Deprecation messages in ActiveModel::Errors are using String#squish
from ActiveSupport but were not explicitly requiring it, causing failures
when used outside rails.
|
| | |
| | |
| | |
| | | |
This is a follow-up to #19257
|
| | |
| | |
| | |
| | | |
This reverts commit 7025d7769dc53f0a3ffab8b537727ef3fee367fc.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 2f52f969885b2834198de0045748436a4651a94e.
Conflicts:
actionmailer/test/abstract_unit.rb
actionview/test/abstract_unit.rb
activemodel/test/cases/helper.rb
activerecord/test/cases/helper.rb
activesupport/test/abstract_unit.rb
railties/test/abstract_unit.rb
|