aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
* let this regexp be stricterXavier Noria2011-04-191-1/+1
| | | | | | | | | The purpose of this regexp is to detect strings that are valid identifiers to be used as method names. The anchor $ allows a trailing newline, and both ^ and $ may be bypassed because Ruby regexps are multiline always. The anchors \A and \z are the proper ones to ensure string boundaries.
* Let's not dup because value may not always be duplicable.José Valim2011-04-191-1/+1
|
* Avoid define_method if possible.José Valim2011-04-191-12/+39
|
* bcrypt will encrypt anything, so validate_presence_of would not catch nil / ↵Aaron Patterson2011-04-142-1/+15
| | | | blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this
* Declaring the attr_accessor for password_confirmation is not necessaryBrian Cardarella2011-04-141-2/+1
| | | | as the confirmation validation already adds that attr_accessor
* Remove `#among?` from Active SupportPrem Sichanugrist2011-04-131-1/+1
| | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-04-121-1/+1
|\
| * RewordingOge Nnadi2011-04-111-1/+1
| |
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵David Heinemeier Hansson2011-04-121-1/+1
| | | | | | | | suggestion!
* | Remove code duplication.José Valim2011-04-113-20/+27
| |
* | No need to rescue here. Invoking the wrong method in an object can happen ↵José Valim2011-04-116-40/+0
| | | | | | | | anywhere if you are not careful. In other words, test your shit.
* | Revert "Add :use_include option to allow user to explicitly use ↵José Valim2011-04-114-37/+14
| | | | | | | | | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67.
* | Using Object#in? and Object#either? in various placesPrem Sichanugrist2011-04-112-2/+4
| | | | | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
* | Add :use_include option to allow user to explicitly use `Range#include?` ↵Prem Sichanugrist2011-04-104-14/+37
| | | | | | | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option.
* | Add support for proc or lambda as an option for InclusionValidator, ↵Prem Sichanugrist2011-04-107-20/+167
| | | | | | | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator
* | Rename test directory to match code directoryJohn Firebaugh2011-04-062-0/+0
|/ | | | Hopefully "serializeration" is not an in joke that I missed.
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-04-031-11/+10
|\
| * Fix formatting and broken markupJohn Firebaugh2011-03-281-11/+10
| |
* | Gem::Specification#has_rdoc= is deprecated since rubygems 1.7.0Santiago Pastorino2011-04-021-2/+0
| |
* | Bring back AMo#i18n_key methodSantiago Pastorino2011-03-303-8/+13
|/
* use class_eval with a string when it's possibleSantiago Pastorino2011-03-221-2/+8
|
* Do not in place modify what table_name returnsSantiago Pastorino2011-03-222-12/+1
|
* define_attr_method should be able to define methods that returns nilSantiago Pastorino2011-03-172-2/+4
|
* remove misleading commentAaron Patterson2011-03-171-2/+0
|
* dup strings on return so that in place modifications do not break anything. ↵Aaron Patterson2011-03-172-1/+12
| | | | I am looking at you "compute_table_name"
* define_attr_method correctly defines methods with invalid identifiersSantiago Pastorino2011-03-162-5/+6
|
* Add a define_attr_method testSantiago Pastorino2011-03-161-0/+13
|
* Add test for define_attr_method using as name an invalid identifierSantiago Pastorino2011-03-161-0/+13
|
* Add test for define_attribute_method using as name an invalid identifierSantiago Pastorino2011-03-161-3/+26
|
* Fix typo in assertion messageAndrew White2011-03-161-1/+1
|
* Add messages to plain assertions.Norman Clarke2011-03-151-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Refactor length validationSantiago Pastorino2011-03-122-6/+6
|
* length validation for fixnumsAndriy Tyurnikov2011-03-122-1/+13
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add additional text to NotImplementedErrors [#6328 state:resolved]Mike Gehard2011-03-121-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-03-075-25/+18
|\
| * formatting changesVijay Dev2011-03-072-15/+14
| |
| * Configuration options are symbolsPaco Guzman2011-03-061-2/+2
| |
| * Remove Example headers. Code just flows with the text. 6ce844a3Paco Guzman2011-03-063-8/+2
| |
* | remove unused assigned variablePaco Guzman2011-03-061-1/+1
|/
* Active Model typos.R.T. Lechow2011-03-052-2/+2
|
* Move ActiveModel::AttributeMethods#attribute_methods_generated? to ↵Alexander Uvarov2011-03-013-28/+28
| | | | | | | | ActiveRecord, so it's flexible now [#6428 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]"Santiago Pastorino2011-02-275-37/+8
| | | | | | | This breaks #6448, you should use :"module/class" as key for namespacing [#6448 state:committed] This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557.
* failing test for i18n key collision with namespaced modelsSantiago Pastorino2011-02-272-0/+11
|
* We're in 2011, let's update our licensePrem Sichanugrist2011-02-222-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Merge branch 'master' of git://github.com/lifo/docrailsXavier Noria2011-02-2111-12/+52
|\
| * copy-edits 8d96b89Xavier Noria2011-02-219-11/+26
| |
| * copy-edits 6d7a826Xavier Noria2011-02-211-3/+3
| |
| * copy-edits 34316d8Xavier Noria2011-02-211-7/+5
| |
| * Docs: Update to_xml documentation to match as_json docuemntationNicholas Rowe2011-02-201-0/+25
| |
| * Documentation: Added small comments to Observering moduleNicholas Rowe2011-02-201-0/+3
| |