Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Fix AMo code example indent, add missing author to entry [ci skip] | Carlos Antonio da Silva | 2013-03-09 | 1 | -6/+8 | |
| | | | ||||||
* | | | Merge pull request #9545 from senny/9535_secure_password_blank | Rafael Mendonça França | 2013-03-07 | 5 | -3/+75 | |
|\ \ \ | | | | | | | | | `has_secure_password` is not invalid when assigning empty Strings | |||||
| * | | | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 3 | -2/+24 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | |||||
| * | | | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 3 | -1/+51 | |
| | | | | ||||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-05 | 1 | -1/+1 | |
|\ \ \ \ | |/ / / |/| | | | ||||||
| * | | | Small Typo | Lebin Sebastian F | 2013-03-04 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Update CHANGELOGS | Rafael Mendonça França | 2013-02-26 | 1 | -0/+3 | |
|/ / / | ||||||
* | | | Preparing for 4.0.0.beta1 release | David Heinemeier Hansson | 2013-02-25 | 2 | -2/+2 | |
| | | | ||||||
* | | | did a pass over the AM changelog [ci skip] | Xavier Noria | 2013-02-24 | 1 | -15/+35 | |
| | | | ||||||
* | | | added more accurate test for add_on_empty | Angelo capilleri | 2013-02-19 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-15 | 1 | -0/+3 | |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | |||||
| * | | | Clarify ActiveModel::Validator initialization in docs. | Henrik Nyh | 2013-02-09 | 1 | -0/+3 | |
| | | | | | | | | | | | | As discussed with @josevalim on Ruby Rogues Parley. | |||||
* | | | | Take care of whitespaces and changing the hash syntax | Rafael Mendonça França | 2013-02-04 | 1 | -57/+56 | |
| | | | | ||||||
* | | | | test for issue 8931 | David | 2013-02-02 | 1 | -0/+8 | |
|/ / / | ||||||
* | | | Missing require extract_options | Akira Matsuda | 2013-01-31 | 1 | -0/+2 | |
| | | | ||||||
* | | | Adding the route_key and param_key tests | Attila Domokos | 2013-01-22 | 1 | -0/+8 | |
| | | | | | | | | | This way all the tests are testing the same fields | |||||
* | | | Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by" | Guillermo Iguaran | 2013-01-18 | 2 | -3/+3 | |
| | | | | | | | | | | | | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1. | |||||
* | | | User Rails 4 find_by | robertomiranda | 2013-01-18 | 2 | -3/+3 | |
| | | | ||||||
* | | | Merge pull request #8940 from adomokos/adding_tests_for_changed_attributes | Carlos Antonio da Silva | 2013-01-15 | 1 | -1/+12 | |
|\ \ \ | | | | | | | | | Cleaning up ActiveModel::Dirty tests | |||||
| * | | | Cleaning up ActiveModel::Dirty tests | Attila Domokos | 2013-01-15 | 1 | -1/+12 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Clarifying what the #changed method returns * Adding tests to describe what the #changed_attributes returns * Updating test name based on pull request comment * Moving the test lower in the file per pull request comment | |||||
* | | | | ActiveRecord <-> Active Record [ci skip] | Trung Lê | 2013-01-15 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | test for ActiveModel::Conversion#to_partial_path and namespaced models | Yves Senn | 2013-01-14 | 2 | -0/+8 | |
|/ / / | ||||||
* | | | Adding tests for ActiveModel::Model | Attila Domokos | 2013-01-12 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | * Verifying persisted? is false when Model initialized * Passing nil to Model should not blow up * Changing test name to the one suggested in pull request comment | |||||
* | | | Covering untested methods for ActiveModel::Errors | Attila Domokos | 2013-01-10 | 1 | -0/+53 | |
| | | | ||||||
* | | | Set default value to ActiveModel::Validator initializer attribute | Irio Irineu Musskopf Junior | 2013-01-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | Makes it easier to test its objects. | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-01-09 | 2 | -19/+1 | |
|\ \ \ | |/ / |/| | | | | | | | | Conflicts: guides/source/getting_started.md | |||||
| * | | prefer american spelling of 'behavior' | Gosha Arinich | 2013-01-07 | 1 | -1/+1 | |
| | | | ||||||
| * | | Observers was extracted from Active Model as `rails-observers` gem | Akira Matsuda | 2013-01-02 | 1 | -18/+0 | |
| | | | ||||||
* | | | Reduce number of Strings a bit | Akira Matsuda | 2013-01-07 | 2 | -3/+3 | |
| | | | ||||||
* | | | Namespace HashWithIndifferentAccess | Akira Matsuda | 2013-01-07 | 1 | -1/+1 | |
|/ / | ||||||
* | | Updated copyright notices for 2013 | Andrew Nesbitt | 2012-12-31 | 2 | -2/+2 | |
| | | ||||||
* | | Add active_support/testing/autorun | Rafael Mendonça França | 2012-12-31 | 1 | -1/+1 | |
| | | | | | | | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails | |||||
* | | This change doesn't need a CHANGELOG entry. | Rafael Mendonça França | 2012-12-26 | 1 | -5/+0 | |
| | | | | | | | | [ci skip] | |||||
* | | Add CHANGELOG entry for #8622 | Rafael Mendonça França | 2012-12-26 | 2 | -2/+7 | |
| | | ||||||
* | | Revert the change at ActiveModel::Errors#add_on_blank and fix in the | Rafael Mendonça França | 2012-12-26 | 3 | -14/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621. | |||||
* | | Tests and fix for validates_presence of :allow_nil, :allow_blank | Colin Kelley | 2012-12-26 | 2 | -1/+41 | |
| | | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb | |||||
* | | chmod -x from non-script files | Akira Matsuda | 2012-12-24 | 2 | -0/+0 | |
| | | ||||||
* | | Remove CHANGELOG entry for ActiveModel::Errors#add_on_present | Rafael Mendonça França | 2012-12-21 | 1 | -5/+0 | |
| | | ||||||
* | | Use :present as key for the absence validatior message | Rafael Mendonça França | 2012-12-21 | 2 | -2/+2 | |
| | | ||||||
* | | Remove ActiveModel::Errors#add_on_present method. | Rafael Mendonça França | 2012-12-21 | 3 | -16/+3 | |
| | | | | | | | | | | | | | | | | We don't need to define a new method in ActiveMode::Errors for each validatior. See https://github.com/rails/rails/commit/d72a07f1d1478db9daed847eadb35bfd840674f6#commitcomment-2325333 | |||||
* | | Fix Action Mailer changelog indenation to match other changelogs | Carlos Antonio da Silva | 2012-12-19 | 1 | -0/+1 | |
| | | | | | | | | Also some minor improvements to other changelogs. [ci skip] | |||||
* | | Improve AMo changelog example to not rely on AR [ci skip] | Carlos Antonio da Silva | 2012-12-19 | 1 | -4/+8 | |
| | | ||||||
* | | Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the ↵ | Roberto Vasquez Angel | 2012-12-15 | 5 | -0/+131 | |
| | | | | | | | | | | | | absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes. | |||||
* | | Convert changelogs to 1.9 hash style and fix some formatting [ci skip] | Carlos Antonio da Silva | 2012-12-14 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #8510 from thedarkone/thread_safety_improvements | Aaron Patterson | 2012-12-14 | 1 | -4/+5 | |
|\ \ | | | | | | | Thread safety improvements | |||||
| * | | Replace some global Hash usages with the new thread safe cache. | thedarkone | 2012-12-14 | 1 | -4/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler. | |||||
* | | | Only call `in_time_zone` on Time or DateTime instances | Andrew White | 2012-12-11 | 1 | -1/+6 | |
|/ / | | | | | | | | | Both String and Date now respond to in_time_zone so we need to check if the value is a Time or a DateTime. | |||||
* | | Revert "Omit directories from gemspec.files for RubyGems 2 compat." | Jeremy Kemper | 2012-12-09 | 1 | -1/+1 | |
| | | | | | | | | | | | | Obviated by rubygems/rubygems@486ed83cc8e706069213c5d406122f4cfcca9e7f This reverts commit bb8923dee093b615615cdfb83b34d1b0bb254f25. | |||||
* | | Omit directories from gemspec.files for RubyGems 2 compat. | Jeremy Kemper | 2012-12-08 | 1 | -1/+1 | |
| | | | | | | | | | | | | RG2 packager expects each spec.files path to be a file and bombs when it tries to tarball a dir. May revert if rubygems/rubygems#413 is accepted. | |||||
* | | Replace comments' non-breaking spaces with spaces | claudiob | 2012-12-04 | 3 | -6/+6 | |
| | | | | | | | | | | | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code. |