aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
...
| * `has_secure_password` is not invalid when assigning empty Strings.Yves Senn2013-03-043-2/+24
| | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`.
| * `validates_confirmation_of` does not override writer methods.Yves Senn2013-03-043-1/+51
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-051-1/+1
|\ \ | |/ |/|
| * Small TypoLebin Sebastian F2013-03-041-1/+1
| |
* | Update CHANGELOGSRafael Mendonça França2013-02-261-0/+3
|/
* Preparing for 4.0.0.beta1 releaseDavid Heinemeier Hansson2013-02-252-2/+2
|
* did a pass over the AM changelog [ci skip]Xavier Noria2013-02-241-15/+35
|
* added more accurate test for add_on_emptyAngelo capilleri2013-02-191-0/+7
| | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-151-0/+3
|\ | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * Clarify ActiveModel::Validator initialization in docs.Henrik Nyh2013-02-091-0/+3
| | | | | | As discussed with @josevalim on Ruby Rogues Parley.
* | Take care of whitespaces and changing the hash syntaxRafael Mendonça França2013-02-041-57/+56
| |
* | test for issue 8931David2013-02-021-0/+8
|/
* Missing require extract_optionsAkira Matsuda2013-01-311-0/+2
|
* Adding the route_key and param_key testsAttila Domokos2013-01-221-0/+8
| | | This way all the tests are testing the same fields
* Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by"Guillermo Iguaran2013-01-182-3/+3
| | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1.
* User Rails 4 find_byrobertomiranda2013-01-182-3/+3
|
* Merge pull request #8940 from adomokos/adding_tests_for_changed_attributesCarlos Antonio da Silva2013-01-151-1/+12
|\ | | | | Cleaning up ActiveModel::Dirty tests
| * Cleaning up ActiveModel::Dirty testsAttila Domokos2013-01-151-1/+12
| | | | | | | | | | | | | | * Clarifying what the #changed method returns * Adding tests to describe what the #changed_attributes returns * Updating test name based on pull request comment * Moving the test lower in the file per pull request comment
* | ActiveRecord <-> Active Record [ci skip]Trung Lê2013-01-151-2/+2
| |
* | test for ActiveModel::Conversion#to_partial_path and namespaced modelsYves Senn2013-01-142-0/+8
|/
* Adding tests for ActiveModel::ModelAttila Domokos2013-01-121-0/+6
| | | | | | * Verifying persisted? is false when Model initialized * Passing nil to Model should not blow up * Changing test name to the one suggested in pull request comment
* Covering untested methods for ActiveModel::ErrorsAttila Domokos2013-01-101-0/+53
|
* Set default value to ActiveModel::Validator initializer attributeIrio Irineu Musskopf Junior2013-01-091-1/+1
| | | | Makes it easier to test its objects.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-01-092-19/+1
|\ | | | | | | | | Conflicts: guides/source/getting_started.md
| * prefer american spelling of 'behavior'Gosha Arinich2013-01-071-1/+1
| |
| * Observers was extracted from Active Model as `rails-observers` gemAkira Matsuda2013-01-021-18/+0
| |
* | Reduce number of Strings a bitAkira Matsuda2013-01-072-3/+3
| |
* | Namespace HashWithIndifferentAccessAkira Matsuda2013-01-071-1/+1
|/
* Updated copyright notices for 2013Andrew Nesbitt2012-12-312-2/+2
|
* Add active_support/testing/autorunRafael Mendonça França2012-12-311-1/+1
| | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails
* This change doesn't need a CHANGELOG entry.Rafael Mendonça França2012-12-261-5/+0
| | | | [ci skip]
* Add CHANGELOG entry for #8622Rafael Mendonça França2012-12-262-2/+7
|
* Revert the change at ActiveModel::Errors#add_on_blank and fix in theRafael Mendonça França2012-12-263-14/+8
| | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621.
* Tests and fix for validates_presence of :allow_nil, :allow_blankColin Kelley2012-12-262-1/+41
| | | | | Conflicts: activemodel/lib/active_model/errors.rb
* chmod -x from non-script filesAkira Matsuda2012-12-242-0/+0
|
* Remove CHANGELOG entry for ActiveModel::Errors#add_on_presentRafael Mendonça França2012-12-211-5/+0
|
* Use :present as key for the absence validatior messageRafael Mendonça França2012-12-212-2/+2
|
* Remove ActiveModel::Errors#add_on_present method.Rafael Mendonça França2012-12-213-16/+3
| | | | | | | | We don't need to define a new method in ActiveMode::Errors for each validatior. See https://github.com/rails/rails/commit/d72a07f1d1478db9daed847eadb35bfd840674f6#commitcomment-2325333
* Fix Action Mailer changelog indenation to match other changelogsCarlos Antonio da Silva2012-12-191-0/+1
| | | | Also some minor improvements to other changelogs. [ci skip]
* Improve AMo changelog example to not rely on AR [ci skip]Carlos Antonio da Silva2012-12-191-4/+8
|
* Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the ↵Roberto Vasquez Angel2012-12-155-0/+131
| | | | | | absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes.
* Convert changelogs to 1.9 hash style and fix some formatting [ci skip]Carlos Antonio da Silva2012-12-141-1/+1
|
* Merge pull request #8510 from thedarkone/thread_safety_improvementsAaron Patterson2012-12-141-4/+5
|\ | | | | Thread safety improvements
| * Replace some global Hash usages with the new thread safe cache.thedarkone2012-12-141-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Add thread_safe gem. * Use thread safe cache for digestor caching. * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation. * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache. * Use TS::Cache to avoid the synchronisation overhead on listener retrieval. * Replace synchronisation with TS::Cache usage. * Use a preallocated array for performance/memory reasons. * Update the controllers cache to the new AS::Dependencies::ClassCache API. The original @controllers cache no longer makes much sense after @tenderlove's changes in 7b6bfe84f3 and f345e2380c. * Use TS::Cache in the connection pool to avoid locking overhead. * Use TS::Cache in ConnectionHandler.
* | Only call `in_time_zone` on Time or DateTime instancesAndrew White2012-12-111-1/+6
|/ | | | | Both String and Date now respond to in_time_zone so we need to check if the value is a Time or a DateTime.
* Revert "Omit directories from gemspec.files for RubyGems 2 compat."Jeremy Kemper2012-12-091-1/+1
| | | | | | Obviated by rubygems/rubygems@486ed83cc8e706069213c5d406122f4cfcca9e7f This reverts commit bb8923dee093b615615cdfb83b34d1b0bb254f25.
* Omit directories from gemspec.files for RubyGems 2 compat.Jeremy Kemper2012-12-081-1/+1
| | | | | | RG2 packager expects each spec.files path to be a file and bombs when it tries to tarball a dir. May revert if rubygems/rubygems#413 is accepted.
* Replace comments' non-breaking spaces with spacesclaudiob2012-12-043-6/+6
| | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code.
* Actually test that ActiveModel::Errors#add defaults to :invalid.Renato Mascarenhas2012-12-011-1/+1
|
* Call `full_messages` instead of `to_a` in its spec.Renato Mascarenhas2012-12-011-2/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 05:51:33 +0000