aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
...
* | | remove some evals from callback conditionalsAaron Patterson2013-06-112-2/+7
| | |
* | | fix ActiveModel::Validations.validators_on docDaichi Arai2013-06-101-1/+0
| | |
* | | Merge pull request #10860 from ka8725/activemodel_logCarlos Antonio da Silva2013-06-071-0/+4
|\ \ \ | | | | | | | | Ignore activemodel/log/ folder
| * | | Stub logger for testsAndrey Koleshko2013-06-061-0/+4
| | | |
* | | | Docfix: Use public interface instead of setting instance variablesRichard Livsey2013-06-071-1/+1
|/ / / | | | | | | Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
* | | No need to load 'rake/packagetask' as it's alreadyArun Agrawal2013-06-021-1/+0
| | | | | | | | | | | | | | | in 'rubygems/package_task'
* | | Fix regression in has_secure_password.Phil Calvin2013-05-303-4/+17
|/ / | | | | | | If the confirmation was blank, but the password wasn't, it would still save.
* | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵Nick Sutterer2013-05-237-36/+60
| | | | | | | | their setup in their constructor now.
* | Merge pull request #10527 from zenspider/squishy_minitest5Aaron Patterson2013-05-161-1/+0
|\ \ | | | | | | Squishy minitest5
| * | Updates to make rails 4 happy with minitest 5:Ryan Davis2013-05-061-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + Namespace changes, overhaul of runners. + Internal ivar name changes - Removed a logger globally applied to tests that spew everywhere?!? + Override Minitest#__run to sort tests by name. + Reworked testing isolation to work with the new cleaner architecture. - Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago. - Minor report output differences.
* | | deprecating string based terminatorsAaron Patterson2013-05-142-2/+5
| | |
* | | Merge branch 'master' into normalizecbAaron Patterson2013-05-131-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (61 commits) add tests for reset_calbacks Fixing build broken by this change Extract variable out of loop Updated comment to Rails 4 Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext better error message when app name is not passed in `rails new` Code cleanup for ActionDispatch::Flash#call Fix typo: require -> requires Add CHANGELOG entry for #10576 Merge pull request #10556 from Empact/deprecate-schema-statements-distinct Some editorial changes on the documentation. respond_to -> respond to in a message from AM::Lint specify that dom_(id|class) are deprecated in controllers, views are fine copy edits [ci skip] Fix class and method name typos Replace multi_json with json ruby -> Ruby Adding documentation to the automatic inverse_of finder. Improve CHANGELOG entry [ci kip] Call assume_migrated_upto_version on connection ... Conflicts: activesupport/lib/active_support/callbacks.rb
| * | | respond_to -> respond to in a message from AM::LintXavier Noria2013-05-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The error message uses English to say that the object should respond to a certain method. You check that with respond_to, but that's not English. This makes this error message also consistent with the rest.
* | | | callbacks are wrapped with lambdasAaron Patterson2013-05-101-1/+1
|/ / /
* / / Using define method instead of class eval when defining model callbacks.wangjohn2013-05-081-18/+12
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Based on my benchmark results, this change improves performance substantially when defining callbacks. This benchmark (https://gist.github.com/wangjohn/5542610) was run using the current master and also using my experimental branch which replaced class_eval with define_single_method. Using class_eval (current master): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.001568) 50 trials 0.020000 0.000000 0.020000 ( 0.021715) 500 trials 0.110000 0.000000 0.110000 ( 0.115357) 1000 trials 0.250000 0.000000 0.250000 ( 0.260025) 10000 trials 2.560000 0.000000 2.560000 ( 2.568408) 50000 trials 12.800000 0.010000 12.810000 ( 12.886871) Using define_single_method (experimental branch): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.000790) 50 trials 0.000000 0.000000 0.000000 ( 0.002960) 500 trials 0.050000 0.010000 0.060000 ( 0.055690) 1000 trials 0.100000 0.000000 0.100000 ( 0.094073) 10000 trials 0.890000 0.000000 0.890000 ( 0.900364) 50000 trials 4.650000 0.000000 4.650000 ( 4.686127)
* | Convert ActiveModel to 1.9 hash syntax.Patrick Robertson2013-05-0143-349/+351
| | | | | | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
* | rails/master is now 4.1.0.betaRafael Mendonça França2013-04-292-213/+3
| |
* | Bump version to rc1David Heinemeier Hansson2013-04-291-1/+1
| |
* | pass over the code commentsXavier Noria2013-04-281-28/+32
| | | | | | | | | | | | * Highlights the requirement of an attributes method. * Removes some details that depend on the implementation of the class including the module. * Applies guidelines here and there.
* | Merge pull request #10286 from ↵Carlos Antonio da Silva2013-04-211-2/+2
|\ \ | | | | | | | | | | | | neerajdotname/fix-wrong-test-name-and-failure-message fix wrong test description and failure message
| * | fix wrong test description and failure messageNeeraj Singh2013-04-211-2/+2
| | |
* | | Added tests for if condition in Active Model callbacksNeeraj Singh2013-04-211-0/+21
|/ /
* | align the result of expressions vertically [ci skip].Yves Senn2013-04-121-7/+7
| |
* | use unified and clean formatting in CHANGELOGS. [ci skip]Yves Senn2013-04-121-9/+12
| |
* | Removed unused setupAnupam Choudhury2013-04-091-4/+0
| |
* | Prefer find_by over dynamic finders in rdocSam Ruby2013-04-022-8/+8
| |
* | Review some tests from AMo::Errors to remove "should" usageCarlos Antonio da Silva2013-03-301-55/+35
| | | | | | | | | | Also remove duplicated tests for Errors#as_json and minor improvements in some tests.
* | Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip]Carlos Antonio da Silva2013-03-302-4/+13
| | | | | | | | Add a working example of how to use this new method.
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-301-1/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip]
| * | Reverted change in activemodel/CHANGELOG.md introduced by ↵Prathamesh Sonpatki2013-03-241-2/+2
| | | | | | | | | | | | d45145acdc576e46a1f1719d69bec96b5bf07b0a
| * | Changed 'args' to 'arguments' when used in places other than code with ↵Prathamesh Sonpatki2013-03-241-2/+2
| | | | | | | | | | | | fixing few more typos
| * | clarify verbiageWaynn Lue2013-03-121-1/+1
| | |
* | | Merge pull request #8527 from shockone/patch-1Rafael Mendonça França2013-03-253-0/+39
|\ \ \ | | | | | | | | Add a method full_messages_for to the Errors class
| * | | Add a method full_messages_for to the Errors classshock_one2013-03-243-0/+39
| | | |
* | | | Merge pull request #9864 from vipulnsward/fix_test_AR_v2Rafael Mendonça França2013-03-251-0/+1
|\ \ \ \ | |/ / / |/| | | Introduce test on Error#full_message for attribute with underscores; Fix...
| * | | Add Error#full_message test; Fix typosVipul A M2013-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos
* | | | Merge pull request #8501 from charliesome/version-to-sRafael Mendonça França2013-03-231-6/+7
|\ \ \ \ | | | | | | | | | | Add #to_s method to VERSION modules
| * | | | Add version method to top level modulesCharlie Somerville2013-03-211-6/+7
| | | | |
* | | | | Fixed typo in activemodel/CHANGELOGPrathamesh Sonpatki2013-03-241-1/+1
| | | | |
* | | | | Remove exception variable from rescue blockCarlos Antonio da Silva2013-03-221-2/+2
| |/ / / |/| | | | | | | | | | | | | | | Just raising from the rescue block will re-raise the exception, so the variable is not necessary.
* | | | Change Standard error when is required bcrypt-ruby and failsrobertomiranda2013-03-211-2/+7
| | | |
* | | | Tidying up some require : removing useless sort and homogenizing with the ↵Intrepidd2013-03-201-4/+1
|/ / / | | | | | | | | | rest of the code the wat the includes are done
* | | The repair_validations helper was not working correctly before becausewangjohn2013-03-192-0/+64
| | | | | | | | | | | | | | | | | | it only cleared the validations that created :validate callbacks. This didn't include the validates created by validates_with, so I've added a method to clear all validations.
* | | Revert "instruct RDoc to only parse Ruby files under lib [Fixes #9779]"Xavier Noria2013-03-181-1/+1
| | | | | | | | | | | | This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57.
* | | instruct RDoc to only parse Ruby files under lib [Fixes #9779]Xavier Noria2013-03-181-1/+1
| | |
* | | fix some typos found in activemodelVipul A M2013-03-183-4/+4
| | |
* | | Small typos here and there.Vipul A M2013-03-154-5/+5
|/ /
* | Fix AMo code example indent, add missing author to entry [ci skip]Carlos Antonio da Silva2013-03-091-6/+8
| |
* | Merge pull request #9545 from senny/9535_secure_password_blankRafael Mendonça França2013-03-075-3/+75
|\ \ | | | | | | `has_secure_password` is not invalid when assigning empty Strings
| * | `has_secure_password` is not invalid when assigning empty Strings.Yves Senn2013-03-043-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 18:49:07 +0000