Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Missing BigDecimal dependency | Jeremy Kemper | 2010-06-27 | 1 | -0/+2 |
| | |||||
* | Move constantize from conversions to inflections. | Santiago Pastorino | 2010-06-26 | 1 | -1/+0 |
| | | | | | | | | This removes ActiveModel dependency on TZInfo. [#4979 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Work around the fact the JSON gem was overwriting to_json implementation for ↵ | José Valim | 2010-06-26 | 3 | -17/+23 |
| | | | | | | | all Ruby core classes. This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized. So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved] | ||||
* | Regression with how base errors messages are added to a model. Works ↵ | Josh Kalderimis | 2010-06-23 | 3 | -5/+20 |
| | | | | | | correctly for both string error messages and symbol translated messages. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | should be able to run ActiveModel validations_test [#4933 state:resolved] | Neeraj Singh | 2010-06-22 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Avoid method redefined warning | Santiago Pastorino | 2010-06-22 | 1 | -1/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor previous commit a bit [#4057 state:resolved] | José Valim | 2010-06-21 | 7 | -16/+16 |
| | |||||
* | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-06-21 | 11 | -411/+279 |
| | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 4 | -2/+146 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb | ||||
| * | remove executable permission from files that don't need it. [#4802 ↵ | rohit | 2010-06-20 | 1 | -0/+0 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | ActiveModel::Validations::Callbacks should not be required by default. | José Valim | 2010-06-19 | 3 | -13/+24 |
| | | |||||
| * | moving before_validation and after_validation functionality from ↵ | Neeraj Singh | 2010-06-19 | 3 | -12/+142 |
| | | | | | | | | | | | | | | | | ActiveRecord to ActiveModel [#4653 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
| * | use RDoc 2.2 to generate the documentation of individual components | Xavier Noria | 2010-06-16 | 1 | -0/+3 |
| | | |||||
* | | Changes call backs to callbacks. | Rizwan Reza | 2010-06-15 | 2 | -9/+9 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Rizwan Reza | 2010-06-15 | 1 | -2/+2 |
|\ \ | |||||
| * | | Active Model lint - fix minor typos | Bryan Woods | 2010-06-15 | 1 | -2/+2 |
| | | | |||||
* | | | Add titles to the rest of the files in active_model/validations/* | Rizwan Reza | 2010-06-15 | 8 | -0/+16 |
| | | | |||||
* | | | Minor doc changes to active_model/validations/confirmation.rb | Rizwan Reza | 2010-06-15 | 1 | -13/+27 |
| | | | |||||
* | | | Minor doc changes to active_model/validations/acceptance.rb | Rizwan Reza | 2010-06-15 | 1 | -15/+30 |
|/ / | |||||
* | | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-15 | 7 | -9/+10 |
|\ \ | |/ |/| | |||||
| * | Fix minor mistake in activemodel/README | Evgeniy Dolzhenko | 2010-06-11 | 1 | -1/+2 |
| | | |||||
| * | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 6 | -8/+8 |
| | | |||||
* | | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 3 | -3/+3 |
| | | | | | | | | not "ActiveRecord" | ||||
* | | Added headings to serializers. | Rizwan Reza | 2010-06-14 | 3 | -3/+7 |
| | | |||||
* | | Revised the rest of the files from ActiveModel. | Rizwan Reza | 2010-06-14 | 3 | -23/+36 |
| | | |||||
* | | Revised and added headings. | Rizwan Reza | 2010-06-14 | 3 | -1/+7 |
| | | |||||
* | | Revised naming.rb and lint.rb | Rizwan Reza | 2010-06-14 | 2 | -5/+5 |
| | | |||||
* | | Added headings and revised active_model.rb/lint.rb grammatically | Rizwan Reza | 2010-06-14 | 1 | -1/+3 |
| | | |||||
* | | Minor changes to active_model/errors.rb | Rizwan Reza | 2010-06-14 | 1 | -8/+16 |
| | | |||||
* | | Minor changes to active_model/callbacks.rb and dirty.rb | Rizwan Reza | 2010-06-14 | 2 | -7/+12 |
| | | |||||
* | | Minor changes to active_model/attribute_methods | Rizwan Reza | 2010-06-14 | 1 | -24/+30 |
| | | |||||
* | | Minor changes to callbacks and conversion API docs. | Rizwan Reza | 2010-06-14 | 2 | -13/+17 |
|/ | |||||
* | Fix spelling error in ActiveModel::Conversion docs. [#4826 state:resolved] | Pavel Gorbokon | 2010-06-11 | 1 | -1/+1 |
| | |||||
* | class_attribute is not a direct replacement of class_inheritable_*. | José Valim | 2010-06-10 | 1 | -5/+11 |
| | | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance. | ||||
* | Validators should at model level and not at AR:Base level [Closes #4804] | Neeraj Singh | 2010-06-10 | 1 | -1/+1 |
| | | | | | | [#4804 state:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Get ready for beta 4 | David Heinemeier Hansson | 2010-06-08 | 2 | -2/+2 |
| | |||||
* | Really make include_root_in_json default to true [#3770 state:resolved] | José Valim | 2010-06-08 | 2 | -18/+27 |
| | |||||
* | Observing module is using constantize | Santiago Pastorino | 2010-06-06 | 1 | -0/+1 |
| | |||||
* | Bump i18n to 0.4.1 | Jeremy Kemper | 2010-06-05 | 1 | -1/+1 |
| | |||||
* | revises rdoc of AMo::Error#add [#4738 state:resolved] | Xavier Noria | 2010-06-01 | 1 | -6/+6 |
| | |||||
* | Unforce builder from AS | Santiago Pastorino | 2010-06-01 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Unforce i18n from AS | Santiago Pastorino | 2010-05-31 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix xml serialization test [#4650 state:resolved] | Anil Wadghule | 2010-05-19 | 1 | -2/+5 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 4 | -5/+5 |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fixed numericality validator in ActiveModel to reject hex numbers for floats ↵ | rohit | 2010-05-18 | 1 | -1/+1 |
| | | | | | | completely [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add a valid hex that shouldn't be valid to ActiveModel numericality tests ↵ | rohit | 2010-05-18 | 1 | -1/+1 |
| | | | | | | [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Valid hex strings aren't valid float column values, to match the integer ↵ | Jeremy Kemper | 2010-05-17 | 2 | -4/+9 |
| | | | | restriction. [#4622 state:resolved] | ||||
* | a cloned object no longer mimics changed flags from creator , plus a test ↵ | Federico Brubacher | 2010-05-16 | 1 | -4/+5 |
| | | | | | | case [#4614 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make use of assert_equal to test equallity between object assert expects and ↵ | Santiago Pastorino | 2010-05-16 | 2 | -3/+3 |
| | | | | | | | | object and a message of error [#4611 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵ | José Valim | 2010-05-15 | 11 | -127/+99 |
| | | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff. |