aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
...
* | Revert "Merge pull request #27528 from kamipo/extract_casted_booleans"Kasper Timm Hansen2017-01-011-12/+4
| | | | | | | | | | | | | | | | | | | | | | As pointed out by @matthewd this change makes ImmutableString aware of MysqlString's existence whereas previously MysqlString was only overriding public API. cc @kamipo This reverts commit e632c2fa4cb60072a778ce95c952a0fa95e5b074, reversing changes made to 334a7dcf107cd3ff1697163d331d289d6d65dcd7.
* | Extract `casted_true`/`casted_false` for `Type::ImmutableString`Ryuta Kamizono2017-01-011-4/+12
| | | | | | | | | | | | The only difference between `Type::ImmutableString` and its subclasses is the representation of the casted booleans. Prefer extracting `casted_true`/`casted_false` and override these by subclasses.
* | [ci skip] Update Active Model copyright years.Kasper Timm Hansen2016-12-312-2/+2
| | | | | | | | | | | | Missed in 37d956f. Fixes #27524. [ MSathieu & Kasper Timm Hansen ]
* | "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-255-13/+13
| |
* | Privatize unneededly protected methods in Active ModelAkira Matsuda2016-12-246-27/+23
| |
* | No need to :nodoc: private methodsAkira Matsuda2016-12-242-6/+6
| |
* | Describe what we are protectingAkira Matsuda2016-12-234-0/+10
| |
* | Change ActiveModel::Type::Helpers to :nodoc: [ci skip]MSP-Greg2016-12-164-8/+8
| |
* | Missing require "yaml"Akira Matsuda2016-12-121-0/+1
|/
* Make ActiveModel::Errors backward compatible with 4.2Rafael Mendonça França2016-12-082-2/+29
| | | | | | | If a Error object was serialized in the database as YAML in the Rails 4.2 version, if we load in the Rails 5.0 version it will miss the @details instance variable so methods like #clear and #add will start to fail.
* Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodelSean Griffin2016-12-086-59/+4
|\ | | | | | | Moved database-specific ActiveModel types into ActiveRecord
| * Moved database-specific ActiveModel types into ActiveRecordIain Beeston2016-10-146-59/+4
| | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger
* | Merge pull request #27185 from kamipo/fix_apply_seconds_precisionSean Griffin2016-12-081-1/+1
|\ \ | | | | | | Fix `apply_seconds_precision` not to be affected by `mathn`
| * | Fix `apply_seconds_precision` not to be affected by `mathn`Ryuta Kamizono2016-11-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `apply_seconds_precision` cannnot round usec when after `require 'mathn'`. ``` irb(main):001:0> 1234 / 1000 * 1000 => 1000 irb(main):002:0> 1234 - 1234 % 1000 => 1000 irb(main):003:0> require 'mathn' => true irb(main):004:0> 1234 / 1000 * 1000 => 1234 irb(main):005:0> 1234 - 1234 % 1000 => 1000 ```
* | | Add Action View to Active Model API documentationGabi Stefanini2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | In Rails 4.1, Action View was extracted from Action Pack, but this change was not reflected in the API documentation of ActiveModel::Model. This commits makes it explicit in the documentation that Active Model also interacts with Action View as well as Action Pack. [ci skip]
* | | Fixes API wording to match API conventionsGabi Stefanini2016-12-061-2/+2
|/ / | | | | | | | | | | | | | | | | In ActiveModel::Model API documentation, referrences to Rails components were tagged with fixed-width font and named as if they were modules.This fixes the inconsistency to match API documentation conventions. [ci skip]
* | Allow indifferent access in ActiveModel::ErrorsKenichi Kamiya2016-11-223-5/+19
| | | | | | | | | | | | `#[]` has already applied indifferent access, but some methods does not. `#include?`, `#has_key?`, `#key?`, `#delete` and `#full_messages_for`.
* | update bin/test scripts to prevent double runs.Yves Senn2016-11-211-2/+0
| | | | | | | | | | The test runner was updated to make use of autorun. This caused the `bin/test` scripts to run Minitest twice.
* | Do not rely on Ruby implementation in AM testKir Shatrov2016-11-191-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Now a few tests in ActiveModel rely on Ruby implementation and the fact that in MRI `97.18` as a float is greater than `97.18` as a BigDecimal. This is only relevant for MRI. On JRuby, comparing float to BigDecimal would be conversion of them to the same type and they will be equal. I'd like the ActiveModel test suite to be Ruby implementation-agnostic. Here we test ActiveModel, not the Ruby internals. This PR fixes a couple more JRuby tests.
* | Merge pull request #26905 from bogdanvlviv/docsAndrew White2016-11-133-4/+4
|\ \ | | | | | | Add missing `+` around a some literals.
| * | Add missing `+` around a some literals.bogdanvlviv2016-10-273-4/+4
| | | | | | | | | | | | | | | | | | Mainly around `nil` [ci skip]
* | | Merge pull request #26935 from y-yagi/fix_ruby_warningAndrew White2016-10-311-1/+1
|\ \ \ | | | | | | | | remove warning from big integer test
| * | | remove warning from big integer testyuuji.yaginuma2016-10-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warnings. ``` activemodel/test/cases/type/big_integer_test.rb:15: warning: ambiguous first argument; put parentheses or a space even after `-' operator ```
* | | | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-2918-65/+65
|/ / /
* | | removes requires already present in active_support/railsXavier Noria2016-10-271-1/+0
| | |
* | | let Regexp#match? be globally availableXavier Noria2016-10-273-3/+0
|/ / | | | | | | | | | | Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation.
* | Missing require extract_optionsAkira Matsuda2016-10-251-0/+2
| |
* | Merge pull request #26790 from iainbeeston/type-tests-in-their-own-filesRafael França2016-10-2213-168/+266
|\ \ | | | | | | Refactored ActiveModel::Type tests into their own files
| * | Refactored ActiveModel::Type tests into their own filesIain Beeston2016-10-1513-168/+266
| |/
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-10-201-1/+1
|\ \ | |/ |/|
| * Corrected comments referring to ActiveModel::AttributesIain Beeston2016-10-031-1/+1
| | | | | | | | Should be ActiveRecord::Attributes (ActiveModel::Attributes does not exist)
* | Removed deprecated :tokenizer in the length validatorRafael Mendonça França2016-10-104-74/+5
| |
* | Removed deprecated methods in ActiveModel::ErrorsRafael Mendonça França2016-10-103-179/+6
| | | | | | | | `#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
* | Merge pull request #24571 from raimo/patch-1Sean Griffin2016-10-041-0/+9
|\ \ | |/ |/| Print the proper ::Float::INFINITY value when used as a default value
| * Print the proper ::Float::INFINITY value when used as a default valueRaimo Tuisku2016-05-231-0/+9
| | | | | | | | Addresses https://github.com/rails/rails/issues/22396
* | Do not leak the Errors default proc when calling to_hash or as_jsonJean Boussier2016-09-272-1/+11
| |
* | [ci skip] Fix bad examples in rdocAndrey Molchanov2016-09-171-2/+11
| |
* | Merge pull request #26516 from grosser/grosser/assertRafael França2016-09-165-25/+25
|\ \ | | | | | | improve error message when include assertions fail
| * | improve error message when include assertions failMichael Grosser2016-09-165-25/+25
| | | | | | | | | | | | | | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
* | | Update ActiveModel::Dirty Doc [ci skip]Louis-Michel Couture2016-09-161-8/+8
|/ /
* | Update ActiveModel::Dirty Doc [ci skip]Louis-Michel Couture2016-09-151-1/+1
| | | | | | Fix potentially misleading example.
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip]Ryuta Kamizono2016-09-144-7/+7
| | | | | | | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
* | Fix Remaining Case-In-Assignment Statement FormattingAlex Kitchens2016-09-061-12/+13
| | | | | | | | | | | | | | | | | | Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
* | apply case-in-assignment patternXavier Noria2016-09-022-11/+13
| |
* | RuboCop is 100% green :tada:Xavier Noria2016-09-022-2/+2
| |
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-011-1/+1
| |
* | validate_each in NumericalityValidator is never called in this case.Guillermo Iguaran2016-08-281-2/+0
| | | | | | | | | | NumericalityValidator#validate_each is never called when allow_nil is true and the value is nil because it is already skipped in EachValidator#validate.
* | Add test for allow_blank in numericality validationNicolai Reuschling2016-08-281-0/+7
| | | | | | | | Signed-off-by: Guillermo Iguaran <guilleiguaran@gmail.com>
* | Fix typo in deprecation messageGeorg Ledermann2016-08-271-1/+1
| | | | | | This fixes a copy-and-paste-issue slipped in by #18996
* | Add three new rubocop rulesRafael Mendonça França2016-08-1611-60/+60
| | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 10:42:31 +0000