Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | respond_to -> respond to in a message from AM::Lint | Xavier Noria | 2013-05-12 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The error message uses English to say that the object should respond to a certain method. You check that with respond_to, but that's not English. This makes this error message also consistent with the rest. | |||||
* | | | | | callbacks are wrapped with lambdas | Aaron Patterson | 2013-05-10 | 1 | -1/+1 | |
|/ / / / | ||||||
* / / / | Using define method instead of class eval when defining model callbacks. | wangjohn | 2013-05-08 | 1 | -18/+12 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Based on my benchmark results, this change improves performance substantially when defining callbacks. This benchmark (https://gist.github.com/wangjohn/5542610) was run using the current master and also using my experimental branch which replaced class_eval with define_single_method. Using class_eval (current master): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.001568) 50 trials 0.020000 0.000000 0.020000 ( 0.021715) 500 trials 0.110000 0.000000 0.110000 ( 0.115357) 1000 trials 0.250000 0.000000 0.250000 ( 0.260025) 10000 trials 2.560000 0.000000 2.560000 ( 2.568408) 50000 trials 12.800000 0.010000 12.810000 ( 12.886871) Using define_single_method (experimental branch): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.000790) 50 trials 0.000000 0.000000 0.000000 ( 0.002960) 500 trials 0.050000 0.010000 0.060000 ( 0.055690) 1000 trials 0.100000 0.000000 0.100000 ( 0.094073) 10000 trials 0.890000 0.000000 0.890000 ( 0.900364) 50000 trials 4.650000 0.000000 4.650000 ( 4.686127) | |||||
* | | | Convert ActiveModel to 1.9 hash syntax. | Patrick Robertson | 2013-05-01 | 43 | -349/+351 | |
| | | | | | | | | | | | | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ). | |||||
* | | | rails/master is now 4.1.0.beta | Rafael Mendonça França | 2013-04-29 | 2 | -213/+3 | |
| | | | ||||||
* | | | Bump version to rc1 | David Heinemeier Hansson | 2013-04-29 | 1 | -1/+1 | |
| | | | ||||||
* | | | pass over the code comments | Xavier Noria | 2013-04-28 | 1 | -28/+32 | |
| | | | | | | | | | | | | | | | | | | * Highlights the requirement of an attributes method. * Removes some details that depend on the implementation of the class including the module. * Applies guidelines here and there. | |||||
* | | | Merge pull request #10286 from ↵ | Carlos Antonio da Silva | 2013-04-21 | 1 | -2/+2 | |
|\ \ \ | | | | | | | | | | | | | | | | | neerajdotname/fix-wrong-test-name-and-failure-message fix wrong test description and failure message | |||||
| * | | | fix wrong test description and failure message | Neeraj Singh | 2013-04-21 | 1 | -2/+2 | |
| | | | | ||||||
* | | | | Added tests for if condition in Active Model callbacks | Neeraj Singh | 2013-04-21 | 1 | -0/+21 | |
|/ / / | ||||||
* | | | align the result of expressions vertically [ci skip]. | Yves Senn | 2013-04-12 | 1 | -7/+7 | |
| | | | ||||||
* | | | use unified and clean formatting in CHANGELOGS. [ci skip] | Yves Senn | 2013-04-12 | 1 | -9/+12 | |
| | | | ||||||
* | | | Removed unused setup | Anupam Choudhury | 2013-04-09 | 1 | -4/+0 | |
| | | | ||||||
* | | | Prefer find_by over dynamic finders in rdoc | Sam Ruby | 2013-04-02 | 2 | -8/+8 | |
| | | | ||||||
* | | | Review some tests from AMo::Errors to remove "should" usage | Carlos Antonio da Silva | 2013-03-30 | 1 | -55/+35 | |
| | | | | | | | | | | | | | | | Also remove duplicated tests for Errors#as_json and minor improvements in some tests. | |||||
* | | | Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip] | Carlos Antonio da Silva | 2013-03-30 | 2 | -4/+13 | |
| | | | | | | | | | | | | Add a working example of how to use this new method. | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-30 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip] | |||||
| * | | | Reverted change in activemodel/CHANGELOG.md introduced by ↵ | Prathamesh Sonpatki | 2013-03-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | d45145acdc576e46a1f1719d69bec96b5bf07b0a | |||||
| * | | | Changed 'args' to 'arguments' when used in places other than code with ↵ | Prathamesh Sonpatki | 2013-03-24 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | fixing few more typos | |||||
| * | | | clarify verbiage | Waynn Lue | 2013-03-12 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #8527 from shockone/patch-1 | Rafael Mendonça França | 2013-03-25 | 3 | -0/+39 | |
|\ \ \ \ | | | | | | | | | | | Add a method full_messages_for to the Errors class | |||||
| * | | | | Add a method full_messages_for to the Errors class | shock_one | 2013-03-24 | 3 | -0/+39 | |
| | | | | | ||||||
* | | | | | Merge pull request #9864 from vipulnsward/fix_test_AR_v2 | Rafael Mendonça França | 2013-03-25 | 1 | -0/+1 | |
|\ \ \ \ \ | |/ / / / |/| | | | | Introduce test on Error#full_message for attribute with underscores; Fix... | |||||
| * | | | | Add Error#full_message test; Fix typos | Vipul A M | 2013-03-22 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos | |||||
* | | | | | Merge pull request #8501 from charliesome/version-to-s | Rafael Mendonça França | 2013-03-23 | 1 | -6/+7 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add #to_s method to VERSION modules | |||||
| * | | | | | Add version method to top level modules | Charlie Somerville | 2013-03-21 | 1 | -6/+7 | |
| | | | | | | ||||||
* | | | | | | Fixed typo in activemodel/CHANGELOG | Prathamesh Sonpatki | 2013-03-24 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Remove exception variable from rescue block | Carlos Antonio da Silva | 2013-03-22 | 1 | -2/+2 | |
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | Just raising from the rescue block will re-raise the exception, so the variable is not necessary. | |||||
* | | | | | Change Standard error when is required bcrypt-ruby and fails | robertomiranda | 2013-03-21 | 1 | -2/+7 | |
| | | | | | ||||||
* | | | | | Tidying up some require : removing useless sort and homogenizing with the ↵ | Intrepidd | 2013-03-20 | 1 | -4/+1 | |
|/ / / / | | | | | | | | | | | | | rest of the code the wat the includes are done | |||||
* | | | | The repair_validations helper was not working correctly before because | wangjohn | 2013-03-19 | 2 | -0/+64 | |
| | | | | | | | | | | | | | | | | | | | | | | | | it only cleared the validations that created :validate callbacks. This didn't include the validates created by validates_with, so I've added a method to clear all validations. | |||||
* | | | | Revert "instruct RDoc to only parse Ruby files under lib [Fixes #9779]" | Xavier Noria | 2013-03-18 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57. | |||||
* | | | | instruct RDoc to only parse Ruby files under lib [Fixes #9779] | Xavier Noria | 2013-03-18 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | fix some typos found in activemodel | Vipul A M | 2013-03-18 | 3 | -4/+4 | |
| | | | | ||||||
* | | | | Small typos here and there. | Vipul A M | 2013-03-15 | 4 | -5/+5 | |
|/ / / | ||||||
* | | | Fix AMo code example indent, add missing author to entry [ci skip] | Carlos Antonio da Silva | 2013-03-09 | 1 | -6/+8 | |
| | | | ||||||
* | | | Merge pull request #9545 from senny/9535_secure_password_blank | Rafael Mendonça França | 2013-03-07 | 5 | -3/+75 | |
|\ \ \ | | | | | | | | | `has_secure_password` is not invalid when assigning empty Strings | |||||
| * | | | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 3 | -2/+24 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | |||||
| * | | | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 3 | -1/+51 | |
| | | | | ||||||
* | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-03-05 | 1 | -1/+1 | |
|\ \ \ \ | |/ / / |/| | | | ||||||
| * | | | Small Typo | Lebin Sebastian F | 2013-03-04 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Update CHANGELOGS | Rafael Mendonça França | 2013-02-26 | 1 | -0/+3 | |
|/ / / | ||||||
* | | | Preparing for 4.0.0.beta1 release | David Heinemeier Hansson | 2013-02-25 | 2 | -2/+2 | |
| | | | ||||||
* | | | did a pass over the AM changelog [ci skip] | Xavier Noria | 2013-02-24 | 1 | -15/+35 | |
| | | | ||||||
* | | | added more accurate test for add_on_empty | Angelo capilleri | 2013-02-19 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails | |||||
* | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-02-15 | 1 | -0/+3 | |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md | |||||
| * | | | Clarify ActiveModel::Validator initialization in docs. | Henrik Nyh | 2013-02-09 | 1 | -0/+3 | |
| | | | | | | | | | | | | As discussed with @josevalim on Ruby Rogues Parley. | |||||
* | | | | Take care of whitespaces and changing the hash syntax | Rafael Mendonça França | 2013-02-04 | 1 | -57/+56 | |
| | | | | ||||||
* | | | | test for issue 8931 | David | 2013-02-02 | 1 | -0/+8 | |
|/ / / | ||||||
* | | | Missing require extract_options | Akira Matsuda | 2013-01-31 | 1 | -0/+2 | |
| | | |