| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| | | | |
| | | | | |
Ignore activemodel/log/ folder
|
| | | | | |
|
|/ / / /
| | | |
| | | | |
Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
in 'rubygems/package_task'
|
|/ / /
| | |
| | |
| | | |
If the confirmation was blank, but the password wasn't, it would still save.
|
| | |
| | |
| | |
| | | |
their setup in their constructor now.
|
|\ \ \
| | | |
| | | | |
Squishy minitest5
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
+ Namespace changes, overhaul of runners.
+ Internal ivar name changes
- Removed a logger globally applied to tests that spew everywhere?!?
+ Override Minitest#__run to sort tests by name.
+ Reworked testing isolation to work with the new cleaner architecture.
- Removed a bunch of tests that just test minitest straight up. I think these changes were all merged to minitest 4 a long time ago.
- Minor report output differences.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* master: (61 commits)
add tests for reset_calbacks
Fixing build broken by this change
Extract variable out of loop
Updated comment to Rails 4
Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext
better error message when app name is not passed in `rails new`
Code cleanup for ActionDispatch::Flash#call
Fix typo: require -> requires
Add CHANGELOG entry for #10576
Merge pull request #10556 from Empact/deprecate-schema-statements-distinct
Some editorial changes on the documentation.
respond_to -> respond to in a message from AM::Lint
specify that dom_(id|class) are deprecated in controllers, views are fine
copy edits [ci skip]
Fix class and method name typos
Replace multi_json with json
ruby -> Ruby
Adding documentation to the automatic inverse_of finder.
Improve CHANGELOG entry [ci kip]
Call assume_migrated_upto_version on connection
...
Conflicts:
activesupport/lib/active_support/callbacks.rb
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The error message uses English to say that the object should respond
to a certain method. You check that with respond_to, but that's not
English.
This makes this error message also consistent with the rest.
|
|/ / / / |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Based on my benchmark results, this change improves performance
substantially when defining callbacks.
This benchmark (https://gist.github.com/wangjohn/5542610) was run using
the current master and also using my experimental branch which replaced
class_eval with define_single_method.
Using class_eval (current master):
user system total real
10 trials 0.000000 0.000000 0.000000 ( 0.001568)
50 trials 0.020000 0.000000 0.020000 ( 0.021715)
500 trials 0.110000 0.000000 0.110000 ( 0.115357)
1000 trials 0.250000 0.000000 0.250000 ( 0.260025)
10000 trials 2.560000 0.000000 2.560000 ( 2.568408)
50000 trials 12.800000 0.010000 12.810000 ( 12.886871)
Using define_single_method (experimental branch):
user system total real
10 trials 0.000000 0.000000 0.000000 ( 0.000790)
50 trials 0.000000 0.000000 0.000000 ( 0.002960)
500 trials 0.050000 0.010000 0.060000 ( 0.055690)
1000 trials 0.100000 0.000000 0.100000 ( 0.094073)
10000 trials 0.890000 0.000000 0.890000 ( 0.900364)
50000 trials 4.650000 0.000000 4.650000 ( 4.686127)
|
| | |
| | |
| | |
| | |
| | | |
I also attempted to fix other styleguide violations such as
{ a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
* Highlights the requirement of an attributes method.
* Removes some details that depend on the implementation of the class including the module.
* Applies guidelines here and there.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
neerajdotname/fix-wrong-test-name-and-failure-message
fix wrong test description and failure message
|
| | | | |
|
|/ / / |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Also remove duplicated tests for Errors#as_json and minor improvements
in some tests.
|
| | |
| | |
| | |
| | | |
Add a working example of how to use this new method.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
activerecord/test/cases/adapter_test.rb
guides/source/testing.md
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
d45145acdc576e46a1f1719d69bec96b5bf07b0a
|
| | | |
| | | |
| | | |
| | | | |
fixing few more typos
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add a method full_messages_for to the Errors class
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Introduce test on Error#full_message for attribute with underscores; Fix...
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Introduce test on Error#full_message for attribute with underscores; Fix
some typos
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add #to_s method to VERSION modules
|
| | | | | | |
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | | |
Just raising from the rescue block will re-raise the exception, so the
variable is not necessary.
|
| | | | | |
|
|/ / / /
| | | |
| | | |
| | | | |
rest of the code the wat the includes are done
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
it only cleared the validations that created :validate callbacks. This
didn't include the validates created by validates_with, so I've added a
method to clear all validations.
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57.
|
| | | | |
|
| | | | |
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
`has_secure_password` is not invalid when assigning empty Strings
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #9535.
With 692b3b6 the `password=` setter does no longer set blank passwords.
This triggered validation errors when assigning empty Strings to `password`
and `password_confirmation`.
This patch only sets the confirmation if it is not `blank?`.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
|