Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | no callbacks should be created for empty array [#5289 state:resolved] | Subba Rao Pasupuleti | 2010-08-14 | 2 | -3/+20 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | tidy up validations length code [#5297 state:resolved] | Subba Rao Pasupuleti | 2010-08-14 | 1 | -6/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add missing ActiveModel::Validations require | Greg Campbell | 2010-08-14 | 2 | -1/+1 |
| | | | | | | | | | | | [#5311 state: resolved] ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport. (This wasn't showing up in the tests, because it was required in the helper, and was also required in ActiveModel::Serialization). Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-12 | 2 | -10/+10 |
|\ | |||||
| * | applied guidelines to "# =>" | Paco Guzman | 2010-08-12 | 1 | -7/+7 |
| | | |||||
| * | ActiveModel::Base doesn't exist, include_root_in_json is a class_attribute ↵ | Santiago Pastorino | 2010-08-10 | 1 | -3/+3 |
| | | | | | | | | for the classes which includes this module | ||||
* | | fixes a typo reported by rymai | Xavier Noria | 2010-08-10 | 1 | -1/+1 |
|/ | |||||
* | typo in AM | Adam Meehan | 2010-08-09 | 1 | -1/+1 |
| | |||||
* | edit pass to AMo::Serializers::JSON | Xavier Noria | 2010-08-06 | 1 | -9/+9 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-05 | 2 | -2/+4 |
|\ | |||||
| * | adding documentation to ActiveSupport::Concern ht:strictly typed for an ↵ | Neeraj Singh | 2010-08-04 | 1 | -0/+2 |
| | | | | | | | | | | | | awesome example some minor documentation changes | ||||
| * | fixing documentation | Neeraj Singh | 2010-08-03 | 1 | -2/+2 |
| | | |||||
* | | Tidy up error.rb code | Subba Rao Pasupuleti | 2010-08-03 | 1 | -5/+1 |
| | | | | | | | | | | | | [#5288 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | | Freeze options so we raise an error when people modify it in place. | José Valim | 2010-08-03 | 2 | -3/+5 |
| | | |||||
* | | validates_length_of should not change the options hash in place. [#5283 ↵ | José Valim | 2010-08-03 | 1 | -4/+7 |
| | | | | | | | | state:resolved] | ||||
* | | Failing test for validates_length_of, when both too_short and too_long ↵ | rohit | 2010-08-03 | 1 | -0/+14 |
| | | | | | | | | | | | | messages are set [#5283 state:open] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵ | Tore Darell | 2010-08-03 | 2 | -12/+87 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | adding test cases for ActiveModel::Errors | Neeraj Singh | 2010-08-03 | 1 | -0/+65 |
|/ | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 ↵ | Alex Le | 2010-08-02 | 3 | -6/+22 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-07-30 | 8 | -32/+31 |
|\ | |||||
| * | edit pass to apply API guideline wrt the use of "# =>" in example code | Xavier Noria | 2010-07-30 | 6 | -30/+29 |
| | | |||||
| * | Prep for RC | David Heinemeier Hansson | 2010-07-26 | 2 | -2/+2 |
| | | |||||
* | | expanding on the will_change! method in documentation | Neeraj Singh | 2010-07-29 | 1 | -1/+4 |
|/ | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-07-26 | 1 | -73/+51 |
|\ | |||||
| * | improve Active Model README | Mislav Marohnić | 2010-07-22 | 1 | -73/+51 |
| | | | | | | | | | | | | | | - fix indentation problems - revised introductory text to state right away what the library is - improved examples: reduce heavy usage of ellipsis, don't mark paragraphs of text as code | ||||
* | | update Rakefiles for RDoc 2.5 | Aaron Patterson | 2010-07-23 | 1 | -4/+4 |
| | | |||||
* | | Makes Rakefile activate rdoc >= 2.5.9 | Santiago Pastorino | 2010-07-23 | 1 | -1/+1 |
|/ | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | replacing around with for in the comments for callbacks | Neeraj Singh | 2010-07-22 | 1 | -1/+1 |
| | |||||
* | Change some missing README -> README.rdoc | Santiago Pastorino | 2010-07-22 | 1 | -1/+1 |
| | |||||
* | Reuse already existing classes for ActiveModel tests. | José Valim | 2010-07-21 | 4 | -63/+44 |
| | |||||
* | Add .rdoc extension to README files. | José Valim | 2010-07-21 | 2 | -1/+1 |
| | |||||
* | Moved a few methods from RecordIdentifier to ActiveModel::Naming | Piotr Sarnacki | 2010-07-21 | 2 | -0/+92 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add missing entries and tidy up CHANGELOG. | José Valim | 2010-07-19 | 1 | -0/+5 |
| | |||||
* | adding proper markup to comment | Neeraj Singh | 2010-07-16 | 1 | -2/+2 |
| | |||||
* | Add missing require to use Set | Santiago Pastorino | 2010-07-11 | 1 | -1/+2 |
| | |||||
* | Avoid interpreted as grouped expression warnings | Santiago Pastorino | 2010-07-11 | 2 | -4/+4 |
| | |||||
* | Improve a bit the code in latest commits. | José Valim | 2010-07-08 | 1 | -1/+2 |
| | |||||
* | Removing method before redefining it. It was causing warnings. [#5072 ↵ | Łukasz Strzałkowski | 2010-07-08 | 1 | -0/+1 |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Change documentation for ActiveModel::MassAssignmentSecurity a bit and make ↵ | José Valim | 2010-07-08 | 3 | -47/+54 |
| | | | | debug always be called since some people may overwrite warn! to add extra behavior even if logger is not available. | ||||
* | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 10 | -0/+448 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Add a missing require to allow the usage of Array#to_xml | Santiago Pastorino | 2010-07-03 | 1 | -0/+1 |
| | |||||
* | Missing BigDecimal dependency | Jeremy Kemper | 2010-06-27 | 1 | -0/+2 |
| | |||||
* | Move constantize from conversions to inflections. | Santiago Pastorino | 2010-06-26 | 1 | -1/+0 |
| | | | | | | | | This removes ActiveModel dependency on TZInfo. [#4979 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Work around the fact the JSON gem was overwriting to_json implementation for ↵ | José Valim | 2010-06-26 | 3 | -17/+23 |
| | | | | | | | all Ruby core classes. This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized. So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved] | ||||
* | Regression with how base errors messages are added to a model. Works ↵ | Josh Kalderimis | 2010-06-23 | 3 | -5/+20 |
| | | | | | | correctly for both string error messages and symbol translated messages. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | should be able to run ActiveModel validations_test [#4933 state:resolved] | Neeraj Singh | 2010-06-22 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Avoid method redefined warning | Santiago Pastorino | 2010-06-22 | 1 | -1/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Refactor previous commit a bit [#4057 state:resolved] | José Valim | 2010-06-21 | 7 | -16/+16 |
| | |||||
* | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-06-21 | 11 | -411/+279 |
| | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-20 | 4 | -2/+146 |
|\ | | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb |