Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | add test coverage for activemodel Dirty#reset_changes | Dmitry Polushkin | 2014-02-09 | 1 | -0/+19 |
| | |||||
* | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399. | Yves Senn | 2014-02-04 | 3 | -1/+15 |
| | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ``` | ||||
* | tidy CHANGELOGs [ci skip] | Yves Senn | 2014-01-30 | 1 | -2/+5 |
| | |||||
* | use the new clear_validators! api everywhere to reset validators in tests | Kuldeep Aggarwal | 2014-01-28 | 1 | -1/+1 |
| | |||||
* | Fix doc markup of clear_validators! | Carlos Antonio da Silva | 2014-01-27 | 1 | -2/+2 |
| | |||||
* | Use the new clear_validators! api to reset validators in tests | Carlos Antonio da Silva | 2014-01-27 | 16 | -42/+33 |
| | |||||
* | Merge tests about multiple validation contexts | Carlos Antonio da Silva | 2014-01-27 | 1 | -10/+6 |
| | |||||
* | Ability to specify multiple contexts when defining a validation. | Vince Puzzella | 2014-01-27 | 3 | -5/+45 |
| | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context] | ||||
* | revises references to :allow_(nil|blank) in some docs [ci skip] [Steven Yang ↵ | Xavier Noria | 2014-01-26 | 10 | -26/+12 |
| | | | | | | & Xavier Noria] Closes #11247. | ||||
* | Some minor fixes | Godfrey Chan | 2014-01-24 | 2 | -3/+2 |
| | |||||
* | Removed old tests | Godfrey Chan | 2014-01-24 | 3 | -250/+121 |
| | |||||
* | Got all the new tests passing | Godfrey Chan | 2014-01-24 | 1 | -10/+8 |
| | |||||
* | Restored the ability to clear the password with user.password= nil (see the ↵ | Godfrey Chan | 2014-01-24 | 1 | -1/+3 |
| | | | | docs) | ||||
* | Rewrote the tests for has_secure_password | Godfrey Chan | 2014-01-24 | 3 | -2/+183 |
| | |||||
* | Update ActiveModel::Errors.has_key? test | Adrien Coquio | 2014-01-22 | 1 | -1/+1 |
| | |||||
* | Fix ActiveModel::Errors#has_key? return value | Adrien Coquio | 2014-01-22 | 1 | -1/+1 |
| | |||||
* | Add failing test for ActiveModel::Errors#has_key? method | Adrien Coquio | 2014-01-22 | 1 | -0/+5 |
| | | | | From the doc, this method should return false and not nil if there is no errors for this key | ||||
* | Fix typo | Rafael Mendonça França | 2014-01-21 | 1 | -1/+1 |
| | |||||
* | Forgot to push this change in the parent commit | Rafael Mendonça França | 2014-01-20 | 1 | -1/+1 |
| | |||||
* | When applying changes or reseting changes create the right class | Rafael Mendonça França | 2014-01-20 | 2 | -3/+11 |
| | | | | | | | Before this patch after the changes are applied the changes can be only accessed using string keys, but before symbols are also accepted. After this change every state of the model will be consistent. | ||||
* | Fix eager load of Serializers on Active Model | Carlos Antonio da Silva | 2014-01-17 | 1 | -2/+2 |
| | |||||
* | doc proc/lambda arg on inclusion validation. Closes #13689. [ci skip] | Yves Senn | 2014-01-13 | 1 | -1/+2 |
| | |||||
* | Use a better method name to check the requirement of password confirmation | Carlos Antonio da Silva | 2014-01-07 | 2 | -8/+8 |
| | | | | | Also improve changelog entries related to secure password to proper highlight. | ||||
* | Fix typo in AMo docs [ci skip] | Carlos Antonio da Silva | 2014-01-06 | 1 | -1/+1 |
| | |||||
* | Change all "can not"s to the correct "cannot". | T.J. Schuck | 2014-01-03 | 3 | -55/+55 |
| | |||||
* | update copyright notices to 2014. [ci skip] | Vipul A M | 2014-01-01 | 2 | -2/+2 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-12-31 | 4 | -5/+5 |
|\ | |||||
| * | Fix few typos and improve markup at some levels | Robin Dupret | 2013-12-24 | 4 | -5/+5 |
| | | |||||
* | | Merge pull request #13131 from gja/changed-accepts-values | Godfrey Chan | 2013-12-30 | 3 | -2/+22 |
|\ \ | | | | | | | Allows you to check if a field has changed to a particular value | ||||
| * | | Allows you to check if an attribute has changed to a particular value | Tejas Dinkar | 2013-12-15 | 3 | -2/+22 |
| | | | | | | | | | | | | model.name_changed?(from: "Pete", to: "Ringo") | ||||
* | | | Merge pull request #13483 from aditya-kapoor/add-missing-slashes | Yves Senn | 2013-12-27 | 6 | -6/+6 |
|\ \ \ | | | | | | | | | Adding missing backslashes in active_model files so as to avoid unwanted [ci skip] | ||||
| * | | | Adding missing backslashes in active_model files so as to avoid unwanted ↵ | aditya-kapoor | 2013-12-27 | 6 | -6/+6 |
| | | | | | | | | | | | | | | | | links in rdoc [ci skip] | ||||
* | | | | Merge pull request #13442 from aditya-kapoor/update-docs | Godfrey Chan | 2013-12-26 | 1 | -16/+11 |
|\ \ \ \ | |/ / / |/| | | | Updated documentation for Attribute Methods [ci skip] | ||||
| * | | | Added Backslashes to ActiveModel::AttributeMethods to prevent unwanted links ↵ | aditya-kapoor | 2013-12-25 | 1 | -16/+11 |
| | | | | | | | | | | | | | | | | in the rdoc + some other doc fixes.[ci skip] | ||||
* | | | | Disable locale checks to avoid warnings in Active Model tests [ci skip] | Carlos Antonio da Silva | 2013-12-23 | 1 | -0/+3 |
|/ / / | | | | | | | | | | | | | Missed AMo when adding to the other components in ae196e85ee7169700afac2eecdc276bc06b10b8d. | ||||
* | / | Fix few typos in the documentation [ci skip] | Robin Dupret | 2013-12-21 | 1 | -1/+1 |
| |/ |/| | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-12-20 | 2 | -2/+2 |
|\ \ | |||||
| * \ | Merge branch 'master' of github.com:lifo/docrails | aditya-kapoor | 2013-12-10 | 16 | -71/+159 |
| |\ \ | |||||
| | * | | Typos. return -> returns. [ci skip] | Lauro Caetano | 2013-12-03 | 1 | -1/+1 |
| | | | | |||||
| * | | | Merge branch 'master' of github.com:lifo/docrails | aditya-kapoor | 2013-09-01 | 3 | -9/+4 |
| |\ \ \ | |||||
| * | | | | fixed a typo | aditya-kapoor | 2013-08-20 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Unused classes in AMo tests | Akira Matsuda | 2013-12-19 | 1 | -11/+0 |
| | | | | | |||||
* | | | | | Get ready to release 4.1.0.beta1 | David Heinemeier Hansson | 2013-12-17 | 1 | -1/+1 |
| |_|_|/ |/| | | | |||||
* | | | | Fix typo [ci skip] | Rafael Mendonça França | 2013-12-13 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #13255 from strzalek/bump-builder | Rafael Mendonça França | 2013-12-12 | 1 | -1/+1 |
|\ \ \ \ | | | | | | | | | | | Bump up builder | ||||
| * | | | | More liberal builder dependency | Łukasz Strzałkowski | 2013-12-12 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | Allowing us to get 3.2.x versions if needed. | ||||
* | | | | | Added :nodoc: for `attribute_changed?` and `attribute_was` [ci skip] | Godfrey Chan | 2013-12-12 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods were made "public" in 47617ecd so that `method_missing` can invoke them without going through `send`, but they aren't meant for consumption from outside of Rails. | ||||
* | | | | | Spelling and Grammar checks | Akshay Vishnoi | 2013-12-12 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Merge pull request #13287 from aayushkhandelwal11/typo_rectified | Yves Senn | 2013-12-11 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | typos rectified lifecycle => life cycle | ||||
| * | | | | | typos rectified lifecycle => life cycle | Aayush khandelwal | 2013-12-12 | 1 | -1/+1 |
| |/ / / / |