aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
* Edit pass on `has_secure_password` documentation [ci skip]Godfrey Chan2014-06-141-5/+6
|
* [ci skip] Update #has_secure_password docsAkshay Vishnoi2014-06-141-6/+9
|
* Use `@existing_user` while updating existing user, fixing - #ee4e86Akshay Vishnoi2014-06-141-6/+6
|
* Cleaned up the `has_secure_password` test casesGodfrey Chan2014-06-141-33/+29
| | | | | | * Grouped the valid test cases in one place * Make the length of the generated password obvious * Removed two wrong (copy-and-pasted) test cases
* Added changelog for #15708 [ci skip]Godfrey Chan2014-06-141-0/+7
|
* SecurePassword - Validate password must be less than or equal to 72Akshay Vishnoi2014-06-142-0/+34
| | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters.
* Merge pull request #15690 from deeeki/activemodel_model_docArthur Nogueira Neves2014-06-131-3/+3
|\ | | | | [ci skip] Clarify ActiveModel::Model docs
| * [ci skip] Clarify ActiveModel::Model docsdeeeki2014-06-141-3/+3
| | | | | | | | ActiveModel attributes initialized with String return String values
* | [ci skip] correct docs for conversionAditya Kapoor2014-06-111-5/+12
|/
* [ci skip] add tests for ActionModel::ConversionAditya Kapoor2014-06-111-0/+4
|
* fix typo in changelog [ci skip]Vijay Dev2014-06-111-1/+1
|
* Merge pull request #15635 from kuldeepaggarwal/add-missing-changelogYves Senn2014-06-111-0/+6
|\ | | | | | | add missing changelog entry. refer [#16db90d] [ci skip]
| * add missing changelog entry. refer [#16db90d] [ci skip]Kuldeep Aggarwal2014-06-111-0/+4
|/
* remove depricated Validatior#setupKuldeep Aggarwal2014-06-102-37/+0
|
* Feature requests should be made on the mailing list, not submitted toZachary Scott2014-06-011-1/+6
| | | | the issue tracker. See also #15455 [ci skip]
* [ci skip] Include ActiveModel::Model in a class instead of inheritingAkshay Vishnoi2014-05-301-2/+3
|
* Name#model_name doesn't return a String objectShunsukeAida2014-05-302-2/+2
|
* Merge pull request #15154 from msgehard/move_password_fieldRafael Mendonça França2014-05-201-2/+2
|\ | | | | Put attr_reader in with all of the other instance methods
| * Put attr_reader in with all of the other instance methodsMike Gehard2014-05-171-2/+2
| | | | | | | | This makes the grouping make a little more sense
* | Let others know why this code is hereMike Gehard2014-05-181-0/+1
|/ | | | [ci skip]
* formatting pass through CHANGELOGS. [ci skip]Yves Senn2014-05-161-1/+1
|
* Add singular and plural form for some validation messagesAbd ar-Rahman Hamidi2014-05-023-6/+28
|
* Enhance a bit a few changelog entries [ci skip]Robin Dupret2014-05-021-1/+2
|
* Autoload ActiveModel::StrictValidationFailedhakanensari2014-04-161-0/+1
| | | | | | Currently, if environment doesn’t eager load code, invoking this constant before calling #valid? on a model instance results in a NameError.
* add missing parentheses to validates_with documentation [skip ci]Steve Agalloco2014-04-041-1/+1
|
* Fix warning for overshadowing XML variableMusannif Zahir2014-03-281-2/+2
|
* Adds explanation of :base attribute to errors.addDavid Underwood2014-03-271-0/+7
| | | [ci skip]
* Add CHANGELOG to Active Model too [ci skip]Rafael Mendonça França2014-03-271-0/+6
|
* ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-272-0/+13
| | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* comment why we are modifying global state. [ci skip]Yves Senn2014-03-111-0/+1
|
* Completely remove potential global state leaks in ActiveModel tests.Zuhao Wan2014-03-117-110/+136
| | | | ActiveModel tests can now be run in random order.
* Merge pull request #14315 from zuhao/activemodel_tests_in_random_orderYves Senn2014-03-094-13/+39
|\ | | | | Run ActiveModel test suites in random order.
| * Run ActiveModel test suites in random order.Zuhao Wan2014-03-104-13/+39
| | | | | | | | | | | | | | | | | | | | This gets the whole ActiveModel test suites working even if `self.i_suck_and_my_tests_are_order_dependent!` is disabled in `ActiveSupport::TestCase`. Two places are found that potentially leak global state. This patch makes sure states are restored so that none of the changes happen in a single test will be carried over to subsequence tests.
* | Fix errors for four of the code samplesPeter Markou2014-03-081-30/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The four code samples that fail to run are: - Add attribute magic to objects. Fixed by introducing a Person instance variable. - Tracking value changes. Fixed by replacing `attr_accessor` with `define_attribute_methods`, providing getter and setter methods for `name` and providing the missing `Person#save` method. A call to `Person#save` has to precede the `person.name = 'robert'` assignment, if we want `previous_changes` to include 'bob'. - Adding `errors` interface to objects. Fixed by introducing a Person instance variable, assigning `nil` to its name and calling `Person#validate!`. - Custom validators. Fixed by defining `HasNameValidator` before it is used by `ValidatorPerson`. All the code samples can now be run smoothly. Call Dirty#changes_applied in Person#save, instead of modifying instance vars.
* | Tests for indifferent access using full_messages_for. Closes #11916Pavel Penkov2014-03-081-0/+7
|/
* Introduce `Rails.gem_version`Prem Sichanugrist2014-03-052-7/+19
| | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`.
* Fix some validators when used on model instanceEric Hutzelman2014-02-263-2/+6
| | | | | | | | Now that Validator #setup is called from the initializer, we need a reference to the model's class to be passed in to allow the validators to continue functioning when used at the instance level. Closes #14134.
* Pass strings to demodulize methodCarlos Antonio da Silva2014-02-261-1/+1
| | | | | Goes along with fea1cdcff4d50d302d8e8532432c3ab107ff816d and 59ec4562a2e70df455b2e44a67c340fa5254e26e.
* pass the class name to `tableize`Aaron Patterson2014-02-261-1/+1
| | | | We should not rely on to_s to return the name of the class
* Bump version of bcrypt gemT.J. Schuck2014-02-251-4/+4
|
* Point master changelogs to 4-1-stable branchCarlos Antonio da Silva2014-02-251-72/+1
| | | | Remove 4-1 related entries from master [ci skip]
* update version to 4.2.0.alphaYves Senn2014-02-231-1/+1
|
* Merge branch '4-1-0-beta2'Rafael Mendonça França2014-02-181-1/+1
|\ | | | | | | | | | | Conflicts: actionview/CHANGELOG.md activerecord/CHANGELOG.md
| * Preparing for 4.1.0.beta2 releaseRafael Mendonça França2014-02-181-1/+1
| |
* | add test coverage for activemodel Dirty#reset_changesDmitry Polushkin2014-02-091-0/+19
| |
* | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399.Yves Senn2014-02-043-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ```
* | tidy CHANGELOGs [ci skip]Yves Senn2014-01-301-2/+5
| |
* | use the new clear_validators! api everywhere to reset validators in testsKuldeep Aggarwal2014-01-281-1/+1
| |
* | Fix doc markup of clear_validators!Carlos Antonio da Silva2014-01-271-2/+2
| |
* | Use the new clear_validators! api to reset validators in testsCarlos Antonio da Silva2014-01-2716-42/+33
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 08:57:56 +0000