Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #16210 from sonnym/assert_valid_keys_in_validate | Matthew Draper | 2014-07-18 | 3 | -0/+19 |
|\ | | | | | | | Check for valid options in validate method | ||||
| * | check for valid options in validate method | sonnym | 2014-07-17 | 3 | -0/+18 |
|/ | | | | | | | | | | | This change prevents a certain class of user error which results when mistakenly using the `validate` class method instead of the `validates` class method. Only apply when all arguments are symbols, because some validations use the `validate` method and pass in additional options, namely the `LenghValidator` via the `ActiveMode::Validations::validates_with` method. | ||||
* | Make restore_attributes public | Rafael Mendonça França | 2014-07-17 | 2 | -10/+20 |
| | | | | | | | Also make it accept a list of attributes to be changed. This will make possible to restore only a subset of the changed attributes. Closes #16203 | ||||
* | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`. | Rafael Mendonça França | 2014-07-15 | 3 | -9/+22 |
| | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods. | ||||
* | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵ | Rafael Mendonça França | 2014-07-15 | 3 | -4/+40 |
| | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes. | ||||
* | [ci skip] Little bit doc code improvement. | Santosh Wadghule | 2014-07-14 | 1 | -1/+1 |
| | |||||
* | Only automatically include validations when enabled | Godfrey Chan | 2014-07-02 | 2 | -12/+5 |
| | | | | This is a follow up to #16024. | ||||
* | automatically include ActiveModel::Validations when include ↵ | Aditya Kapoor | 2014-07-03 | 4 | -2/+6 |
| | | | | ActiveModel::SecurePassword | ||||
* | Silence warning emitted in tests | Sean Griffin | 2014-07-01 | 1 | -0/+1 |
| | | | | | The instance method `model_name` was being defined multiple times, causing a redefinition warning. | ||||
* | Rename rollback_changes to undo_changes | Rafael Mendonça França | 2014-06-30 | 3 | -6/+6 |
| | | | | To avoid overload with database rollback | ||||
* | Add CHANGELOG entry for #14861 and document private methods on the API | Rafael Mendonça França | 2014-06-30 | 2 | -5/+10 |
| | |||||
* | Merge pull request #14861 from igor04/dirty-rollback | Rafael Mendonça França | 2014-06-30 | 2 | -0/+35 |
|\ | | | | | | | Added rollback method to ActiveModel::Dirty | ||||
| * | Added rollback method to ActiveModel::Dirty | igor04 | 2014-06-23 | 2 | -0/+35 |
| | | |||||
* | | We are talking about the libraries, not the constants | Sean Griffin | 2014-06-27 | 1 | -3/+3 |
| | | |||||
* | | Note that `_will_change!` is no longer needed for AR instances | Sean Griffin | 2014-06-27 | 1 | -3/+5 |
| | | | | | | | | | | | | | | Leave the note for `ActiveModel`, since it can't yet detect mutations (hopefully we can change this in time for 4.2). However, we now detect mutations on all supported types in `ActiveRecord`, so we can note that `_will_change!` is no longer needed there. | ||||
* | | Merge pull request #15834 from rmehner/allow_proc_and_symbol_for_only_integer | Rafael Mendonça França | 2014-06-26 | 3 | -1/+32 |
|\ \ | | | | | | | Allow proc and symbol as values for `only_integer` of `NumericalityValidator` | ||||
| * | | `only_integer` of `NumericalityValidator` now allows procs and symbols | Robin Mehner | 2014-06-22 | 3 | -1/+32 |
| | | | |||||
* | | | Merge pull request #15871 from yuki24/add-model-name-instance-method | David Heinemeier Hansson | 2014-06-24 | 2 | -0/+12 |
|\ \ \ | | | | | | | | | Add #model_name instance method to ActiveModel::Naming | ||||
| * | | | Delegate #model_name method to self.class | Yuki Nishijima | 2014-06-22 | 2 | -0/+12 |
| |/ / | |||||
* / / | remove unnecessary require for json serialization test cases | Aditya Kapoor | 2014-06-24 | 1 | -1/+0 |
|/ / | |||||
* | | :scissors: and :nail_care: from d60c405 [ci skip] | Zachary Scott | 2014-06-16 | 1 | -3/+3 |
| | | |||||
* | | [ci skip] correct doc for serialization in accordance with API Doc Guide | Aditya Kapoor | 2014-06-16 | 1 | -11/+11 |
| | | |||||
* | | Correct typo, add test for validates_absence_of, correct method names | Akshay Vishnoi | 2014-06-16 | 1 | -3/+4 |
| | | |||||
* | | Edit pass on `has_secure_password` documentation [ci skip] | Godfrey Chan | 2014-06-14 | 1 | -5/+6 |
| | | |||||
* | | [ci skip] Update #has_secure_password docs | Akshay Vishnoi | 2014-06-14 | 1 | -6/+9 |
| | | |||||
* | | Use `@existing_user` while updating existing user, fixing - #ee4e86 | Akshay Vishnoi | 2014-06-14 | 1 | -6/+6 |
| | | |||||
* | | Cleaned up the `has_secure_password` test cases | Godfrey Chan | 2014-06-14 | 1 | -33/+29 |
| | | | | | | | | | | | | * Grouped the valid test cases in one place * Make the length of the generated password obvious * Removed two wrong (copy-and-pasted) test cases | ||||
* | | Added changelog for #15708 [ci skip] | Godfrey Chan | 2014-06-14 | 1 | -0/+7 |
| | | |||||
* | | SecurePassword - Validate password must be less than or equal to 72 | Akshay Vishnoi | 2014-06-14 | 2 | -0/+34 |
| | | | | | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters. | ||||
* | | Merge pull request #15690 from deeeki/activemodel_model_doc | Arthur Nogueira Neves | 2014-06-13 | 1 | -3/+3 |
|\ \ | | | | | | | [ci skip] Clarify ActiveModel::Model docs | ||||
| * | | [ci skip] Clarify ActiveModel::Model docs | deeeki | 2014-06-14 | 1 | -3/+3 |
| | | | | | | | | | | | | ActiveModel attributes initialized with String return String values | ||||
* | | | [ci skip] correct docs for conversion | Aditya Kapoor | 2014-06-11 | 1 | -5/+12 |
|/ / | |||||
* | | [ci skip] add tests for ActionModel::Conversion | Aditya Kapoor | 2014-06-11 | 1 | -0/+4 |
| | | |||||
* | | fix typo in changelog [ci skip] | Vijay Dev | 2014-06-11 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #15635 from kuldeepaggarwal/add-missing-changelog | Yves Senn | 2014-06-11 | 1 | -0/+6 |
|\ \ | | | | | | | | | | add missing changelog entry. refer [#16db90d] [ci skip] | ||||
| * | | add missing changelog entry. refer [#16db90d] [ci skip] | Kuldeep Aggarwal | 2014-06-11 | 1 | -0/+4 |
|/ / | |||||
* | | remove depricated Validatior#setup | Kuldeep Aggarwal | 2014-06-10 | 2 | -37/+0 |
| | | |||||
* | | Feature requests should be made on the mailing list, not submitted to | Zachary Scott | 2014-06-01 | 1 | -1/+6 |
| | | | | | | | | the issue tracker. See also #15455 [ci skip] | ||||
* | | [ci skip] Include ActiveModel::Model in a class instead of inheriting | Akshay Vishnoi | 2014-05-30 | 1 | -2/+3 |
| | | |||||
* | | Name#model_name doesn't return a String object | ShunsukeAida | 2014-05-30 | 2 | -2/+2 |
| | | |||||
* | | Merge pull request #15154 from msgehard/move_password_field | Rafael Mendonça França | 2014-05-20 | 1 | -2/+2 |
|\ \ | | | | | | | Put attr_reader in with all of the other instance methods | ||||
| * | | Put attr_reader in with all of the other instance methods | Mike Gehard | 2014-05-17 | 1 | -2/+2 |
| | | | | | | | | | | | | This makes the grouping make a little more sense | ||||
* | | | Let others know why this code is here | Mike Gehard | 2014-05-18 | 1 | -0/+1 |
|/ / | | | | | | | [ci skip] | ||||
* | | formatting pass through CHANGELOGS. [ci skip] | Yves Senn | 2014-05-16 | 1 | -1/+1 |
| | | |||||
* | | Add singular and plural form for some validation messages | Abd ar-Rahman Hamidi | 2014-05-02 | 3 | -6/+28 |
| | | |||||
* | | Enhance a bit a few changelog entries [ci skip] | Robin Dupret | 2014-05-02 | 1 | -1/+2 |
|/ | |||||
* | Autoload ActiveModel::StrictValidationFailed | hakanensari | 2014-04-16 | 1 | -0/+1 |
| | | | | | | Currently, if environment doesn’t eager load code, invoking this constant before calling #valid? on a model instance results in a NameError. | ||||
* | add missing parentheses to validates_with documentation [skip ci] | Steve Agalloco | 2014-04-04 | 1 | -1/+1 |
| | |||||
* | Fix warning for overshadowing XML variable | Musannif Zahir | 2014-03-28 | 1 | -2/+2 |
| | |||||
* | Adds explanation of :base attribute to errors.add | David Underwood | 2014-03-27 | 1 | -0/+7 |
| | | | [ci skip] |