aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
* add test coverage for activemodel Dirty#reset_changesDmitry Polushkin2014-02-091-0/+19
|
* `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399.Yves Senn2014-02-043-1/+15
| | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ```
* tidy CHANGELOGs [ci skip]Yves Senn2014-01-301-2/+5
|
* use the new clear_validators! api everywhere to reset validators in testsKuldeep Aggarwal2014-01-281-1/+1
|
* Fix doc markup of clear_validators!Carlos Antonio da Silva2014-01-271-2/+2
|
* Use the new clear_validators! api to reset validators in testsCarlos Antonio da Silva2014-01-2716-42/+33
|
* Merge tests about multiple validation contextsCarlos Antonio da Silva2014-01-271-10/+6
|
* Ability to specify multiple contexts when defining a validation.Vince Puzzella2014-01-273-5/+45
| | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context]
* revises references to :allow_(nil|blank) in some docs [ci skip] [Steven Yang ↵Xavier Noria2014-01-2610-26/+12
| | | | | | & Xavier Noria] Closes #11247.
* Some minor fixesGodfrey Chan2014-01-242-3/+2
|
* Removed old testsGodfrey Chan2014-01-243-250/+121
|
* Got all the new tests passingGodfrey Chan2014-01-241-10/+8
|
* Restored the ability to clear the password with user.password= nil (see the ↵Godfrey Chan2014-01-241-1/+3
| | | | docs)
* Rewrote the tests for has_secure_passwordGodfrey Chan2014-01-243-2/+183
|
* Update ActiveModel::Errors.has_key? testAdrien Coquio2014-01-221-1/+1
|
* Fix ActiveModel::Errors#has_key? return valueAdrien Coquio2014-01-221-1/+1
|
* Add failing test for ActiveModel::Errors#has_key? methodAdrien Coquio2014-01-221-0/+5
| | | | From the doc, this method should return false and not nil if there is no errors for this key
* Fix typoRafael Mendonça França2014-01-211-1/+1
|
* Forgot to push this change in the parent commitRafael Mendonça França2014-01-201-1/+1
|
* When applying changes or reseting changes create the right classRafael Mendonça França2014-01-202-3/+11
| | | | | | | Before this patch after the changes are applied the changes can be only accessed using string keys, but before symbols are also accepted. After this change every state of the model will be consistent.
* Fix eager load of Serializers on Active ModelCarlos Antonio da Silva2014-01-171-2/+2
|
* doc proc/lambda arg on inclusion validation. Closes #13689. [ci skip]Yves Senn2014-01-131-1/+2
|
* Use a better method name to check the requirement of password confirmationCarlos Antonio da Silva2014-01-072-8/+8
| | | | | Also improve changelog entries related to secure password to proper highlight.
* Fix typo in AMo docs [ci skip]Carlos Antonio da Silva2014-01-061-1/+1
|
* Change all "can not"s to the correct "cannot".T.J. Schuck2014-01-033-55/+55
|
* update copyright notices to 2014. [ci skip]Vipul A M2014-01-012-2/+2
|
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-314-5/+5
|\
| * Fix few typos and improve markup at some levelsRobin Dupret2013-12-244-5/+5
| |
* | Merge pull request #13131 from gja/changed-accepts-valuesGodfrey Chan2013-12-303-2/+22
|\ \ | | | | | | Allows you to check if a field has changed to a particular value
| * | Allows you to check if an attribute has changed to a particular valueTejas Dinkar2013-12-153-2/+22
| | | | | | | | | | | | model.name_changed?(from: "Pete", to: "Ringo")
* | | Merge pull request #13483 from aditya-kapoor/add-missing-slashesYves Senn2013-12-276-6/+6
|\ \ \ | | | | | | | | Adding missing backslashes in active_model files so as to avoid unwanted [ci skip]
| * | | Adding missing backslashes in active_model files so as to avoid unwanted ↵aditya-kapoor2013-12-276-6/+6
| | | | | | | | | | | | | | | | links in rdoc [ci skip]
* | | | Merge pull request #13442 from aditya-kapoor/update-docsGodfrey Chan2013-12-261-16/+11
|\ \ \ \ | |/ / / |/| | | Updated documentation for Attribute Methods [ci skip]
| * | | Added Backslashes to ActiveModel::AttributeMethods to prevent unwanted links ↵aditya-kapoor2013-12-251-16/+11
| | | | | | | | | | | | | | | | in the rdoc + some other doc fixes.[ci skip]
* | | | Disable locale checks to avoid warnings in Active Model tests [ci skip]Carlos Antonio da Silva2013-12-231-0/+3
|/ / / | | | | | | | | | | | | Missed AMo when adding to the other components in ae196e85ee7169700afac2eecdc276bc06b10b8d.
* | / Fix few typos in the documentation [ci skip]Robin Dupret2013-12-211-1/+1
| |/ |/|
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-202-2/+2
|\ \
| * \ Merge branch 'master' of github.com:lifo/docrailsaditya-kapoor2013-12-1016-71/+159
| |\ \
| | * | Typos. return -> returns. [ci skip]Lauro Caetano2013-12-031-1/+1
| | | |
| * | | Merge branch 'master' of github.com:lifo/docrailsaditya-kapoor2013-09-013-9/+4
| |\ \ \
| * | | | fixed a typoaditya-kapoor2013-08-201-1/+1
| | | | |
* | | | | Unused classes in AMo testsAkira Matsuda2013-12-191-11/+0
| | | | |
* | | | | Get ready to release 4.1.0.beta1David Heinemeier Hansson2013-12-171-1/+1
| |_|_|/ |/| | |
* | | | Fix typo [ci skip]Rafael Mendonça França2013-12-131-1/+1
| | | |
* | | | Merge pull request #13255 from strzalek/bump-builderRafael Mendonça França2013-12-121-1/+1
|\ \ \ \ | | | | | | | | | | Bump up builder
| * | | | More liberal builder dependencyŁukasz Strzałkowski2013-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | Allowing us to get 3.2.x versions if needed.
* | | | | Added :nodoc: for `attribute_changed?` and `attribute_was` [ci skip]Godfrey Chan2013-12-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods were made "public" in 47617ecd so that `method_missing` can invoke them without going through `send`, but they aren't meant for consumption from outside of Rails.
* | | | | Spelling and Grammar checksAkshay Vishnoi2013-12-121-1/+1
| | | | |
* | | | | Merge pull request #13287 from aayushkhandelwal11/typo_rectifiedYves Senn2013-12-111-1/+1
|\ \ \ \ \ | | | | | | | | | | | | typos rectified lifecycle => life cycle
| * | | | | typos rectified lifecycle => life cycleAayush khandelwal2013-12-121-1/+1
| |/ / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-23 19:02:04 +0000