aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
* Using define method instead of class eval when defining model callbacks.wangjohn2013-05-081-18/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Based on my benchmark results, this change improves performance substantially when defining callbacks. This benchmark (https://gist.github.com/wangjohn/5542610) was run using the current master and also using my experimental branch which replaced class_eval with define_single_method. Using class_eval (current master): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.001568) 50 trials 0.020000 0.000000 0.020000 ( 0.021715) 500 trials 0.110000 0.000000 0.110000 ( 0.115357) 1000 trials 0.250000 0.000000 0.250000 ( 0.260025) 10000 trials 2.560000 0.000000 2.560000 ( 2.568408) 50000 trials 12.800000 0.010000 12.810000 ( 12.886871) Using define_single_method (experimental branch): user system total real 10 trials 0.000000 0.000000 0.000000 ( 0.000790) 50 trials 0.000000 0.000000 0.000000 ( 0.002960) 500 trials 0.050000 0.010000 0.060000 ( 0.055690) 1000 trials 0.100000 0.000000 0.100000 ( 0.094073) 10000 trials 0.890000 0.000000 0.890000 ( 0.900364) 50000 trials 4.650000 0.000000 4.650000 ( 4.686127)
* Convert ActiveModel to 1.9 hash syntax.Patrick Robertson2013-05-0143-349/+351
| | | | | I also attempted to fix other styleguide violations such as { a: :b } over {a: :b} and foo(b: 'bar') over foo( b: 'bar' ).
* rails/master is now 4.1.0.betaRafael Mendonça França2013-04-292-213/+3
|
* Bump version to rc1David Heinemeier Hansson2013-04-291-1/+1
|
* pass over the code commentsXavier Noria2013-04-281-28/+32
| | | | | | * Highlights the requirement of an attributes method. * Removes some details that depend on the implementation of the class including the module. * Applies guidelines here and there.
* Merge pull request #10286 from ↵Carlos Antonio da Silva2013-04-211-2/+2
|\ | | | | | | | | neerajdotname/fix-wrong-test-name-and-failure-message fix wrong test description and failure message
| * fix wrong test description and failure messageNeeraj Singh2013-04-211-2/+2
| |
* | Added tests for if condition in Active Model callbacksNeeraj Singh2013-04-211-0/+21
|/
* align the result of expressions vertically [ci skip].Yves Senn2013-04-121-7/+7
|
* use unified and clean formatting in CHANGELOGS. [ci skip]Yves Senn2013-04-121-9/+12
|
* Removed unused setupAnupam Choudhury2013-04-091-4/+0
|
* Prefer find_by over dynamic finders in rdocSam Ruby2013-04-022-8/+8
|
* Review some tests from AMo::Errors to remove "should" usageCarlos Antonio da Silva2013-03-301-55/+35
| | | | | Also remove duplicated tests for Errors#as_json and minor improvements in some tests.
* Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip]Carlos Antonio da Silva2013-03-302-4/+13
| | | | Add a working example of how to use this new method.
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-301-1/+1
|\ | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb activerecord/test/cases/adapter_test.rb guides/source/testing.md [ci skip]
| * Reverted change in activemodel/CHANGELOG.md introduced by ↵Prathamesh Sonpatki2013-03-241-2/+2
| | | | | | | | d45145acdc576e46a1f1719d69bec96b5bf07b0a
| * Changed 'args' to 'arguments' when used in places other than code with ↵Prathamesh Sonpatki2013-03-241-2/+2
| | | | | | | | fixing few more typos
| * clarify verbiageWaynn Lue2013-03-121-1/+1
| |
* | Merge pull request #8527 from shockone/patch-1Rafael Mendonça França2013-03-253-0/+39
|\ \ | | | | | | Add a method full_messages_for to the Errors class
| * | Add a method full_messages_for to the Errors classshock_one2013-03-243-0/+39
| | |
* | | Merge pull request #9864 from vipulnsward/fix_test_AR_v2Rafael Mendonça França2013-03-251-0/+1
|\ \ \ | |/ / |/| | Introduce test on Error#full_message for attribute with underscores; Fix...
| * | Add Error#full_message test; Fix typosVipul A M2013-03-221-0/+1
| | | | | | | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos
* | | Merge pull request #8501 from charliesome/version-to-sRafael Mendonça França2013-03-231-6/+7
|\ \ \ | | | | | | | | Add #to_s method to VERSION modules
| * | | Add version method to top level modulesCharlie Somerville2013-03-211-6/+7
| | | |
* | | | Fixed typo in activemodel/CHANGELOGPrathamesh Sonpatki2013-03-241-1/+1
| | | |
* | | | Remove exception variable from rescue blockCarlos Antonio da Silva2013-03-221-2/+2
| |/ / |/| | | | | | | | | | | Just raising from the rescue block will re-raise the exception, so the variable is not necessary.
* | | Change Standard error when is required bcrypt-ruby and failsrobertomiranda2013-03-211-2/+7
| | |
* | | Tidying up some require : removing useless sort and homogenizing with the ↵Intrepidd2013-03-201-4/+1
|/ / | | | | | | rest of the code the wat the includes are done
* | The repair_validations helper was not working correctly before becausewangjohn2013-03-192-0/+64
| | | | | | | | | | | | it only cleared the validations that created :validate callbacks. This didn't include the validates created by validates_with, so I've added a method to clear all validations.
* | Revert "instruct RDoc to only parse Ruby files under lib [Fixes #9779]"Xavier Noria2013-03-181-1/+1
| | | | | | | | This reverts commit c24528fbc94dea9946a563be3bed9559583bdc57.
* | instruct RDoc to only parse Ruby files under lib [Fixes #9779]Xavier Noria2013-03-181-1/+1
| |
* | fix some typos found in activemodelVipul A M2013-03-183-4/+4
| |
* | Small typos here and there.Vipul A M2013-03-154-5/+5
|/
* Fix AMo code example indent, add missing author to entry [ci skip]Carlos Antonio da Silva2013-03-091-6/+8
|
* Merge pull request #9545 from senny/9535_secure_password_blankRafael Mendonça França2013-03-075-3/+75
|\ | | | | `has_secure_password` is not invalid when assigning empty Strings
| * `has_secure_password` is not invalid when assigning empty Strings.Yves Senn2013-03-043-2/+24
| | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`.
| * `validates_confirmation_of` does not override writer methods.Yves Senn2013-03-043-1/+51
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-03-051-1/+1
|\ \ | |/ |/|
| * Small TypoLebin Sebastian F2013-03-041-1/+1
| |
* | Update CHANGELOGSRafael Mendonça França2013-02-261-0/+3
|/
* Preparing for 4.0.0.beta1 releaseDavid Heinemeier Hansson2013-02-252-2/+2
|
* did a pass over the AM changelog [ci skip]Xavier Noria2013-02-241-15/+35
|
* added more accurate test for add_on_emptyAngelo capilleri2013-02-191-0/+7
| | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-02-151-0/+3
|\ | | | | | | | | Conflicts: guides/source/upgrading_ruby_on_rails.md
| * Clarify ActiveModel::Validator initialization in docs.Henrik Nyh2013-02-091-0/+3
| | | | | | As discussed with @josevalim on Ruby Rogues Parley.
* | Take care of whitespaces and changing the hash syntaxRafael Mendonça França2013-02-041-57/+56
| |
* | test for issue 8931David2013-02-021-0/+8
|/
* Missing require extract_optionsAkira Matsuda2013-01-311-0/+2
|
* Adding the route_key and param_key testsAttila Domokos2013-01-221-0/+8
| | | This way all the tests are testing the same fields
* Revert "Merge pull request #8989 from robertomiranda/use-rails-4-find-by"Guillermo Iguaran2013-01-182-3/+3
| | | | | This reverts commit 637a7d9d357a0f3f725b0548282ca8c5e7d4af4a, reversing changes made to 5937bd02dee112646469848d7fe8a8bfcef5b4c1.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 06:49:08 +0000