aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
...
* add missing parentheses to validates_with documentation [skip ci]Steve Agalloco2014-04-041-1/+1
|
* Fix warning for overshadowing XML variableMusannif Zahir2014-03-281-2/+2
|
* Adds explanation of :base attribute to errors.addDavid Underwood2014-03-271-0/+7
| | | [ci skip]
* Add CHANGELOG to Active Model too [ci skip]Rafael Mendonça França2014-03-271-0/+6
|
* ActiveRecord/ActiveModel '#validate' alias for 'valid?'Henrik Nyh2014-03-272-0/+13
| | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
* comment why we are modifying global state. [ci skip]Yves Senn2014-03-111-0/+1
|
* Completely remove potential global state leaks in ActiveModel tests.Zuhao Wan2014-03-117-110/+136
| | | | ActiveModel tests can now be run in random order.
* Merge pull request #14315 from zuhao/activemodel_tests_in_random_orderYves Senn2014-03-094-13/+39
|\ | | | | Run ActiveModel test suites in random order.
| * Run ActiveModel test suites in random order.Zuhao Wan2014-03-104-13/+39
| | | | | | | | | | | | | | | | | | | | This gets the whole ActiveModel test suites working even if `self.i_suck_and_my_tests_are_order_dependent!` is disabled in `ActiveSupport::TestCase`. Two places are found that potentially leak global state. This patch makes sure states are restored so that none of the changes happen in a single test will be carried over to subsequence tests.
* | Fix errors for four of the code samplesPeter Markou2014-03-081-30/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The four code samples that fail to run are: - Add attribute magic to objects. Fixed by introducing a Person instance variable. - Tracking value changes. Fixed by replacing `attr_accessor` with `define_attribute_methods`, providing getter and setter methods for `name` and providing the missing `Person#save` method. A call to `Person#save` has to precede the `person.name = 'robert'` assignment, if we want `previous_changes` to include 'bob'. - Adding `errors` interface to objects. Fixed by introducing a Person instance variable, assigning `nil` to its name and calling `Person#validate!`. - Custom validators. Fixed by defining `HasNameValidator` before it is used by `ValidatorPerson`. All the code samples can now be run smoothly. Call Dirty#changes_applied in Person#save, instead of modifying instance vars.
* | Tests for indifferent access using full_messages_for. Closes #11916Pavel Penkov2014-03-081-0/+7
|/
* Introduce `Rails.gem_version`Prem Sichanugrist2014-03-052-7/+19
| | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`.
* Fix some validators when used on model instanceEric Hutzelman2014-02-263-2/+6
| | | | | | | | Now that Validator #setup is called from the initializer, we need a reference to the model's class to be passed in to allow the validators to continue functioning when used at the instance level. Closes #14134.
* Pass strings to demodulize methodCarlos Antonio da Silva2014-02-261-1/+1
| | | | | Goes along with fea1cdcff4d50d302d8e8532432c3ab107ff816d and 59ec4562a2e70df455b2e44a67c340fa5254e26e.
* pass the class name to `tableize`Aaron Patterson2014-02-261-1/+1
| | | | We should not rely on to_s to return the name of the class
* Bump version of bcrypt gemT.J. Schuck2014-02-251-4/+4
|
* Point master changelogs to 4-1-stable branchCarlos Antonio da Silva2014-02-251-72/+1
| | | | Remove 4-1 related entries from master [ci skip]
* update version to 4.2.0.alphaYves Senn2014-02-231-1/+1
|
* Merge branch '4-1-0-beta2'Rafael Mendonça França2014-02-181-1/+1
|\ | | | | | | | | | | Conflicts: actionview/CHANGELOG.md activerecord/CHANGELOG.md
| * Preparing for 4.1.0.beta2 releaseRafael Mendonça França2014-02-181-1/+1
| |
* | add test coverage for activemodel Dirty#reset_changesDmitry Polushkin2014-02-091-0/+19
| |
* | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399.Yves Senn2014-02-043-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ```
* | tidy CHANGELOGs [ci skip]Yves Senn2014-01-301-2/+5
| |
* | use the new clear_validators! api everywhere to reset validators in testsKuldeep Aggarwal2014-01-281-1/+1
| |
* | Fix doc markup of clear_validators!Carlos Antonio da Silva2014-01-271-2/+2
| |
* | Use the new clear_validators! api to reset validators in testsCarlos Antonio da Silva2014-01-2716-42/+33
| |
* | Merge tests about multiple validation contextsCarlos Antonio da Silva2014-01-271-10/+6
| |
* | Ability to specify multiple contexts when defining a validation.Vince Puzzella2014-01-273-5/+45
| | | | | | | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context]
* | revises references to :allow_(nil|blank) in some docs [ci skip] [Steven Yang ↵Xavier Noria2014-01-2610-26/+12
| | | | | | | | | | | | & Xavier Noria] Closes #11247.
* | Some minor fixesGodfrey Chan2014-01-242-3/+2
| |
* | Removed old testsGodfrey Chan2014-01-243-250/+121
| |
* | Got all the new tests passingGodfrey Chan2014-01-241-10/+8
| |
* | Restored the ability to clear the password with user.password= nil (see the ↵Godfrey Chan2014-01-241-1/+3
| | | | | | | | docs)
* | Rewrote the tests for has_secure_passwordGodfrey Chan2014-01-243-2/+183
| |
* | Update ActiveModel::Errors.has_key? testAdrien Coquio2014-01-221-1/+1
| |
* | Fix ActiveModel::Errors#has_key? return valueAdrien Coquio2014-01-221-1/+1
| |
* | Add failing test for ActiveModel::Errors#has_key? methodAdrien Coquio2014-01-221-0/+5
| | | | | | | | From the doc, this method should return false and not nil if there is no errors for this key
* | Fix typoRafael Mendonça França2014-01-211-1/+1
| |
* | Forgot to push this change in the parent commitRafael Mendonça França2014-01-201-1/+1
| |
* | When applying changes or reseting changes create the right classRafael Mendonça França2014-01-202-3/+11
| | | | | | | | | | | | | | Before this patch after the changes are applied the changes can be only accessed using string keys, but before symbols are also accepted. After this change every state of the model will be consistent.
* | Fix eager load of Serializers on Active ModelCarlos Antonio da Silva2014-01-171-2/+2
| |
* | doc proc/lambda arg on inclusion validation. Closes #13689. [ci skip]Yves Senn2014-01-131-1/+2
| |
* | Use a better method name to check the requirement of password confirmationCarlos Antonio da Silva2014-01-072-8/+8
| | | | | | | | | | Also improve changelog entries related to secure password to proper highlight.
* | Fix typo in AMo docs [ci skip]Carlos Antonio da Silva2014-01-061-1/+1
| |
* | Change all "can not"s to the correct "cannot".T.J. Schuck2014-01-033-55/+55
| |
* | update copyright notices to 2014. [ci skip]Vipul A M2014-01-012-2/+2
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-12-314-5/+5
|\ \
| * | Fix few typos and improve markup at some levelsRobin Dupret2013-12-244-5/+5
| | |
* | | Merge pull request #13131 from gja/changed-accepts-valuesGodfrey Chan2013-12-303-2/+22
|\ \ \ | | | | | | | | Allows you to check if a field has changed to a particular value
| * | | Allows you to check if an attribute has changed to a particular valueTejas Dinkar2013-12-153-2/+22
| | | | | | | | | | | | | | | | model.name_changed?(from: "Pete", to: "Ringo")
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-30 12:36:19 +0000