Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Revert "Omit directories from gemspec.files for RubyGems 2 compat." | Jeremy Kemper | 2012-12-09 | 1 | -1/+1 | |
| | | | | | | Obviated by rubygems/rubygems@486ed83cc8e706069213c5d406122f4cfcca9e7f This reverts commit bb8923dee093b615615cdfb83b34d1b0bb254f25. | |||||
* | Omit directories from gemspec.files for RubyGems 2 compat. | Jeremy Kemper | 2012-12-08 | 1 | -1/+1 | |
| | | | | | | RG2 packager expects each spec.files path to be a file and bombs when it tries to tarball a dir. May revert if rubygems/rubygems#413 is accepted. | |||||
* | Replace comments' non-breaking spaces with spaces | claudiob | 2012-12-04 | 3 | -6/+6 | |
| | | | | | | | | | | Sometimes, on Mac OS X, programmers accidentally press Option+Space rather than just Space and don’t see the difference. The problem is that Option+Space writes a non-breaking space (0XA0) rather than a normal space (0x20). This commit removes all the non-breaking spaces inadvertently introduced in the comments of the code. | |||||
* | Actually test that ActiveModel::Errors#add defaults to :invalid. | Renato Mascarenhas | 2012-12-01 | 1 | -1/+1 | |
| | ||||||
* | Call `full_messages` instead of `to_a` in its spec. | Renato Mascarenhas | 2012-12-01 | 1 | -2/+1 | |
| | ||||||
* | Reset attributes should not report changes. | Renato Mascarenhas | 2012-12-01 | 3 | -3/+9 | |
| | | | | | | | | | | | When resetting an attribute, you expect it to return to the state it was before any changes. Namely, this fixes this unexpected behavior: ~~~ruby model.name = "Bob" model.reset_name! model.name_changed? #=> true ~~~ | |||||
* | Simplify keys order test for as_json in Active Model | Carlos Antonio da Silva | 2012-11-30 | 1 | -4/+1 | |
| | ||||||
* | Add CHANGELOG entries for the observes extraction | Rafael Mendonça França | 2012-11-29 | 1 | -0/+4 | |
| | | | | [ci skip] | |||||
* | Remove observers and sweepers | Rafael Mendonça França | 2012-11-28 | 6 | -955/+0 | |
| | | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik] | |||||
* | Specify type of singular association during serialization | Steve Klabnik | 2012-11-28 | 3 | -3/+18 | |
| | | | | | | | | | | | | When serialising a class, specify the type of any singular associations, if necessary. Rails already correctly specifies the :type of any enumerable association (e.g. a has_many association), but made no attempt to do so for non-enumerables (e.g. a has_one association). We must specify the :type of any STI association. A has_one association to a class which uses single-table inheritance is an example of this type of association. Fixes #7471 | |||||
* | Merge pull request #7282 from xHire/validates_length_of_fix | Rafael Mendonça França | 2012-11-26 | 3 | -2/+57 | |
|\ | | | | | | | | | | | | | Length validation handles correctly nil. Fix #7180 Conflicts: activemodel/CHANGELOG.md | |||||
| * | Length validation handles correctly nil. Fix #7180 | Michal Zima | 2012-11-26 | 3 | -2/+57 | |
| | | | | | | | | When nil or empty string are not allowed, they are not valid. | |||||
* | | Merge pull request #8320 from senny/active_model_log_folder | Carlos Antonio da Silva | 2012-11-26 | 1 | -0/+1 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Log output from activemodel's railtie_test directly to STDOUT. There's no logging going on here, but since we initialize the app, the logger is set and the folder is automatically created. With this change, the default logger is not created, so there is no logging folder anymore. Conflicts: activemodel/test/cases/railtie_test.rb | |||||
| * | | log output from activemodel's railtie_test directly to STDOUT | Yves Senn | 2012-11-26 | 1 | -0/+1 | |
| |/ | | | | | | | | | after this patch, running the tests in activemodel will no longer create an untracked log/ folder inside of activemodel | |||||
* | | Merge pull request #8312 from ↵ | Rafael Mendonça França | 2012-11-26 | 9 | -21/+14 | |
|\ \ | | | | | | | | | | | | | senny/make_active_model_parts_individually_loadable make sure that individual parts `ActiveModel` can be required by itself | |||||
| * | | cleanup, removed dispensable `require` statements from `ActiveModel` | Yves Senn | 2012-11-25 | 8 | -12/+5 | |
| | | | ||||||
| * | | cleanup, remove broken whitespace | Yves Senn | 2012-11-25 | 4 | -9/+9 | |
| |/ | ||||||
* / | Require active_model/railtie directly instead of rails/all | Carlos Antonio da Silva | 2012-11-26 | 1 | -3/+3 | |
|/ | | | | Use Class.new with a block instead of tap to configure it. | |||||
* | Use secure password min cost option in its own tests for a speed up | Carlos Antonio da Silva | 2012-11-21 | 1 | -2/+10 | |
| | | | | Around 0.564359s => 0.092244s speed up in my machine. | |||||
* | Merge pull request #8256 from nalwayaabhishek/master | Carlos Antonio da Silva | 2012-11-19 | 1 | -3/+3 | |
|\ | | | | | Displaying error message if validation fail in examples (p tag was missing) | |||||
| * | displaying error message(p tag was missing) and adding output as comment | Abhishek Nalwaya | 2012-11-19 | 1 | -3/+3 | |
| | | ||||||
* | | Point user to strong_parameters as the new protection model [ci skip] | Saulius Grigaliunas | 2012-11-18 | 1 | -4/+6 | |
|/ | ||||||
* | Initialize #min_cost to avoid warning in Ruby 2.0 | Carlos Antonio da Silva | 2012-11-17 | 1 | -2/+3 | |
| | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-17 | 1 | -0/+4 | |
|\ | | | | | | | | | Conflicts: actionpack/lib/action_dispatch/routing/redirection.rb | |||||
| * | add details on password confirmation used with has_secure_password | Daniel Lopes | 2012-11-13 | 1 | -0/+4 | |
| | | ||||||
* | | Use BCrypt's MIN_COST in the test environment for speedier tests | Trevor Turk | 2012-11-14 | 5 | -2/+52 | |
| | | ||||||
* | | Trivial documentation fix for ActiveModel::Naming comment. | Dennis Taylor | 2012-11-09 | 1 | -2/+2 | |
| | | ||||||
* | | rm dead code | Aaron Patterson | 2012-11-09 | 1 | -1/+1 | |
| | | ||||||
* | | Clean up gemspecs | Vinny Diehl | 2012-11-08 | 1 | -6/+8 | |
| | | | | | | | | | | | | | | | | | | | | Organized the gemspec files a bit. * Made quotes more consistent (single quotes dominated, so I used that). * Moved license line down a line, separating it logically, and removed the extra whitespace before its = operator. * Minor whitespace fixes. | |||||
* | | use Array() instead flatten | Vasiliy Ermolovich | 2012-11-05 | 3 | -23/+41 | |
| | | | | | | | | | | * move ActiveModel::Errors tests to errors_test.rb * add spec coverage for add_on_empty and add_on_blank | |||||
* | | Raise ArgumentError when no attribute is given to AMo::EachValidator | Carlos Antonio da Silva | 2012-11-04 | 2 | -2/+2 | |
| | | | | | | | | ArgumentError is better suited than RuntimeError for this. | |||||
* | | Set hash value instead of using merge! | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-03 | 14 | -56/+48 | |
|\ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md | |||||
| * | minor edits and remove mixed titles in AM::Validations docs [ci skip] | Francesco Rodriguez | 2012-10-25 | 9 | -21/+13 | |
| | | ||||||
| * | fix output messages - docs [ci skip] | Francesco Rodriguez | 2012-10-22 | 1 | -16/+16 | |
| | | ||||||
| * | convert comments to 1.9 hash syntax | AvnerCohen | 2012-10-22 | 5 | -30/+30 | |
| | | ||||||
* | | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 2 | -2/+2 | |
| | | ||||||
* | | Add test for code change introduced in this commit f20032f | Cédric FABIANSKI | 2012-10-29 | 1 | -0/+9 | |
| | | ||||||
* | | Provide a call stack for deprecation warnings where needed. | Nikita Afanasenko | 2012-10-29 | 2 | -7/+6 | |
| | | | | | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly. | |||||
* | | fix failing isolated tests | Francesco Rodriguez | 2012-10-26 | 1 | -0/+1 | |
| | | ||||||
* | | fix AM::Serializers titles [ci skip] | Francesco Rodriguez | 2012-10-26 | 2 | -2/+2 | |
| | | ||||||
* | | AM::Serializers::Xml depends on AM::Naming | Francesco Rodriguez | 2012-10-26 | 4 | -4/+4 | |
|/ | ||||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-10-21 | 24 | -36/+62 | |
|\ | | | | | | | | | | | Conflicts: activesupport/lib/active_support/core_ext/hash/slice.rb guides/source/active_support_core_extensions.md | |||||
| * | minor edits in AM documentation [ci skip] | Francesco Rodriguez | 2012-10-21 | 22 | -32/+32 | |
| | | ||||||
| * | include serializers in ActiveModel::Serialization example | Hrvoje Šimić | 2012-10-19 | 1 | -0/+12 | |
| | | ||||||
| * | better examples in ActiveModel readme | Hrvoje Šimić | 2012-10-19 | 1 | -1/+15 | |
| | | ||||||
| * | remove non-breaking spaces [ci skip] | Francesco Rodriguez | 2012-10-18 | 1 | -3/+3 | |
| | | ||||||
* | | add credit to committer of pull request #6569 | Jan Berdajs | 2012-10-18 | 1 | -1/+1 | |
| | | ||||||
* | | active_model/validations requires necessary files to run | Yves Senn | 2012-10-18 | 1 | -0/+1 | |
| | | ||||||
* | | cleanup, replace non-breaking spaces with spaces | Yves Senn | 2012-10-18 | 1 | -5/+5 | |
| | |