aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
* update bin/test scripts to prevent double runs.Yves Senn2016-11-211-2/+0
| | | | | The test runner was updated to make use of autorun. This caused the `bin/test` scripts to run Minitest twice.
* Do not rely on Ruby implementation in AM testKir Shatrov2016-11-191-3/+3
| | | | | | | | | | | | Now a few tests in ActiveModel rely on Ruby implementation and the fact that in MRI `97.18` as a float is greater than `97.18` as a BigDecimal. This is only relevant for MRI. On JRuby, comparing float to BigDecimal would be conversion of them to the same type and they will be equal. I'd like the ActiveModel test suite to be Ruby implementation-agnostic. Here we test ActiveModel, not the Ruby internals. This PR fixes a couple more JRuby tests.
* Merge pull request #26905 from bogdanvlviv/docsAndrew White2016-11-133-4/+4
|\ | | | | Add missing `+` around a some literals.
| * Add missing `+` around a some literals.bogdanvlviv2016-10-273-4/+4
| | | | | | | | | | | | Mainly around `nil` [ci skip]
* | Merge pull request #26935 from y-yagi/fix_ruby_warningAndrew White2016-10-311-1/+1
|\ \ | | | | | | remove warning from big integer test
| * | remove warning from big integer testyuuji.yaginuma2016-10-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This removes the following warnings. ``` activemodel/test/cases/type/big_integer_test.rb:15: warning: ambiguous first argument; put parentheses or a space even after `-' operator ```
* | | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-2918-65/+65
|/ /
* | removes requires already present in active_support/railsXavier Noria2016-10-271-1/+0
| |
* | let Regexp#match? be globally availableXavier Noria2016-10-273-3/+0
|/ | | | | | Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation.
* Missing require extract_optionsAkira Matsuda2016-10-251-0/+2
|
* Merge pull request #26790 from iainbeeston/type-tests-in-their-own-filesRafael França2016-10-2213-168/+266
|\ | | | | Refactored ActiveModel::Type tests into their own files
| * Refactored ActiveModel::Type tests into their own filesIain Beeston2016-10-1513-168/+266
| |
* | Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-10-201-1/+1
|\ \ | |/ |/|
| * Corrected comments referring to ActiveModel::AttributesIain Beeston2016-10-031-1/+1
| | | | | | | | Should be ActiveRecord::Attributes (ActiveModel::Attributes does not exist)
* | Removed deprecated :tokenizer in the length validatorRafael Mendonça França2016-10-104-74/+5
| |
* | Removed deprecated methods in ActiveModel::ErrorsRafael Mendonça França2016-10-103-179/+6
| | | | | | | | `#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
* | Merge pull request #24571 from raimo/patch-1Sean Griffin2016-10-041-0/+9
|\ \ | |/ |/| Print the proper ::Float::INFINITY value when used as a default value
| * Print the proper ::Float::INFINITY value when used as a default valueRaimo Tuisku2016-05-231-0/+9
| | | | | | | | Addresses https://github.com/rails/rails/issues/22396
* | Do not leak the Errors default proc when calling to_hash or as_jsonJean Boussier2016-09-272-1/+11
| |
* | [ci skip] Fix bad examples in rdocAndrey Molchanov2016-09-171-2/+11
| |
* | Merge pull request #26516 from grosser/grosser/assertRafael França2016-09-165-25/+25
|\ \ | | | | | | improve error message when include assertions fail
| * | improve error message when include assertions failMichael Grosser2016-09-165-25/+25
| | | | | | | | | | | | | | | | | | assert [1, 3].includes?(2) fails with unhelpful "Asserting failed" message assert_includes [1, 3], 2 fails with "Expected [1, 3] to include 2" which makes it easier to debug and more obvious what went wrong
* | | Update ActiveModel::Dirty Doc [ci skip]Louis-Michel Couture2016-09-161-8/+8
|/ /
* | Update ActiveModel::Dirty Doc [ci skip]Louis-Michel Couture2016-09-151-1/+1
| | | | | | Fix potentially misleading example.
* | Fix broken comments indentation caused by rubocop auto-correct [ci skip]Ryuta Kamizono2016-09-144-7/+7
| | | | | | | | | | | | All indentation was normalized by rubocop auto-correct at 80e66cc4d90bf8c15d1a5f6e3152e90147f00772. But comments was still kept absolute position. This commit aligns comments with method definitions for consistency.
* | Fix Remaining Case-In-Assignment Statement FormattingAlex Kitchens2016-09-061-12/+13
| | | | | | | | | | | | | | | | | | Recently, the Rails team made an effort to keep the source code consistent, using Ruboco (bb1ecdcc677bf6e68e0252505509c089619b5b90 and below). Some of the case statements were missed. This changes the case statements' formatting and is consistent with changes in 810dff7c9fa9b2a38eb1560ce0378d760529ee6b and db63406cb007ab3756d2a96d2e0b5d4e777f8231.
* | apply case-in-assignment patternXavier Noria2016-09-022-11/+13
| |
* | RuboCop is 100% green :tada:Xavier Noria2016-09-022-2/+2
| |
* | fixes remaining RuboCop issues [Vipul A M, Xavier Noria]Xavier Noria2016-09-011-1/+1
| |
* | validate_each in NumericalityValidator is never called in this case.Guillermo Iguaran2016-08-281-2/+0
| | | | | | | | | | NumericalityValidator#validate_each is never called when allow_nil is true and the value is nil because it is already skipped in EachValidator#validate.
* | Add test for allow_blank in numericality validationNicolai Reuschling2016-08-281-0/+7
| | | | | | | | Signed-off-by: Guillermo Iguaran <guilleiguaran@gmail.com>
* | Fix typo in deprecation messageGeorg Ledermann2016-08-271-1/+1
| | | | | | This fixes a copy-and-paste-issue slipped in by #18996
* | Add three new rubocop rulesRafael Mendonça França2016-08-1611-60/+60
| | | | | | | | | | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* | prefer __dir__ over __FILE__ in File.expand_pathXavier Noria2016-08-111-1/+3
| | | | | | | | | | | | Thinking .. relative to files is not natural, we are used to think "parent of a directory", and we have __dir__ nowadays.
* | Fix broken alignments caused by auto-correct commit 411ccbdRyuta Kamizono2016-08-102-2/+4
| | | | | | | | Hash syntax auto-correcting breaks alignments. 411ccbdab2608c62aabdb320d52cb02d446bb39c
* | code gardening: removes redundant selfsXavier Noria2016-08-085-22/+22
| | | | | | | | | | | | | | | | | | A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
* | revises most Lint/EndAlignment offensesXavier Noria2016-08-071-5/+5
| | | | | | | | Some case expressions remain, need to think about those ones.
* | Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-072-2/+0
| |
* | applies remaining conventions across the projectXavier Noria2016-08-0627-37/+9
| |
* | normalizes indentation and whitespace across the projectXavier Noria2016-08-0635-340/+339
| |
* | remove redundant curlies from hash argumentsXavier Noria2016-08-064-11/+7
| |
* | modernizes hash syntax in activemodelXavier Noria2016-08-064-7/+7
| |
* | applies new string literal convention to the rest of the projectXavier Noria2016-08-061-2/+2
| | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* | applies new string literal convention in the gemspecsXavier Noria2016-08-061-12/+12
| | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* | applies new string literal convention in activemodel/testXavier Noria2016-08-0638-563/+563
| | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* | applies new string literal convention in activemodel/libXavier Noria2016-08-0628-77/+77
| | | | | | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* | use \A and \z when you mean \A and \zXavier Noria2016-07-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | In Ruby ^ and $ mean start and end of *line*. A regexp that validates an email should not check if some line of the string looks like an email, and maybe be surrounded by the entire Joyce's Ulysses. What the regexp has to check is if the string itself looks like an email. This validator is used only in tests, the ^/$ anchors implied no risk.
* | systematic revision of =~ usage in AMoXavier Noria2016-07-244-7/+11
| |
* | [ci skip] add class level documentation to ActiveModel::Type::BooleanDavid Elliott2016-07-111-2/+13
| | | | | | | | add documentation of the behaviors of type coercion at the class level
* | Merge pull request #25364 from kamipo/fix_serialize_for_date_typeRafael França2016-06-281-0/+4
|\ \ | | | | | | Fix `Type::Date#serialize` to return a date object correctly
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-30 05:34:15 +0000