Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Don't expose these new APIs yet (added in 877ea78 / #16189) | Godfrey Chan | 2014-08-16 | 1 | -14/+15 | |
| | | | | | | | | | | | | | | | | | | | | | WARNING: don't use them! They might change or go away between future beta/RC/ patch releases! Also added a CHANGELOG entry for this. | |||||
* | | | Implement `_was` and `changes` for in-place mutations of AR attributes | Sean Griffin | 2014-08-16 | 1 | -3/+16 | |
| | | | ||||||
* | | | AM, AP, AV, and AMo tests are already order_independent! | Akira Matsuda | 2014-08-13 | 1 | -5/+0 | |
| | | | ||||||
* | | | Nobody sucks so nobody should call this awful method name | Rafael Mendonça França | 2014-08-12 | 1 | -1/+1 | |
| | | | ||||||
* | | | users_dont_suck_but_only_we_suck_and_only_our_tests_are_order_dependent! | Akira Matsuda | 2014-08-12 | 1 | -0/+5 | |
| | | | | | | | | | | | | | | | Calling ActiveSupport::TestCase.i_suck_and_my_tests_are_order_dependent! in AS::TestCase makes everyone's tests order dependent, which should never be done by the framework. | |||||
* | | | Fix typo [ci skip] | Carlos Antonio da Silva | 2014-08-07 | 1 | -1/+1 | |
| | | | ||||||
* | | | Allow password to contain spaces only. | Yevhene Shemet | 2014-08-06 | 3 | -2/+18 | |
| |/ |/| | ||||||
* | | Call public methods rather than class_eval'ing | Carlos Antonio da Silva | 2014-08-05 | 1 | -4/+2 | |
| | | ||||||
* | | Merge pull request #15959 from aditya-kapoor/remove-unneeded-cases | Rafael Mendonça França | 2014-07-29 | 2 | -26/+17 | |
|\ \ | | | | | | | remove unneeded test model for ActiveModel test cases. | |||||
| * | | remove unneeded test model for ActiveModel test cases. | Aditya Kapoor | 2014-06-28 | 2 | -26/+17 | |
| | | | ||||||
* | | | Fix example code of `EachValidator` [ci skip] | Chun-wei Kuo | 2014-07-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | We have to specify the `:title` option to really use the `TitleValidator` defined above. | |||||
* | | | Merge branch 'rm-remove-mocha' | Rafael Mendonça França | 2014-07-19 | 1 | -0/+2 | |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: actionpack/test/abstract_unit.rb | |||||
| * | | | Stop requiring mocha automatically | Rafael Mendonça França | 2014-07-19 | 1 | -0/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are planning to remove mocha from our test suite because of performance problems. To make this possible we should stop require mocha on ActionSupport::TestCase. This should not affect applications since users still need to add mocha to Gemfile and this already load mocha. Added FIXME notes to place that still need mocha removal | |||||
* | | | | %i doesn't work on 1.9 | Aaron Patterson | 2014-07-17 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #16210 from sonnym/assert_valid_keys_in_validate | Matthew Draper | 2014-07-18 | 3 | -0/+19 | |
|\ \ \ \ | | | | | | | | | | | | | | | | Check for valid options in validate method | |||||
| * | | | | check for valid options in validate method | sonnym | 2014-07-17 | 3 | -0/+18 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change prevents a certain class of user error which results when mistakenly using the `validate` class method instead of the `validates` class method. Only apply when all arguments are symbols, because some validations use the `validate` method and pass in additional options, namely the `LenghValidator` via the `ActiveMode::Validations::validates_with` method. | |||||
* | | | | Make restore_attributes public | Rafael Mendonça França | 2014-07-17 | 2 | -10/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make it accept a list of attributes to be changed. This will make possible to restore only a subset of the changed attributes. Closes #16203 | |||||
* | | | | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`. | Rafael Mendonça França | 2014-07-15 | 3 | -9/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods. | |||||
* | | | | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵ | Rafael Mendonça França | 2014-07-15 | 3 | -4/+40 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes. | |||||
* | | | | [ci skip] Little bit doc code improvement. | Santosh Wadghule | 2014-07-14 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Only automatically include validations when enabled | Godfrey Chan | 2014-07-02 | 2 | -12/+5 | |
| | | | | | | | | | | | | This is a follow up to #16024. | |||||
* | | | automatically include ActiveModel::Validations when include ↵ | Aditya Kapoor | 2014-07-03 | 4 | -2/+6 | |
| | | | | | | | | | | | | ActiveModel::SecurePassword | |||||
* | | | Silence warning emitted in tests | Sean Griffin | 2014-07-01 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | The instance method `model_name` was being defined multiple times, causing a redefinition warning. | |||||
* | | | Rename rollback_changes to undo_changes | Rafael Mendonça França | 2014-06-30 | 3 | -6/+6 | |
| | | | | | | | | | | | | To avoid overload with database rollback | |||||
* | | | Add CHANGELOG entry for #14861 and document private methods on the API | Rafael Mendonça França | 2014-06-30 | 2 | -5/+10 | |
| | | | ||||||
* | | | Merge pull request #14861 from igor04/dirty-rollback | Rafael Mendonça França | 2014-06-30 | 2 | -0/+35 | |
|\ \ \ | |/ / |/| | | | | | Added rollback method to ActiveModel::Dirty | |||||
| * | | Added rollback method to ActiveModel::Dirty | igor04 | 2014-06-23 | 2 | -0/+35 | |
| | | | ||||||
* | | | We are talking about the libraries, not the constants | Sean Griffin | 2014-06-27 | 1 | -3/+3 | |
| | | | ||||||
* | | | Note that `_will_change!` is no longer needed for AR instances | Sean Griffin | 2014-06-27 | 1 | -3/+5 | |
| | | | | | | | | | | | | | | | | | | | | | Leave the note for `ActiveModel`, since it can't yet detect mutations (hopefully we can change this in time for 4.2). However, we now detect mutations on all supported types in `ActiveRecord`, so we can note that `_will_change!` is no longer needed there. | |||||
* | | | Merge pull request #15834 from rmehner/allow_proc_and_symbol_for_only_integer | Rafael Mendonça França | 2014-06-26 | 3 | -1/+32 | |
|\ \ \ | |_|/ |/| | | Allow proc and symbol as values for `only_integer` of `NumericalityValidator` | |||||
| * | | `only_integer` of `NumericalityValidator` now allows procs and symbols | Robin Mehner | 2014-06-22 | 3 | -1/+32 | |
| | | | ||||||
* | | | Merge pull request #15871 from yuki24/add-model-name-instance-method | David Heinemeier Hansson | 2014-06-24 | 2 | -0/+12 | |
|\ \ \ | | | | | | | | | Add #model_name instance method to ActiveModel::Naming | |||||
| * | | | Delegate #model_name method to self.class | Yuki Nishijima | 2014-06-22 | 2 | -0/+12 | |
| |/ / | ||||||
* / / | remove unnecessary require for json serialization test cases | Aditya Kapoor | 2014-06-24 | 1 | -1/+0 | |
|/ / | ||||||
* | | :scissors: and :nail_care: from d60c405 [ci skip] | Zachary Scott | 2014-06-16 | 1 | -3/+3 | |
| | | ||||||
* | | [ci skip] correct doc for serialization in accordance with API Doc Guide | Aditya Kapoor | 2014-06-16 | 1 | -11/+11 | |
| | | ||||||
* | | Correct typo, add test for validates_absence_of, correct method names | Akshay Vishnoi | 2014-06-16 | 1 | -3/+4 | |
| | | ||||||
* | | Edit pass on `has_secure_password` documentation [ci skip] | Godfrey Chan | 2014-06-14 | 1 | -5/+6 | |
| | | ||||||
* | | [ci skip] Update #has_secure_password docs | Akshay Vishnoi | 2014-06-14 | 1 | -6/+9 | |
| | | ||||||
* | | Use `@existing_user` while updating existing user, fixing - #ee4e86 | Akshay Vishnoi | 2014-06-14 | 1 | -6/+6 | |
| | | ||||||
* | | Cleaned up the `has_secure_password` test cases | Godfrey Chan | 2014-06-14 | 1 | -33/+29 | |
| | | | | | | | | | | | | * Grouped the valid test cases in one place * Make the length of the generated password obvious * Removed two wrong (copy-and-pasted) test cases | |||||
* | | Added changelog for #15708 [ci skip] | Godfrey Chan | 2014-06-14 | 1 | -0/+7 | |
| | | ||||||
* | | SecurePassword - Validate password must be less than or equal to 72 | Akshay Vishnoi | 2014-06-14 | 2 | -0/+34 | |
| | | | | | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters. | |||||
* | | Merge pull request #15690 from deeeki/activemodel_model_doc | Arthur Nogueira Neves | 2014-06-13 | 1 | -3/+3 | |
|\ \ | | | | | | | [ci skip] Clarify ActiveModel::Model docs | |||||
| * | | [ci skip] Clarify ActiveModel::Model docs | deeeki | 2014-06-14 | 1 | -3/+3 | |
| | | | | | | | | | | | | ActiveModel attributes initialized with String return String values | |||||
* | | | [ci skip] correct docs for conversion | Aditya Kapoor | 2014-06-11 | 1 | -5/+12 | |
|/ / | ||||||
* | | [ci skip] add tests for ActionModel::Conversion | Aditya Kapoor | 2014-06-11 | 1 | -0/+4 | |
| | | ||||||
* | | fix typo in changelog [ci skip] | Vijay Dev | 2014-06-11 | 1 | -1/+1 | |
| | | ||||||
* | | Merge pull request #15635 from kuldeepaggarwal/add-missing-changelog | Yves Senn | 2014-06-11 | 1 | -0/+6 | |
|\ \ | | | | | | | | | | add missing changelog entry. refer [#16db90d] [ci skip] | |||||
| * | | add missing changelog entry. refer [#16db90d] [ci skip] | Kuldeep Aggarwal | 2014-06-11 | 1 | -0/+4 | |
|/ / |