aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel
Commit message (Collapse)AuthorAgeFilesLines
* no callbacks should be created for empty array [#5289 state:resolved]Subba Rao Pasupuleti2010-08-122-3/+20
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* tidy up validations length code [#5297 state:resolved]Subba Rao Pasupuleti2010-08-121-6/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add missing ActiveModel::Validations requireGreg Campbell2010-08-122-1/+1
| | | | | | | | | | | [#5311 state: resolved] ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport. (This wasn't showing up in the tests, because it was required in the helper, and was also required in ActiveModel::Serialization). Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'docrails/master'Xavier Noria2010-08-122-10/+10
|\
| * applied guidelines to "# =>"Paco Guzman2010-08-121-7/+7
| |
| * ActiveModel::Base doesn't exist, include_root_in_json is a class_attribute ↵Santiago Pastorino2010-08-101-3/+3
| | | | | | | | for the classes which includes this module
* | fixes a typo reported by rymaiXavier Noria2010-08-101-1/+1
|/
* typo in AMAdam Meehan2010-08-091-1/+1
|
* edit pass to AMo::Serializers::JSONXavier Noria2010-08-061-9/+9
|
* Merge remote branch 'docrails/master'Xavier Noria2010-08-052-2/+4
|\
| * adding documentation to ActiveSupport::Concern ht:strictly typed for an ↵Neeraj Singh2010-08-041-0/+2
| | | | | | | | | | | | awesome example some minor documentation changes
| * fixing documentationNeeraj Singh2010-08-031-2/+2
| |
* | Tidy up error.rb codeSubba Rao Pasupuleti2010-08-031-5/+1
| | | | | | | | | | | | [#5288 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* | Freeze options so we raise an error when people modify it in place.José Valim2010-08-032-3/+5
| |
* | validates_length_of should not change the options hash in place. [#5283 ↵José Valim2010-08-031-4/+7
| | | | | | | | state:resolved]
* | Failing test for validates_length_of, when both too_short and too_long ↵rohit2010-08-031-0/+14
| | | | | | | | | | | | messages are set [#5283 state:open] Signed-off-by: José Valim <jose.valim@gmail.com>
* | Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵Tore Darell2010-08-032-12/+87
| | | | | | | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* | adding test cases for ActiveModel::ErrorsNeeraj Singh2010-08-031-0/+65
|/ | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 ↵Alex Le2010-08-023-6/+22
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'rails/master'Xavier Noria2010-07-308-32/+31
|\
| * edit pass to apply API guideline wrt the use of "# =>" in example codeXavier Noria2010-07-306-30/+29
| |
| * Prep for RCDavid Heinemeier Hansson2010-07-262-2/+2
| |
* | expanding on the will_change! method in documentationNeeraj Singh2010-07-291-1/+4
|/
* Merge remote branch 'docrails/master'Xavier Noria2010-07-261-73/+51
|\
| * improve Active Model READMEMislav Marohnić2010-07-221-73/+51
| | | | | | | | | | | | | | - fix indentation problems - revised introductory text to state right away what the library is - improved examples: reduce heavy usage of ellipsis, don't mark paragraphs of text as code
* | update Rakefiles for RDoc 2.5Aaron Patterson2010-07-231-4/+4
| |
* | Makes Rakefile activate rdoc >= 2.5.9Santiago Pastorino2010-07-231-1/+1
|/ | | | Signed-off-by: Xavier Noria <fxn@hashref.com>
* replacing around with for in the comments for callbacksNeeraj Singh2010-07-221-1/+1
|
* Change some missing README -> README.rdocSantiago Pastorino2010-07-221-1/+1
|
* Reuse already existing classes for ActiveModel tests.José Valim2010-07-214-63/+44
|
* Add .rdoc extension to README files.José Valim2010-07-212-1/+1
|
* Moved a few methods from RecordIdentifier to ActiveModel::NamingPiotr Sarnacki2010-07-212-0/+92
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add missing entries and tidy up CHANGELOG.José Valim2010-07-191-0/+5
|
* adding proper markup to commentNeeraj Singh2010-07-161-2/+2
|
* Add missing require to use SetSantiago Pastorino2010-07-111-1/+2
|
* Avoid interpreted as grouped expression warningsSantiago Pastorino2010-07-112-4/+4
|
* Improve a bit the code in latest commits.José Valim2010-07-081-1/+2
|
* Removing method before redefining it. It was causing warnings. [#5072 ↵Łukasz Strzałkowski2010-07-081-0/+1
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Change documentation for ActiveModel::MassAssignmentSecurity a bit and make ↵José Valim2010-07-083-47/+54
| | | | debug always be called since some people may overwrite warn! to add extra behavior even if logger is not available.
* mass_assignment_security moved from AR to AMo, and minor test cleanupJosh Kalderimis2010-07-0810-0/+448
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add a missing require to allow the usage of Array#to_xmlSantiago Pastorino2010-07-031-0/+1
|
* Missing BigDecimal dependencyJeremy Kemper2010-06-271-0/+2
|
* Move constantize from conversions to inflections.Santiago Pastorino2010-06-261-1/+0
| | | | | | | | This removes ActiveModel dependency on TZInfo. [#4979 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* Work around the fact the JSON gem was overwriting to_json implementation for ↵José Valim2010-06-263-17/+23
| | | | | | | all Ruby core classes. This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized. So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved]
* Regression with how base errors messages are added to a model. Works ↵Josh Kalderimis2010-06-233-5/+20
| | | | | | correctly for both string error messages and symbol translated messages. Signed-off-by: José Valim <jose.valim@gmail.com>
* should be able to run ActiveModel validations_test [#4933 state:resolved]Neeraj Singh2010-06-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Avoid method redefined warningSantiago Pastorino2010-06-221-1/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Refactor previous commit a bit [#4057 state:resolved]José Valim2010-06-217-16/+16
|
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-06-2111-411/+279
| | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'rails/master'Xavier Noria2010-06-204-2/+146
|\ | | | | | | | | Conflicts: actionpack/lib/abstract_controller/base.rb