Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Avoid define_method if possible. | José Valim | 2011-04-19 | 1 | -12/+39 |
| | |||||
* | bcrypt will encrypt anything, so validate_presence_of would not catch nil / ↵ | Aaron Patterson | 2011-04-14 | 2 | -1/+15 |
| | | | | blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this | ||||
* | Declaring the attr_accessor for password_confirmation is not necessary | Brian Cardarella | 2011-04-14 | 1 | -2/+1 |
| | | | | as the confirmation validation already adds that attr_accessor | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-04-12 | 1 | -1/+1 |
|\ | |||||
| * | Rewording | Oge Nnadi | 2011-04-11 | 1 | -1/+1 |
| | | |||||
* | | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | | | | | suggestion! | ||||
* | | Remove code duplication. | José Valim | 2011-04-11 | 3 | -20/+27 |
| | | |||||
* | | No need to rescue here. Invoking the wrong method in an object can happen ↵ | José Valim | 2011-04-11 | 6 | -40/+0 |
| | | | | | | | | anywhere if you are not careful. In other words, test your shit. | ||||
* | | Revert "Add :use_include option to allow user to explicitly use ↵ | José Valim | 2011-04-11 | 4 | -37/+14 |
| | | | | | | | | | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67. | ||||
* | | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 2 | -2/+4 |
| | | | | | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | | Add :use_include option to allow user to explicitly use `Range#include?` ↵ | Prem Sichanugrist | 2011-04-10 | 4 | -14/+37 |
| | | | | | | | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option. | ||||
* | | Add support for proc or lambda as an option for InclusionValidator, ↵ | Prem Sichanugrist | 2011-04-10 | 7 | -20/+167 |
| | | | | | | | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator | ||||
* | | Rename test directory to match code directory | John Firebaugh | 2011-04-06 | 2 | -0/+0 |
|/ | | | | Hopefully "serializeration" is not an in joke that I missed. | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-04-03 | 1 | -11/+10 |
|\ | |||||
| * | Fix formatting and broken markup | John Firebaugh | 2011-03-28 | 1 | -11/+10 |
| | | |||||
* | | Gem::Specification#has_rdoc= is deprecated since rubygems 1.7.0 | Santiago Pastorino | 2011-04-02 | 1 | -2/+0 |
| | | |||||
* | | Bring back AMo#i18n_key method | Santiago Pastorino | 2011-03-30 | 3 | -8/+13 |
|/ | |||||
* | use class_eval with a string when it's possible | Santiago Pastorino | 2011-03-22 | 1 | -2/+8 |
| | |||||
* | Do not in place modify what table_name returns | Santiago Pastorino | 2011-03-22 | 2 | -12/+1 |
| | |||||
* | define_attr_method should be able to define methods that returns nil | Santiago Pastorino | 2011-03-17 | 2 | -2/+4 |
| | |||||
* | remove misleading comment | Aaron Patterson | 2011-03-17 | 1 | -2/+0 |
| | |||||
* | dup strings on return so that in place modifications do not break anything. ↵ | Aaron Patterson | 2011-03-17 | 2 | -1/+12 |
| | | | | I am looking at you "compute_table_name" | ||||
* | define_attr_method correctly defines methods with invalid identifiers | Santiago Pastorino | 2011-03-16 | 2 | -5/+6 |
| | |||||
* | Add a define_attr_method test | Santiago Pastorino | 2011-03-16 | 1 | -0/+13 |
| | |||||
* | Add test for define_attr_method using as name an invalid identifier | Santiago Pastorino | 2011-03-16 | 1 | -0/+13 |
| | |||||
* | Add test for define_attribute_method using as name an invalid identifier | Santiago Pastorino | 2011-03-16 | 1 | -3/+26 |
| | |||||
* | Fix typo in assertion message | Andrew White | 2011-03-16 | 1 | -1/+1 |
| | |||||
* | Add messages to plain assertions. | Norman Clarke | 2011-03-15 | 1 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Refactor length validation | Santiago Pastorino | 2011-03-12 | 2 | -6/+6 |
| | |||||
* | length validation for fixnums | Andriy Tyurnikov | 2011-03-12 | 2 | -1/+13 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Add additional text to NotImplementedErrors [#6328 state:resolved] | Mike Gehard | 2011-03-12 | 1 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-03-07 | 5 | -25/+18 |
|\ | |||||
| * | formatting changes | Vijay Dev | 2011-03-07 | 2 | -15/+14 |
| | | |||||
| * | Configuration options are symbols | Paco Guzman | 2011-03-06 | 1 | -2/+2 |
| | | |||||
| * | Remove Example headers. Code just flows with the text. 6ce844a3 | Paco Guzman | 2011-03-06 | 3 | -8/+2 |
| | | |||||
* | | remove unused assigned variable | Paco Guzman | 2011-03-06 | 1 | -1/+1 |
|/ | |||||
* | Active Model typos. | R.T. Lechow | 2011-03-05 | 2 | -2/+2 |
| | |||||
* | Move ActiveModel::AttributeMethods#attribute_methods_generated? to ↵ | Alexander Uvarov | 2011-03-01 | 3 | -28/+28 |
| | | | | | | | | ActiveRecord, so it's flexible now [#6428 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]" | Santiago Pastorino | 2011-02-27 | 5 | -37/+8 |
| | | | | | | | This breaks #6448, you should use :"module/class" as key for namespacing [#6448 state:committed] This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557. | ||||
* | failing test for i18n key collision with namespaced models | Santiago Pastorino | 2011-02-27 | 2 | -0/+11 |
| | |||||
* | We're in 2011, let's update our license | Prem Sichanugrist | 2011-02-22 | 2 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-02-21 | 11 | -12/+52 |
|\ | |||||
| * | copy-edits 8d96b89 | Xavier Noria | 2011-02-21 | 9 | -11/+26 |
| | | |||||
| * | copy-edits 6d7a826 | Xavier Noria | 2011-02-21 | 1 | -3/+3 |
| | | |||||
| * | copy-edits 34316d8 | Xavier Noria | 2011-02-21 | 1 | -7/+5 |
| | | |||||
| * | Docs: Update to_xml documentation to match as_json docuemntation | Nicholas Rowe | 2011-02-20 | 1 | -0/+25 |
| | | |||||
| * | Documentation: Added small comments to Observering module | Nicholas Rowe | 2011-02-20 | 1 | -0/+3 |
| | | |||||
| * | Clarification of ActiveRecord ActiveModel validation documentation | Peer Allan | 2011-02-18 | 7 | -9/+8 |
| | | |||||
* | | documents the backported Range#cover?, and related stuff | Xavier Noria | 2011-02-20 | 1 | -3/+5 |
| | |