Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix ActiveModel::Errors#dup | Paweł Kondzior | 2012-01-16 | 2 | -1/+22 |
| | | | | | | | | | | | | Since ActiveModel::Errors instance keeps all error messages as hash we should duplicate this object as well. Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash, which results in different behavior on dup, this may result in regression for people relying on it. Because Rails 3.2 stills supports Ruby 1.8.7 in order to properly fix this regression we need to backport #initialize_dup. | ||||
* | Apparently asssert_empty is not available in 1.8.7 | Piotr Sarnacki | 2012-01-16 | 1 | -1/+1 |
| | |||||
* | Add ActiveModel::Errors#delete, which was not available after move to use ↵ | Piotr Sarnacki | 2012-01-16 | 2 | -0/+12 |
| | | | | delegation | ||||
* | Fix stack level too deep when model does not have attributes method. | Piotr Sarnacki | 2012-01-15 | 2 | -1/+9 |
| | | | | | | | | | | | Without that patch when using ActiveModel::AttributeMethods in a class that does not respond to `attributes` method, stack level too deep error will be raised on non existing method. While documentation is clear that you need to define `attributes` method in order to use AttributeMethods module, `stack level too deep` is rather obscure and hard to debug, therefore we should try to not break `method_missing` if someone forgets about defining `attributes`. | ||||
* | Bump to rc2 | Santiago Pastorino | 2012-01-04 | 1 | -1/+1 |
| | |||||
* | Remove i18n dependencies from AP and AMo since they are in AS. | José Valim | 2011-12-20 | 1 | -1/+0 |
| | |||||
* | Party like its R-C-UNO! | David Heinemeier Hansson | 2011-12-19 | 1 | -1/+1 |
| | |||||
* | Fixed test "ArgumentError: wrong number of arguments(1 for 0)" | Arun Agrawal | 2011-12-17 | 1 | -1/+1 |
| | |||||
* | Fixed bug when error message is an empty string. | Antonio Roberto | 2011-12-16 | 2 | -1/+8 |
| | |||||
* | Improve cache on route_key lookup. | José Valim | 2011-12-08 | 2 | -2/+31 |
| | |||||
* | Ensure length validator also works on 1.8.7. | José Valim | 2011-12-06 | 1 | -6/+17 |
| | |||||
* | Merge pull request #3872 from marcandre/i18n_key | José Valim | 2011-12-06 | 2 | -2/+22 |
|\ | | | | | ActiveModel::Name#i18n_key: Fix doc and add tests | ||||
| * | ActiveModel::Name#i18n_key: Fix doc and add tests | Marc-Andre Lafortune | 2011-12-05 | 2 | -2/+22 |
| | | |||||
* | | Merge pull request #3873 from iangreenleaf/no_default_tokenizer | José Valim | 2011-12-06 | 1 | -2/+1 |
|\ \ | |/ |/| | Don't tokenize string when counting characters | ||||
| * | Don't tokenize string when counting characters | Ian Young | 2011-12-04 | 1 | -2/+1 |
| | | |||||
* | | Namespaced attribute lookup now works as 'model/association.attribute'. | José Valim | 2011-12-05 | 2 | -11/+19 |
| | | |||||
* | | Merge pull request #3859 from kuroda/human_attribute_name | José Valim | 2011-12-05 | 2 | -2/+16 |
|\ \ | |/ |/| | Fix human_attribute_name to handle names with dots | ||||
| * | Fix human_attribute_name to handle names with dots | Tsutomu Kuroda | 2011-12-05 | 2 | -2/+16 |
| | | | | | | | | | | | | | | | | Nested I18n namespace lookup under activerecord.models is deprecated now (c19bd4f). But when a model uses accepts_nested_attributes_for, its Errors object can have an attribute name with "addresses.street" style. In this case, the dots should be substituted with slashes so that we can provide the translation under the "activemodel.attributes.person.addresses/street" key. | ||||
* | | Fix argument error message for length validation | Alexey Vakhov | 2011-12-01 | 1 | -1/+1 |
| | | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-11-30 | 2 | -4/+4 |
|\ \ | |||||
| * | | Cosmetic fixes in AM validatations docs | Alexey Vakhov | 2011-11-27 | 2 | -4/+4 |
| | | | |||||
* | | | Revert "Implement ArraySerializer and move old serialization API to a new ↵ | José Valim | 2011-11-30 | 12 | -727/+424 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb | ||||
* | | | fix method redefined warning in activemodel | lest | 2011-11-30 | 2 | -1/+5 |
| | | | |||||
* | | | Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵ | José Valim | 2011-11-30 | 1 | -1/+1 |
| | | | | | | | | | | | | a before callback halts. | ||||
* | | | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 3 | -42/+43 |
| | | | | | | | | | | | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | ||||
* | | | Warning removed unused variable | Arun Agrawal | 2011-11-26 | 1 | -1/+1 |
|/ / | |||||
* | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2011-11-26 | 1 | -1/+1 |
|\ \ | |||||
| * | | Small docs fix in Active Model callbacks module | Alexey Vakhov | 2011-11-19 | 1 | -1/+1 |
| | | | |||||
* | | | Revert the serializers API as other alternatives are now also under discussion | José Valim | 2011-11-25 | 4 | -448/+0 |
| | | | |||||
* | | | Merge branch 'serializers' | José Valim | 2011-11-25 | 13 | -425/+1178 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implements the ActiveModel::Serializer object. Includes code, tests, generators and guides. From José and Yehuda with love. Conflicts: railties/CHANGELOG.md | ||||
| * | | | Add docs to serializers. Update CHANGELOGs. | José Valim | 2011-11-25 | 2 | -8/+84 |
| | | | | |||||
| * | | | Rename UserSerializer to DefaultUserSerializer in tests. | José Valim | 2011-11-23 | 1 | -15/+13 |
| | | | | |||||
| * | | | Rely solely on active_model_serializer and remove the fancy constant lookup. | José Valim | 2011-11-23 | 3 | -77/+17 |
| | | | | |||||
| * | | | Implement ArraySerializer and move old serialization API to a new namespace. | José Valim | 2011-11-23 | 12 | -428/+602 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer. | ||||
| * | | | Merge branch 'master' into serializers | José Valim | 2011-11-23 | 18 | -207/+322 |
| |\ \ \ | |||||
| * | | | | Remove 1.9 Hash syntax - tests passing on 1.8.7 | Jose and Yehuda | 2011-10-15 | 1 | -3/+3 |
| | | | | | |||||
| * | | | | Add initial support for embed API | Jose and Yehuda | 2011-10-15 | 2 | -7/+101 |
| | | | | | |||||
| * | | | | Add support for the root attribute | Jose and Yehuda | 2011-10-15 | 2 | -15/+74 |
| | | | | | |||||
| * | | | | Fix nil has_one association | Jose and Yehuda | 2011-10-15 | 2 | -2/+20 |
| | | | | | |||||
| * | | | | Add association_ids | Jose and Yehuda | 2011-10-15 | 2 | -2/+89 |
| | | | | | |||||
| * | | | | Add support for overriding associations, mostly used for authorization | Jose and Yehuda | 2011-10-15 | 2 | -1/+31 |
| | | | | | |||||
| * | | | | Add support for implicit serializers | Jose and Yehuda | 2011-10-15 | 2 | -26/+72 |
| | | | | | |||||
| * | | | | Added has_one and has_many | Jose and Yehuda | 2011-10-15 | 2 | -14/+123 |
| | | | | | |||||
| * | | | | Don't require serializable_hash to take options. | Jose and Yehuda | 2011-10-15 | 2 | -3/+3 |
| | | | | | |||||
| * | | | | Initial implementation of ActiveModel::Serializer | Jose and Yehuda | 2011-10-15 | 3 | -0/+122 |
| | | | | | |||||
* | | | | | make ActiveModel::Name fail gracefully with anonymous classes | Jakub Kuźma | 2011-11-24 | 2 | -0/+16 |
| |/ / / |/| | | | |||||
* | | | | Rely on a public contract between railties instead of accessing railtie ↵ | José Valim | 2011-11-23 | 3 | -21/+49 |
| |/ / |/| | | | | | | | | methods directly. | ||||
* | | | Update variable's name in the test case to reflect the class we're testing | Prem Sichanugrist | 2011-11-18 | 3 | -24/+24 |
| | | | |||||
* | | | Speed up attribute invocation by checking if both name and calls are compilable. | José Valim | 2011-11-14 | 1 | -27/+32 |
| | | | |||||
* | | | use any? instead of !empty? | Oscar Del Ben | 2011-11-14 | 1 | -1/+1 |
| | | |