Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`. | Rafael Mendonça França | 2014-07-15 | 1 | -3/+3 |
| | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods. | ||||
* | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵ | Rafael Mendonça França | 2014-07-15 | 1 | -0/+21 |
| | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes. | ||||
* | Only automatically include validations when enabled | Godfrey Chan | 2014-07-02 | 1 | -11/+3 |
| | | | | This is a follow up to #16024. | ||||
* | automatically include ActiveModel::Validations when include ↵ | Aditya Kapoor | 2014-07-03 | 3 | -2/+5 |
| | | | | ActiveModel::SecurePassword | ||||
* | Rename rollback_changes to undo_changes | Rafael Mendonça França | 2014-06-30 | 1 | -2/+2 |
| | | | | To avoid overload with database rollback | ||||
* | Merge pull request #14861 from igor04/dirty-rollback | Rafael Mendonça França | 2014-06-30 | 1 | -0/+18 |
|\ | | | | | | | Added rollback method to ActiveModel::Dirty | ||||
| * | Added rollback method to ActiveModel::Dirty | igor04 | 2014-06-23 | 1 | -0/+18 |
| | | |||||
* | | Merge pull request #15834 from rmehner/allow_proc_and_symbol_for_only_integer | Rafael Mendonça França | 2014-06-26 | 1 | -0/+15 |
|\ \ | | | | | | | Allow proc and symbol as values for `only_integer` of `NumericalityValidator` | ||||
| * | | `only_integer` of `NumericalityValidator` now allows procs and symbols | Robin Mehner | 2014-06-22 | 1 | -0/+15 |
| | | | |||||
* | | | Merge pull request #15871 from yuki24/add-model-name-instance-method | David Heinemeier Hansson | 2014-06-24 | 1 | -0/+6 |
|\ \ \ | | | | | | | | | Add #model_name instance method to ActiveModel::Naming | ||||
| * | | | Delegate #model_name method to self.class | Yuki Nishijima | 2014-06-22 | 1 | -0/+6 |
| |/ / | |||||
* / / | remove unnecessary require for json serialization test cases | Aditya Kapoor | 2014-06-24 | 1 | -1/+0 |
|/ / | |||||
* | | Correct typo, add test for validates_absence_of, correct method names | Akshay Vishnoi | 2014-06-16 | 1 | -3/+4 |
| | | |||||
* | | Use `@existing_user` while updating existing user, fixing - #ee4e86 | Akshay Vishnoi | 2014-06-14 | 1 | -6/+6 |
| | | |||||
* | | Cleaned up the `has_secure_password` test cases | Godfrey Chan | 2014-06-14 | 1 | -33/+29 |
| | | | | | | | | | | | | * Grouped the valid test cases in one place * Make the length of the generated password obvious * Removed two wrong (copy-and-pasted) test cases | ||||
* | | SecurePassword - Validate password must be less than or equal to 72 | Akshay Vishnoi | 2014-06-14 | 1 | -0/+28 |
| | | | | | | | | See #14591, Reason - BCrypt hash function can handle maximum 72 characters. | ||||
* | | [ci skip] add tests for ActionModel::Conversion | Aditya Kapoor | 2014-06-11 | 1 | -0/+4 |
| | | |||||
* | | remove depricated Validatior#setup | Kuldeep Aggarwal | 2014-06-10 | 1 | -21/+0 |
| | | |||||
* | | Add singular and plural form for some validation messages | Abd ar-Rahman Hamidi | 2014-05-02 | 1 | -3/+15 |
|/ | |||||
* | Fix warning for overshadowing XML variable | Musannif Zahir | 2014-03-28 | 1 | -2/+2 |
| | |||||
* | ActiveRecord/ActiveModel '#validate' alias for 'valid?' | Henrik Nyh | 2014-03-27 | 1 | -0/+9 |
| | | | | | | | | It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies. | ||||
* | comment why we are modifying global state. [ci skip] | Yves Senn | 2014-03-11 | 1 | -0/+1 |
| | |||||
* | Completely remove potential global state leaks in ActiveModel tests. | Zuhao Wan | 2014-03-11 | 7 | -110/+136 |
| | | | | ActiveModel tests can now be run in random order. | ||||
* | Merge pull request #14315 from zuhao/activemodel_tests_in_random_order | Yves Senn | 2014-03-09 | 4 | -13/+39 |
|\ | | | | | Run ActiveModel test suites in random order. | ||||
| * | Run ActiveModel test suites in random order. | Zuhao Wan | 2014-03-10 | 4 | -13/+39 |
| | | | | | | | | | | | | | | | | | | | | This gets the whole ActiveModel test suites working even if `self.i_suck_and_my_tests_are_order_dependent!` is disabled in `ActiveSupport::TestCase`. Two places are found that potentially leak global state. This patch makes sure states are restored so that none of the changes happen in a single test will be carried over to subsequence tests. | ||||
* | | Tests for indifferent access using full_messages_for. Closes #11916 | Pavel Penkov | 2014-03-08 | 1 | -0/+7 |
|/ | |||||
* | Fix some validators when used on model instance | Eric Hutzelman | 2014-02-26 | 2 | -2/+4 |
| | | | | | | | | Now that Validator #setup is called from the initializer, we need a reference to the model's class to be passed in to allow the validators to continue functioning when used at the instance level. Closes #14134. | ||||
* | add test coverage for activemodel Dirty#reset_changes | Dmitry Polushkin | 2014-02-09 | 1 | -0/+19 |
| | |||||
* | `#to_param` returns `nil` if `to_key` returns `nil`. Closes #11399. | Yves Senn | 2014-02-04 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | The documentation of `#to_key` (http://api.rubyonrails.org/classes/ActiveModel/Conversion.html#method-i-to_key) states that it returns `nil` if there are no key attributes. `to_param` needs to be aware of that fact and return `nil` as well. Previously it raised the following exception: ``` 1) Error: ConversionTest#test_to_param_returns_nil_if_to_key_is_nil: NoMethodError: undefined method `join' for nil:NilClass /Users/senny/Projects/rails/activemodel/lib/active_model/conversion.rb:65:in `to_param' /Users/senny/Projects/rails/activemodel/test/cases/conversion_test.rb:34:in `block in <class:ConversionTest>' ``` | ||||
* | use the new clear_validators! api everywhere to reset validators in tests | Kuldeep Aggarwal | 2014-01-28 | 1 | -1/+1 |
| | |||||
* | Use the new clear_validators! api to reset validators in tests | Carlos Antonio da Silva | 2014-01-27 | 16 | -42/+33 |
| | |||||
* | Merge tests about multiple validation contexts | Carlos Antonio da Silva | 2014-01-27 | 1 | -10/+6 |
| | |||||
* | Ability to specify multiple contexts when defining a validation. | Vince Puzzella | 2014-01-27 | 1 | -0/+16 |
| | | | | | | Example: validates_presence_of :name, on: [:update, :custom_validation_context] | ||||
* | Some minor fixes | Godfrey Chan | 2014-01-24 | 1 | -1/+0 |
| | |||||
* | Removed old tests | Godfrey Chan | 2014-01-24 | 3 | -250/+121 |
| | |||||
* | Rewrote the tests for has_secure_password | Godfrey Chan | 2014-01-24 | 3 | -2/+183 |
| | |||||
* | Update ActiveModel::Errors.has_key? test | Adrien Coquio | 2014-01-22 | 1 | -1/+1 |
| | |||||
* | Add failing test for ActiveModel::Errors#has_key? method | Adrien Coquio | 2014-01-22 | 1 | -0/+5 |
| | | | | From the doc, this method should return false and not nil if there is no errors for this key | ||||
* | Fix typo | Rafael Mendonça França | 2014-01-21 | 1 | -1/+1 |
| | |||||
* | When applying changes or reseting changes create the right class | Rafael Mendonça França | 2014-01-20 | 1 | -0/+8 |
| | | | | | | | Before this patch after the changes are applied the changes can be only accessed using string keys, but before symbols are also accepted. After this change every state of the model will be consistent. | ||||
* | Change all "can not"s to the correct "cannot". | T.J. Schuck | 2014-01-03 | 1 | -33/+33 |
| | |||||
* | Merge pull request #13131 from gja/changed-accepts-values | Godfrey Chan | 2013-12-30 | 1 | -0/+10 |
|\ | | | | | Allows you to check if a field has changed to a particular value | ||||
| * | Allows you to check if an attribute has changed to a particular value | Tejas Dinkar | 2013-12-15 | 1 | -0/+10 |
| | | | | | | | | model.name_changed?(from: "Pete", to: "Ringo") | ||||
* | | Disable locale checks to avoid warnings in Active Model tests [ci skip] | Carlos Antonio da Silva | 2013-12-23 | 1 | -0/+3 |
| | | | | | | | | | | Missed AMo when adding to the other components in ae196e85ee7169700afac2eecdc276bc06b10b8d. | ||||
* | | Unused classes in AMo tests | Akira Matsuda | 2013-12-19 | 1 | -11/+0 |
|/ | |||||
* | Merge pull request #13273 from robertomiranda/test-remove-require | Guillermo Iguaran | 2013-12-11 | 1 | -1/+0 |
|\ | | | | | Remove require 'models/administrator', Administrator is not used in secure password test | ||||
| * | Remove require 'models/administrator', Administrator is not used in secure ↵ | robertomiranda | 2013-12-11 | 1 | -1/+0 |
| | | | | | | | | password test | ||||
* | | Let validates_inclusion_of accept Time and DateTime ranges | Akira Matsuda | 2013-10-23 | 2 | -1/+23 |
| | | | | | | | | fixes 4.0.0 regression introduced in 0317b93c17a46d7663a8c36edc26ad0ba3d75f85 | ||||
* | | Use bcrypt's public cost attr, not internal constant | T.J. Schuck | 2013-10-10 | 1 | -0/+8 |
| | | | | | | | | | | | | | | | | See: - https://github.com/codahale/bcrypt-ruby/pull/63 - https://github.com/codahale/bcrypt-ruby/pull/64 - https://github.com/codahale/bcrypt-ruby/pull/65 | ||||
* | | Merge pull request #8791 from griffinmyers/master | Rafael Mendonça França | 2013-10-03 | 1 | -1/+16 |
|\ \ | | | | | | | | | | | | | | | | | | | Updated DirtyModel's @changed_attributes hash to be symbol/string agnostic Conflicts: activemodel/CHANGELOG.md |