Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Update Active Model xml serialization test to reflect a change in builder | Carlos Antonio da Silva | 2012-09-07 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | Due to a change in builder, nil values and empty strings now generates closed tags, so instead of this: <pseudonyms nil=\"true\"></pseudonyms> It generates this: <pseudonyms nil=\"true\"/> Document this change in Rails so that people can track it down easily if necessary. Conflicts: activemodel/CHANGELOG.md | ||||
* | `validates_inclusion_of` and `validates_exclusion_of` now accept | Rafael Mendonça França | 2012-07-20 | 3 | -0/+42 |
| | | | | | | `:within` option as alias of `:in` as documented. Fix #7118 | ||||
* | Fix build | Francesco Rodríguez | 2012-06-12 | 1 | -1/+1 |
| | |||||
* | Fix the the backport of the object dup with the ruby 1.9.3p194. | Angelo capilleri | 2012-06-12 | 2 | -0/+14 |
| | | | | | | At the end of initialize_dup was added the call to super if it exists, so it also works with 1.8.7 where initialize_dup doesn't exist. This issu was introduced with the pull request #6324 | ||||
* | Fix human attribute_name to handle deeply nested attributes | Tsutomu Kuroda | 2012-06-06 | 1 | -0/+5 |
| | | | | | This is a back-port of b0e2fc84 to Rails 3.2. See #5843 and #3859 also. | ||||
* | clean the errors if an object that includes validations errors is duped,for ↵ | Angelo capilleri | 2012-05-15 | 1 | -0/+15 |
| | | | | | | 3-2-stable It Fixes #5953 in 3-2-stable, it's the same pull request of #6284 | ||||
* | test against ruby features in order to fix tests on Ruby 2.0 | Aaron Patterson | 2012-04-12 | 1 | -1/+9 |
| | |||||
* | Merge pull request #5049 from fabioyamate/master | José Valim | 2012-02-15 | 1 | -0/+7 |
| | | | | Fix sanitize_for_mass_assigment when role is nil | ||||
* | Generate strict validation error messages with attribute name | Carlos Antonio da Silva | 2012-02-01 | 1 | -1/+10 |
| | | | | Backported from master. | ||||
* | Fix ActiveModel::Errors#dup | Paweł Kondzior | 2012-01-16 | 1 | -0/+8 |
| | | | | | | | | | | | | Since ActiveModel::Errors instance keeps all error messages as hash we should duplicate this object as well. Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash, which results in different behavior on dup, this may result in regression for people relying on it. Because Rails 3.2 stills supports Ruby 1.8.7 in order to properly fix this regression we need to backport #initialize_dup. | ||||
* | Apparently asssert_empty is not available in 1.8.7 | Piotr Sarnacki | 2012-01-16 | 1 | -1/+1 |
| | |||||
* | Add ActiveModel::Errors#delete, which was not available after move to use ↵ | Piotr Sarnacki | 2012-01-16 | 1 | -0/+7 |
| | | | | delegation | ||||
* | Fix stack level too deep when model does not have attributes method. | Piotr Sarnacki | 2012-01-15 | 1 | -0/+8 |
| | | | | | | | | | | | Without that patch when using ActiveModel::AttributeMethods in a class that does not respond to `attributes` method, stack level too deep error will be raised on non existing method. While documentation is clear that you need to define `attributes` method in order to use AttributeMethods module, `stack level too deep` is rather obscure and hard to debug, therefore we should try to not break `method_missing` if someone forgets about defining `attributes`. | ||||
* | Fixed test "ArgumentError: wrong number of arguments(1 for 0)" | Arun Agrawal | 2011-12-17 | 1 | -1/+1 |
| | |||||
* | Fixed bug when error message is an empty string. | Antonio Roberto | 2011-12-16 | 1 | -0/+6 |
| | |||||
* | Improve cache on route_key lookup. | José Valim | 2011-12-08 | 1 | -0/+8 |
| | |||||
* | ActiveModel::Name#i18n_key: Fix doc and add tests | Marc-Andre Lafortune | 2011-12-05 | 1 | -0/+20 |
| | |||||
* | Namespaced attribute lookup now works as 'model/association.attribute'. | José Valim | 2011-12-05 | 1 | -5/+5 |
| | |||||
* | Merge pull request #3859 from kuroda/human_attribute_name | José Valim | 2011-12-05 | 1 | -0/+10 |
|\ | | | | | Fix human_attribute_name to handle names with dots | ||||
| * | Fix human_attribute_name to handle names with dots | Tsutomu Kuroda | 2011-12-05 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | Nested I18n namespace lookup under activerecord.models is deprecated now (c19bd4f). But when a model uses accepts_nested_attributes_for, its Errors object can have an attribute name with "addresses.street" style. In this case, the dots should be substituted with slashes so that we can provide the translation under the "activemodel.attributes.person.addresses/street" key. | ||||
* | | Revert "Implement ArraySerializer and move old serialization API to a new ↵ | José Valim | 2011-11-30 | 3 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb | ||||
* | | fix method redefined warning in activemodel | lest | 2011-11-30 | 2 | -1/+5 |
| | | |||||
* | | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 1 | -5/+18 |
| | | | | | | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | ||||
* | | Warning removed unused variable | Arun Agrawal | 2011-11-26 | 1 | -1/+1 |
| | | |||||
* | | Revert the serializers API as other alternatives are now also under discussion | José Valim | 2011-11-25 | 1 | -432/+0 |
| | | |||||
* | | Merge branch 'serializers' | José Valim | 2011-11-25 | 4 | -5/+437 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | This implements the ActiveModel::Serializer object. Includes code, tests, generators and guides. From José and Yehuda with love. Conflicts: railties/CHANGELOG.md | ||||
| * | | Rename UserSerializer to DefaultUserSerializer in tests. | José Valim | 2011-11-23 | 1 | -15/+13 |
| | | | |||||
| * | | Rely solely on active_model_serializer and remove the fancy constant lookup. | José Valim | 2011-11-23 | 1 | -34/+3 |
| | | | |||||
| * | | Implement ArraySerializer and move old serialization API to a new namespace. | José Valim | 2011-11-23 | 4 | -8/+67 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer. | ||||
| * | | Merge branch 'master' into serializers | José Valim | 2011-11-23 | 7 | -40/+128 |
| |\ \ | |||||
| * | | | Remove 1.9 Hash syntax - tests passing on 1.8.7 | Jose and Yehuda | 2011-10-15 | 1 | -3/+3 |
| | | | | |||||
| * | | | Add initial support for embed API | Jose and Yehuda | 2011-10-15 | 1 | -4/+82 |
| | | | | |||||
| * | | | Add support for the root attribute | Jose and Yehuda | 2011-10-15 | 1 | -14/+62 |
| | | | | |||||
| * | | | Fix nil has_one association | Jose and Yehuda | 2011-10-15 | 1 | -0/+18 |
| | | | | |||||
| * | | | Add association_ids | Jose and Yehuda | 2011-10-15 | 1 | -1/+60 |
| | | | | |||||
| * | | | Add support for overriding associations, mostly used for authorization | Jose and Yehuda | 2011-10-15 | 1 | -0/+26 |
| | | | | |||||
| * | | | Add support for implicit serializers | Jose and Yehuda | 2011-10-15 | 1 | -2/+33 |
| | | | | |||||
| * | | | Added has_one and has_many | Jose and Yehuda | 2011-10-15 | 1 | -5/+76 |
| | | | | |||||
| * | | | Don't require serializable_hash to take options. | Jose and Yehuda | 2011-10-15 | 1 | -2/+2 |
| | | | | |||||
| * | | | Initial implementation of ActiveModel::Serializer | Jose and Yehuda | 2011-10-15 | 1 | -0/+75 |
| | | | | |||||
* | | | | make ActiveModel::Name fail gracefully with anonymous classes | Jakub Kuźma | 2011-11-24 | 1 | -0/+13 |
| |/ / |/| | | |||||
* | | | Rely on a public contract between railties instead of accessing railtie ↵ | José Valim | 2011-11-23 | 2 | -10/+36 |
| | | | | | | | | | | | | methods directly. | ||||
* | | | Update variable's name in the test case to reflect the class we're testing | Prem Sichanugrist | 2011-11-18 | 3 | -24/+24 |
| | | | |||||
* | | | Revert "Merge pull request #2378 from cesario/remove_warnings_activemodel" | Jon Leighton | 2011-11-05 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 6aaae3de277b572f37e09f16ae12737c3c87dfb7, reversing changes made to fdbc4e5f4e5746ebf558485348c841b33f038fda. Reason: build failure. | ||||
* | | | Merge pull request #2378 from cesario/remove_warnings_activemodel | Vijay Dev | 2011-11-05 | 1 | -0/+1 |
|\ \ \ | | | | | | | | | Remove warnings by calling remove_method | ||||
| * | | | Remove warnings by calling remove_method | Franck Verrot | 2011-07-31 | 1 | -0/+1 |
| | | | | |||||
* | | | | New #added? method on ActiveModel::Errors | Martin Svalin | 2011-10-19 | 1 | -0/+43 |
| | | | | | | | | | | | | The #added? method makes it possible to check if a specific error has been added, using the same parameters as for #add. | ||||
* | | | | use variables from test setup | Vijay Dev | 2011-10-17 | 1 | -6/+4 |
| | | | | |||||
* | | | | ActiveModel::Errors#generate_message without i18n_scope, and more test cases ↵ | Martin Svalin | 2011-10-17 | 1 | -0/+21 |
| |/ / |/| | | | | | | | | for #add | ||||
* | | | Fixed serialization issues with multiple includes with options | zhengjia | 2011-10-11 | 1 | -0/+8 |
| | | |