aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/test
Commit message (Collapse)AuthorAgeFilesLines
* after_validation should be called irrespective of the result of validation.Neeraj Singh2010-08-202-0/+11
| | | | | | | | I confirmed that this is the behavior on 2.3.x . [5419 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* code gardening: we have assert_(nil|blank|present), more concise, with ↵Xavier Noria2010-08-171-3/+3
| | | | better default failure messages - let's use them
* Adding missing required statementSubba Rao Pasupuleti2010-08-141-0/+1
| | | | | | [#5056 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵Santiago Pastorino2010-08-148-18/+17
| | | | 's/[ \t]*$//' -i {} \;)
* no callbacks should be created for empty array [#5289 state:resolved]Subba Rao Pasupuleti2010-08-121-0/+14
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Add missing ActiveModel::Validations requireGreg Campbell2010-08-121-1/+0
| | | | | | | | | | | [#5311 state: resolved] ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport. (This wasn't showing up in the tests, because it was required in the helper, and was also required in ActiveModel::Serialization). Signed-off-by: José Valim <jose.valim@gmail.com>
* Failing test for validates_length_of, when both too_short and too_long ↵rohit2010-08-031-0/+14
| | | | | | messages are set [#5283 state:open] Signed-off-by: José Valim <jose.valim@gmail.com>
* Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵Tore Darell2010-08-031-5/+85
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* adding test cases for ActiveModel::ErrorsNeeraj Singh2010-08-031-0/+65
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 ↵Alex Le2010-08-022-4/+20
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Reuse already existing classes for ActiveModel tests.José Valim2010-07-214-63/+44
|
* Moved a few methods from RecordIdentifier to ActiveModel::NamingPiotr Sarnacki2010-07-211-0/+63
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Avoid interpreted as grouped expression warningsSantiago Pastorino2010-07-112-4/+4
|
* mass_assignment_security moved from AR to AMo, and minor test cleanupJosh Kalderimis2010-07-086-0/+232
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Missing BigDecimal dependencyJeremy Kemper2010-06-271-0/+2
|
* Work around the fact the JSON gem was overwriting to_json implementation for ↵José Valim2010-06-262-7/+16
| | | | | | | all Ruby core classes. This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized. So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved]
* Regression with how base errors messages are added to a model. Works ↵Josh Kalderimis2010-06-231-3/+18
| | | | | | correctly for both string error messages and symbol translated messages. Signed-off-by: José Valim <jose.valim@gmail.com>
* should be able to run ActiveModel validations_test [#4933 state:resolved]Neeraj Singh2010-06-221-0/+1
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Avoid method redefined warningSantiago Pastorino2010-06-221-1/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-06-212-379/+210
| | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com>
* ActiveModel::Validations::Callbacks should not be required by default.José Valim2010-06-191-0/+1
|
* moving before_validation and after_validation functionality from ↵Neeraj Singh2010-06-191-0/+76
| | | | | | | | ActiveRecord to ActiveModel [#4653 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Really make include_root_in_json default to true [#3770 state:resolved]José Valim2010-06-081-15/+21
|
* Fix xml serialization test [#4650 state:resolved]Anil Wadghule2010-05-191-2/+5
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Use better assertion methods for testingNeeraj Singh2010-05-194-5/+5
| | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Add a valid hex that shouldn't be valid to ActiveModel numericality tests ↵rohit2010-05-181-1/+1
| | | | | | [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com>
* Valid hex strings aren't valid float column values, to match the integer ↵Jeremy Kemper2010-05-171-1/+1
| | | | restriction. [#4622 state:resolved]
* Make use of assert_equal to test equallity between object assert expects and ↵Santiago Pastorino2010-05-162-3/+3
| | | | | | | | object and a message of error [#4611 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵José Valim2010-05-152-73/+73
| | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff.
* Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵Jeroen van Dijk2010-05-152-73/+73
| | | | | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again [#4057 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* validation macros can now be used within an instanceJosh Kalderimis2010-05-132-0/+25
|
* Revert "Refactor of active_model/naming.rb and allow collection and element ↵Santiago Pastorino2010-05-121-30/+0
| | | | | | | | to be writable" This reverts commit f7862b2c34b5b298bf7b937c55f0637ebfe43a25. Signed-off-by: José Valim <jose.valim@gmail.com>
* Make ActiveResource serialize XML correctly when element_name is set.Santiago Pastorino2010-05-121-2/+2
| | | | | | [#4529] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Refactor of active_model/naming.rb and allow collection and element to be ↵Santiago Pastorino2010-05-121-0/+30
| | | | | | writable Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* removed AR from all AMo tests, including any unneeded files (schema, ↵Josh Kalderimis2010-05-0918-128/+12
| | | | fixtures and test helper)
* removed an old unused model in the AMo tests which also removes another AR ↵Josh Kalderimis2010-05-099-14/+0
| | | | dependency
* removed use of AR in AMo tests and removed testing of scopes (:on) in ↵Josh Kalderimis2010-05-0814-289/+240
| | | | individual validation tests and moved them to their own test file
* Active Model JSON serializer now supports custom root optionJatinder Singh2010-05-041-0/+16
| | | | | | [#4515 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Favor %{} in all code instead of (deprecated) {{}} as interpolation syntax ↵Lawrence Pit2010-05-038-37/+37
| | | | | | for I18n Signed-off-by: José Valim <jose.valim@gmail.com>
* test cases for record.to_xml [#458 state:resolved]Neeraj Singh2010-04-302-0/+16
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* array.to_xml should be able to handle all types of data elements [#4490 ↵Neeraj Singh2010-04-291-2/+5
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix validates_numericaly_of only integer error message [#4406 state:resolved]reu2010-04-251-9/+9
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix Active Model observer testsJeremy Kemper2010-04-161-2/+0
|
* Re-define empty? for errors to check if the values inside the OrderedHash ↵Ryan Bigg2010-04-101-0/+6
| | | | | | are empty rather than the OrderedHash itself. [#4356 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* errors.rb needs to be declared as UTF-8 [#3941 state:resolved]Aaron Patterson2010-04-021-0/+10
| | | | Signed-off-by: wycats <wycats@gmail.com>
* Restore changed_attributes method in ActiveModel::Dirty and loosen ↵Sam Pohlenz2010-04-011-1/+0
| | | | | | | | expectation on including class' initialize method. [#4308 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fix tests added in previous commit.José Valim2010-03-271-0/+1
|
* ActiveModel::Dirty#changes should return a HashWithIndifferentAccess [#4157 ↵Jacob Atzen2010-03-271-0/+29
| | | | | | | | state:resolved] Keep the Rails style of inject Signed-off-by: José Valim <jose.valim@gmail.com>
* ensure activemodel lib is setup correctlyJoshua Peek2010-02-281-0/+3
|
* Accept array of attributes as arg also, like 2.3Jeremy Kemper2010-02-251-10/+16
|