Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Merge pull request #8527 from shockone/patch-1 | Rafael Mendonça França | 2013-03-25 | 1 | -0/+20 | |
|\ \ | | | | | | | Add a method full_messages_for to the Errors class | |||||
| * | | Add a method full_messages_for to the Errors class | shock_one | 2013-03-24 | 1 | -0/+20 | |
| | | | ||||||
* | | | Add Error#full_message test; Fix typos | Vipul A M | 2013-03-22 | 1 | -0/+1 | |
|/ / | | | | | | | | | Introduce test on Error#full_message for attribute with underscores; Fix some typos | |||||
* | | fix some typos found in activemodel | Vipul A M | 2013-03-18 | 3 | -4/+4 | |
| | | ||||||
* | | Small typos here and there. | Vipul A M | 2013-03-15 | 3 | -4/+4 | |
| | | ||||||
* | | `has_secure_password` is not invalid when assigning empty Strings. | Yves Senn | 2013-03-04 | 1 | -0/+6 | |
| | | | | | | | | | | | | | | | | | | | | Closes #9535. With 692b3b6 the `password=` setter does no longer set blank passwords. This triggered validation errors when assigning empty Strings to `password` and `password_confirmation`. This patch only sets the confirmation if it is not `blank?`. | |||||
* | | `validates_confirmation_of` does not override writer methods. | Yves Senn | 2013-03-04 | 1 | -0/+31 | |
| | | ||||||
* | | added more accurate test for add_on_empty | Angelo capilleri | 2013-02-19 | 1 | -0/+7 | |
| | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails | |||||
* | | Take care of whitespaces and changing the hash syntax | Rafael Mendonça França | 2013-02-04 | 1 | -57/+56 | |
| | | ||||||
* | | test for issue 8931 | David | 2013-02-02 | 1 | -0/+8 | |
| | | ||||||
* | | Adding the route_key and param_key tests | Attila Domokos | 2013-01-22 | 1 | -0/+8 | |
| | | | | | | This way all the tests are testing the same fields | |||||
* | | Merge pull request #8940 from adomokos/adding_tests_for_changed_attributes | Carlos Antonio da Silva | 2013-01-15 | 1 | -1/+12 | |
|\ \ | | | | | | | Cleaning up ActiveModel::Dirty tests | |||||
| * | | Cleaning up ActiveModel::Dirty tests | Attila Domokos | 2013-01-15 | 1 | -1/+12 | |
| | | | | | | | | | | | | | | | | | | | | | * Clarifying what the #changed method returns * Adding tests to describe what the #changed_attributes returns * Updating test name based on pull request comment * Moving the test lower in the file per pull request comment | |||||
* | | | test for ActiveModel::Conversion#to_partial_path and namespaced models | Yves Senn | 2013-01-14 | 2 | -0/+8 | |
|/ / | ||||||
* | | Adding tests for ActiveModel::Model | Attila Domokos | 2013-01-12 | 1 | -0/+6 | |
| | | | | | | | | | | | | * Verifying persisted? is false when Model initialized * Passing nil to Model should not blow up * Changing test name to the one suggested in pull request comment | |||||
* | | Covering untested methods for ActiveModel::Errors | Attila Domokos | 2013-01-10 | 1 | -0/+53 | |
|/ | ||||||
* | Add active_support/testing/autorun | Rafael Mendonça França | 2012-12-31 | 1 | -1/+1 | |
| | | | | | minitest/autorun load minitest/spec polluting the global namespace with the DSL that we don't want on Rails | |||||
* | Add CHANGELOG entry for #8622 | Rafael Mendonça França | 2012-12-26 | 1 | -2/+2 | |
| | ||||||
* | Revert the change at ActiveModel::Errors#add_on_blank and fix in the | Rafael Mendonça França | 2012-12-26 | 1 | -5/+5 | |
| | | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621. | |||||
* | Tests and fix for validates_presence of :allow_nil, :allow_blank | Colin Kelley | 2012-12-26 | 1 | -0/+34 | |
| | | | | | Conflicts: activemodel/lib/active_model/errors.rb | |||||
* | chmod -x from non-script files | Akira Matsuda | 2012-12-24 | 1 | -0/+0 | |
| | ||||||
* | Add `ActiveModel::Validations::AbsenceValidator`, a validator to check the ↵ | Roberto Vasquez Angel | 2012-12-15 | 1 | -0/+67 | |
| | | | | | | absence of attributes. Add `ActiveModel::Errors#add_on_present` method. Adds error messages to present attributes. | |||||
* | Actually test that ActiveModel::Errors#add defaults to :invalid. | Renato Mascarenhas | 2012-12-01 | 1 | -1/+1 | |
| | ||||||
* | Call `full_messages` instead of `to_a` in its spec. | Renato Mascarenhas | 2012-12-01 | 1 | -2/+1 | |
| | ||||||
* | Reset attributes should not report changes. | Renato Mascarenhas | 2012-12-01 | 1 | -2/+1 | |
| | | | | | | | | | | | When resetting an attribute, you expect it to return to the state it was before any changes. Namely, this fixes this unexpected behavior: ~~~ruby model.name = "Bob" model.reset_name! model.name_changed? #=> true ~~~ | |||||
* | Simplify keys order test for as_json in Active Model | Carlos Antonio da Silva | 2012-11-30 | 1 | -4/+1 | |
| | ||||||
* | Remove observers and sweepers | Rafael Mendonça França | 2012-11-28 | 3 | -428/+0 | |
| | | | | | | | | They was extracted from a plugin. See https://github.com/rails/rails-observers [Rafael Mendonça França + Steve Klabnik] | |||||
* | Specify type of singular association during serialization | Steve Klabnik | 2012-11-28 | 1 | -2/+10 | |
| | | | | | | | | | | | | When serialising a class, specify the type of any singular associations, if necessary. Rails already correctly specifies the :type of any enumerable association (e.g. a has_many association), but made no attempt to do so for non-enumerables (e.g. a has_one association). We must specify the :type of any STI association. A has_one association to a class which uses single-table inheritance is an example of this type of association. Fixes #7471 | |||||
* | Merge pull request #7282 from xHire/validates_length_of_fix | Rafael Mendonça França | 2012-11-26 | 1 | -0/+39 | |
|\ | | | | | | | | | | | | | Length validation handles correctly nil. Fix #7180 Conflicts: activemodel/CHANGELOG.md | |||||
| * | Length validation handles correctly nil. Fix #7180 | Michal Zima | 2012-11-26 | 1 | -0/+39 | |
| | | | | | | | | When nil or empty string are not allowed, they are not valid. | |||||
* | | Merge pull request #8320 from senny/active_model_log_folder | Carlos Antonio da Silva | 2012-11-26 | 1 | -0/+1 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Log output from activemodel's railtie_test directly to STDOUT. There's no logging going on here, but since we initialize the app, the logger is set and the folder is automatically created. With this change, the default logger is not created, so there is no logging folder anymore. Conflicts: activemodel/test/cases/railtie_test.rb | |||||
| * | | log output from activemodel's railtie_test directly to STDOUT | Yves Senn | 2012-11-26 | 1 | -0/+1 | |
| |/ | | | | | | | | | after this patch, running the tests in activemodel will no longer create an untracked log/ folder inside of activemodel | |||||
* / | Require active_model/railtie directly instead of rails/all | Carlos Antonio da Silva | 2012-11-26 | 1 | -3/+3 | |
|/ | | | | Use Class.new with a block instead of tap to configure it. | |||||
* | Use secure password min cost option in its own tests for a speed up | Carlos Antonio da Silva | 2012-11-21 | 1 | -2/+10 | |
| | | | | Around 0.564359s => 0.092244s speed up in my machine. | |||||
* | Use BCrypt's MIN_COST in the test environment for speedier tests | Trevor Turk | 2012-11-14 | 2 | -1/+40 | |
| | ||||||
* | use Array() instead flatten | Vasiliy Ermolovich | 2012-11-05 | 2 | -21/+39 | |
| | | | | | * move ActiveModel::Errors tests to errors_test.rb * add spec coverage for add_on_empty and add_on_blank | |||||
* | Raise ArgumentError when no attribute is given to AMo::EachValidator | Carlos Antonio da Silva | 2012-11-04 | 1 | -1/+1 | |
| | | | | ArgumentError is better suited than RuntimeError for this. | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-03 | 2 | -13/+13 | |
|\ | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md | |||||
| * | convert comments to 1.9 hash syntax | AvnerCohen | 2012-10-22 | 2 | -13/+13 | |
| | | ||||||
* | | Add test for code change introduced in this commit f20032f | Cédric FABIANSKI | 2012-10-29 | 1 | -0/+9 | |
| | | ||||||
* | | fix failing isolated tests | Francesco Rodriguez | 2012-10-26 | 1 | -0/+1 | |
| | | ||||||
* | | AM::Serializers::Xml depends on AM::Naming | Francesco Rodriguez | 2012-10-26 | 3 | -4/+0 | |
|/ | ||||||
* | Cleanup trailing whitespaces | dfens | 2012-10-12 | 1 | -1/+1 | |
| | ||||||
* | Revert "Merge pull request #7826 from sikachu/master-validators-kind" | Rafael Mendonça França | 2012-10-02 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | This reverts commit 4e9f53f9736544f070e75e516c71137b7eb49a7a, reversing changes made to 6b802cdb4f5b84e1bf49aaeb0e994b3be6028af9. Revert "Don't use tap in this case." This reverts commit 454d820bf0a18fe1db4c55b0145197d70fef1f82. Reason: Is not a good idea to add options to this method since we can do the same thing using method composition. Person.validators_on(:name).select { |v| v.kind == :presence } Also it avoids to change the method again to add more options. | |||||
* | Make `.validators_on` accept `:kind` option | Prem Sichanugrist | 2012-10-02 | 1 | -0/+8 | |
| | | | | | This will filter out the validators on a particular attribute based on its kind. | |||||
* | attr_accessible and attr_protected raise an exception pointing to use plugin ↵ | Guillermo Iguaran | 2012-09-16 | 2 | -0/+19 | |
| | | | | or new protection model | |||||
* | Don't use assert_nothing_raised when assert_equal is used | Guillermo Iguaran | 2012-09-16 | 1 | -8/+2 | |
| | ||||||
* | Rename ForbiddenAttributes exception to ForbiddenAttributesError | Guillermo Iguaran | 2012-09-16 | 1 | -1/+1 | |
| | ||||||
* | Change AMo::ForbiddenAttributesProtection tests to use a subclass of Hash ↵ | Guillermo Iguaran | 2012-09-16 | 1 | -8/+18 | |
| | | | | instead of monkey patch permitted? method in regular hashes | |||||
* | Remove MassAssignmentSecurity from ActiveModel | Guillermo Iguaran | 2012-09-16 | 11 | -347/+11 | |
| | | | | This will be moved out to protected_attributes gem |