Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | build fix for observing_test.rb | Arun Agrawal | 2012-04-30 | 1 | -1/+1 |
| | | | introduced here 17c990b153f8635874c006a7460ee95817543fc1 | ||||
* | Merge pull request #6072 from marcandre/observer_simplify_test | Santiago Pastorino | 2012-04-30 | 1 | -11/+4 |
|\ | | | | | Observer: simplify tests | ||||
| * | Observer: simplify tests | Marc-Andre Lafortune | 2012-04-29 | 1 | -11/+4 |
| | | |||||
* | | Merge pull request #6071 from marcandre/observer_redef | Jeremy Kemper | 2012-04-29 | 1 | -2/+13 |
|\ \ | | | | | | | Fix Observer by acting on singleton class. Fixes #3505. | ||||
| * | | Fix Observer by acting on singleton class [#3505] | Marc-Andre Lafortune | 2012-04-29 | 1 | -2/+13 |
| |/ | | | | | | | Also [issue #1034] [pull #6068] | ||||
* | | Merge pull request #5942 from ↵ | Aaron Patterson | 2012-04-29 | 4 | -9/+33 |
|\ \ | | | | | | | | | | | | | bcardarella/confirmation_error_message_on_confirmation_attribute confirmation validation error attribute | ||||
| * | | Support i18n attributes for confirmation | Brian Cardarella | 2012-04-24 | 2 | -2/+21 |
| | | | |||||
| * | | confirmation validation error attribute | Brian Cardarella | 2012-04-23 | 4 | -9/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will render the error message on :#{attribute}_confirmation instead of on attribute itself. When rendering confirmation errors inline on the form with form builders such as SimpleForm and Formtastic it is confusing to the ender user to see the confirmation error message on the attribute element. Instead it makes more sense to have this validation error render on the confirmation field instead. The i18n message has been updated for the confirmation validator error message to include the original attribute name. | ||||
* | | | Generate appropriate error more judiciously | Marc-Andre Lafortune | 2012-04-29 | 1 | -0/+15 |
| |/ |/| | |||||
* | | Do not modify options hash in human_attribute_name, remove reverse_merge | Carlos Antonio da Silva | 2012-04-28 | 1 | -2/+8 |
| | | |||||
* | | Merge pull request #5841 from oscardelben/rename_count_observers | José Valim | 2012-04-24 | 1 | -1/+1 |
|\ \ | | | | | | | Rename Observing#count_observers to Observing#observers_count | ||||
| * | | Rename Observing#count_observers to Observing#observers_count | Oscar Del Ben | 2012-04-14 | 1 | -1/+1 |
| |/ | |||||
* / | Fix secure_password setter | Oscar Del Ben | 2012-04-24 | 1 | -0/+6 |
|/ | |||||
* | test against ruby features in order to fix tests on Ruby 2.0 | Aaron Patterson | 2012-03-26 | 1 | -1/+9 |
| | |||||
* | Merge pull request #5374 from ↵ | José Valim | 2012-03-23 | 1 | -24/+0 |
|\ | | | | | | | | | nertzy/remove_deprecated_partial_path_from_active_model_naming Remove ActiveModel::Naming#partial_path | ||||
| * | Remove ActiveModel::Naming#partial_path | Grant Hutchins | 2012-03-10 | 1 | -24/+0 |
| | | | | | | It was deprecated in 3.2 | ||||
* | | Revert "AM::MassAssingmentSecurity: improve performance" | José Valim | 2012-03-15 | 1 | -1/+1 |
| | | | | | | | | | | | | It introduces backwards incompatible changes in the API. This reverts commit 7d1379ffdbbaf01e99833dc06611b7e4f3799522. | ||||
* | | AM::MassAssingmentSecurity: improve performance | Bogdan Gusiev | 2012-03-14 | 1 | -1/+1 |
| | | |||||
* | | Fix comments about to_partial_path | Grant Hutchins | 2012-03-10 | 1 | -1/+1 |
|/ | |||||
* | Make sure serializable hash with :include always returns string keys | Carlos Antonio da Silva | 2012-03-09 | 1 | -13/+13 |
| | |||||
* | Add docs with usage examples for ActiveModel::Model | Carlos Antonio da Silva | 2012-03-03 | 1 | -0/+7 |
| | | | | | Also add test to ensure basic model does not explode when initialized with nil. | ||||
* | Add ActiveModel::Model, a mixin to make Ruby objects to work with AP inmediatly | Guillermo Iguaran | 2012-03-02 | 1 | -0/+19 |
| | |||||
* | AM::Errors: allow :full_messages parameter for #as_json | Bogdan Gusiev | 2012-02-20 | 1 | -0/+10 |
| | |||||
* | Fix sanitize_for_mass_assigment when role is nil | Fabio Yamate | 2012-02-15 | 1 | -0/+7 |
| | | | | | | | There is an example in Rails documentation that suggests implementing assign_attributes method for ActiveModel interface, that by default sends option role with nil. Since mass_assignment_authorizer never is called without args, we can move the default value internally. | ||||
* | Make sure serializable hash with :methods option returns always string keys | Carlos Antonio da Silva | 2012-02-13 | 1 | -3/+3 |
| | |||||
* | Cleanup extra spaces | Carlos Antonio da Silva | 2012-02-13 | 1 | -45/+44 |
| | |||||
* | test title changed corresponding to the test | prasath | 2012-02-09 | 1 | -1/+1 |
| | |||||
* | Merge pull request #4930 from ask4prasath/ordered_hash_replaced | Aaron Patterson | 2012-02-08 | 3 | -4/+4 |
|\ | | | | | Replacing ordered hash to ruby hash on active model | ||||
| * | replacing ordered hash to ruby hash | prasath | 2012-02-08 | 3 | -4/+4 |
| | | |||||
* | | Trim down Active Model API by removing valid? and errors.full_messages | José Valim | 2012-02-07 | 1 | -5/+1 |
|/ | |||||
* | To infinity… and beyond! | Niels Ganser | 2012-02-06 | 1 | -0/+18 |
| | | | | | | | Allow infinite values for validates_length_of. Particularly useful for prettily defining an open ended range such as validates_length_of :human_stupidity, :within => 0..Float::INFINITY | ||||
* | Generate strict validation error messages with attribute name | Carlos Antonio da Silva | 2012-02-01 | 1 | -3/+12 |
| | |||||
* | Removed unwanted intializer and replaced with ruby default collect method | prasath | 2012-01-27 | 1 | -2/+1 |
| | |||||
* | Removing unwanted method and adding to accessor for getter history | prasath | 2012-01-25 | 1 | -4/+3 |
| | |||||
* | validates method should not change options argument | dreamfall | 2012-01-17 | 1 | -0/+6 |
| | |||||
* | Fix ActiveModel::Errors#dup | Paweł Kondzior | 2012-01-16 | 1 | -0/+8 |
| | | | | | | | | | Since ActiveModel::Errors instance keeps all error messages as hash we should duplicate this object as well. Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash, which results in different behavior on `dup`, this may result in regression for people relying on it. | ||||
* | Add ActiveModel::Errors#delete, which was not available after move to use ↵ | Piotr Sarnacki | 2012-01-16 | 1 | -0/+7 |
| | | | | delegation | ||||
* | Fix test class name that should read Without | Carlos Antonio da Silva | 2012-01-16 | 1 | -2/+2 |
| | |||||
* | Fix stack level too deep when model does not have attributes method. | Piotr Sarnacki | 2012-01-15 | 1 | -0/+8 |
| | | | | | | | | | | | Without that patch when using ActiveModel::AttributeMethods in a class that does not respond to `attributes` method, stack level too deep error will be raised on non existing method. While documentation is clear that you need to define `attributes` method in order to use AttributeMethods module, `stack level too deep` is rather obscure and hard to debug, therefore we should try to not break `method_missing` if someone forgets about defining `attributes`. | ||||
* | Merge pull request #4360 from rafaelfranca/patch-1 | Aaron Patterson | 2012-01-06 | 1 | -2/+2 |
|\ | | | | | Remove more references to Test::Unit | ||||
| * | Use ActiveModel::TestCase instead of Test::Unit:TestCase | Rafael Mendonça França | 2012-01-06 | 1 | -2/+2 |
| | | |||||
* | | require minitest rather than test/unit | Aaron Patterson | 2012-01-06 | 1 | -1/+1 |
|/ | |||||
* | Support configuration on ActiveRecord::Model. | Jon Leighton | 2011-12-28 | 1 | -0/+154 |
| | | | | | | | | | | | | | | | The problem: We need to be able to specify configuration in a way that can be inherited to models that include ActiveRecord::Model. So it is no longer sufficient to put 'top level' config on ActiveRecord::Base, but we do want configuration specified on ActiveRecord::Base and descendants to continue to work. So we need something like class_attribute that can be defined on a module but that is inherited when ActiveRecord::Model is included. The solution: added ActiveModel::Configuration module which provides a config_attribute macro. It's a bit specific hence I am not putting this in Active Support or making it a 'public API' at present. | ||||
* | remove deprecated define_attr_method from ActiveModel::AttributeMethods | Sergey Nartimov | 2011-12-24 | 1 | -31/+0 |
| | |||||
* | Changed the require path for logger | Karunakar (Ruby) | 2011-12-21 | 1 | -1/+1 |
| | |||||
* | removed deprecated loggers | Karunakar (Ruby) | 2011-12-21 | 1 | -1/+1 |
| | |||||
* | added :other_than => :!= option to numericality validator | Jakub Kuźma | 2011-12-21 | 1 | -0/+7 |
| | |||||
* | Remove dead code from AMo. | José Valim | 2011-12-20 | 1 | -47/+37 |
| | |||||
* | Fixed test "ArgumentError: wrong number of arguments(1 for 0)" | Arun Agrawal | 2011-12-17 | 1 | -1/+1 |
| | |||||
* | Fixed bug when error message is an empty string. | Antonio Roberto | 2011-12-16 | 1 | -0/+6 |
| |