Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | This is not an executable file | Santiago Pastorino | 2010-12-16 | 1 | -0/+0 | |
| | ||||||
* | Add support for namespaced validators | Samuel Kadolph | 2010-12-16 | 2 | -0/+14 | |
| | | | | | | Includes test and documentation for new feature Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Test using default option as symbol added for human_attribute_name | Santiago Pastorino | 2010-12-05 | 1 | -0/+5 | |
| | ||||||
* | default could be a symbol here so attribute.to_s.humanize should be the ↵ | Santiago Pastorino | 2010-12-05 | 1 | -0/+4 | |
| | | | | final option | |||||
* | Test falling back to default added for human_attribute_name | Santiago Pastorino | 2010-12-05 | 1 | -0/+4 | |
| | ||||||
* | Test using default option added for human_attribute_name | Santiago Pastorino | 2010-12-05 | 1 | -0/+4 | |
| | ||||||
* | ActiveModel::Errors.to_hash returns plain OrderedHash and used in to_json ↵ | Thilo Utke | 2010-12-01 | 3 | -9/+15 | |
| | | | | | | serialization to properly handle multiple errors per attribute [#5615 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Revert "Fix generation of wrong json string when field has multiple errors" | José Valim | 2010-12-01 | 1 | -10/+0 | |
| | | | | This reverts commit a9b666b51d28b2e74da630c31327dee7cbe96d37. | |||||
* | Fix generation of wrong json string when field has multiple errors | Krekoten' Marjan | 2010-12-01 | 1 | -0/+10 | |
| | ||||||
* | do not require ruby-debug automatically. please require it if you have ↵ | Aaron Patterson | 2010-11-19 | 1 | -6/+0 | |
| | | | | declared it as a dependency | |||||
* | Allowing to_xml :camelize option to be set to :lower to enable ↵ | Jeremy Holland | 2010-11-03 | 1 | -0/+7 | |
| | | | | lower-camelcase tags [#5903 state:resolved] | |||||
* | No need to pass self as parameter here. | José Valim | 2010-10-04 | 1 | -1/+1 | |
| | ||||||
* | Test to_model being called in ActiveModel::Naming helpers | Ernie Miller | 2010-10-04 | 2 | -0/+11 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | after_create in ActiveModel should in the order specified | Neeraj Singh | 2010-09-27 | 1 | -0/+30 | |
| | | | | | | [#5650 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Don't act destructively on ActiveModel::Name#human options hash. [#5366 ↵ | John Firebaugh | 2010-09-25 | 2 | -0/+10 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Properly interpolate i18n keys in modules [#5572 state:resolved] | Rodrigo Rosenfeld Rosas | 2010-09-24 | 2 | -0/+24 | |
| | ||||||
* | Better shortcut options for custom validators [#5672 state:resolved] | Obie Fernandez | 2010-09-24 | 2 | -0/+22 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | fixed some issues with JSON encoding | Jakub Suder | 2010-09-07 | 1 | -0/+27 | |
| | | | | | | | | | | | - as_json in ActiveModel should return a hash and handle :only/:except/:methods options - Array and Hash should call as_json on their elements - json methods should not modify options argument [#5374 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Prepared ActiveModel::Naming to handle cases for namespaced isolated engines | Piotr Sarnacki | 2010-09-03 | 2 | -0/+112 | |
| | ||||||
* | adding new test for ActiveModel::Serialization | Neeraj Singh | 2010-08-31 | 1 | -0/+45 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Remove deprecations in ActiveModel. | José Valim | 2010-08-29 | 1 | -36/+0 | |
| | ||||||
* | after_validation should be called irrespective of the result of validation. | Neeraj Singh | 2010-08-20 | 2 | -0/+11 | |
| | | | | | | | | I confirmed that this is the behavior on 2.3.x . [5419 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | code gardening: we have assert_(nil|blank|present), more concise, with ↵ | Xavier Noria | 2010-08-17 | 1 | -3/+3 | |
| | | | | better default failure messages - let's use them | |||||
* | Adding missing required statement | Subba Rao Pasupuleti | 2010-08-14 | 1 | -0/+1 | |
| | | | | | | [#5056 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 8 | -18/+17 | |
| | | | | 's/[ \t]*$//' -i {} \;) | |||||
* | no callbacks should be created for empty array [#5289 state:resolved] | Subba Rao Pasupuleti | 2010-08-12 | 1 | -0/+14 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add missing ActiveModel::Validations require | Greg Campbell | 2010-08-12 | 1 | -1/+0 | |
| | | | | | | | | | | | [#5311 state: resolved] ActiveModel::Validations uses Hash#except, but does not require it from ActiveSupport. (This wasn't showing up in the tests, because it was required in the helper, and was also required in ActiveModel::Serialization). Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Failing test for validates_length_of, when both too_short and too_long ↵ | rohit | 2010-08-03 | 1 | -0/+14 | |
| | | | | | | messages are set [#5283 state:open] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Remove or fix non-working examples and add a few tests to Dirty [#5185 ↵ | Tore Darell | 2010-08-03 | 1 | -5/+85 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | adding test cases for ActiveModel::Errors | Neeraj Singh | 2010-08-03 | 1 | -0/+65 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | ActiveModel::Errors json serialization to work as Rails 3b4 [#5254 ↵ | Alex Le | 2010-08-02 | 2 | -4/+20 | |
| | | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Reuse already existing classes for ActiveModel tests. | José Valim | 2010-07-21 | 4 | -63/+44 | |
| | ||||||
* | Moved a few methods from RecordIdentifier to ActiveModel::Naming | Piotr Sarnacki | 2010-07-21 | 1 | -0/+63 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Avoid interpreted as grouped expression warnings | Santiago Pastorino | 2010-07-11 | 2 | -4/+4 | |
| | ||||||
* | mass_assignment_security moved from AR to AMo, and minor test cleanup | Josh Kalderimis | 2010-07-08 | 6 | -0/+232 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Missing BigDecimal dependency | Jeremy Kemper | 2010-06-27 | 1 | -0/+2 | |
| | ||||||
* | Work around the fact the JSON gem was overwriting to_json implementation for ↵ | José Valim | 2010-06-26 | 2 | -7/+16 | |
| | | | | | | | all Ruby core classes. This is required because the JSON gem is incompatible with Rails behavior and was not allowing ActiveModel::Errors to be serialized. So we need to ensure Rails implementation is the one triggered. [#4890 state:resolved] | |||||
* | Regression with how base errors messages are added to a model. Works ↵ | Josh Kalderimis | 2010-06-23 | 1 | -3/+18 | |
| | | | | | | correctly for both string error messages and symbol translated messages. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | should be able to run ActiveModel validations_test [#4933 state:resolved] | Neeraj Singh | 2010-06-22 | 1 | -0/+1 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Avoid method redefined warning | Santiago Pastorino | 2010-06-22 | 1 | -1/+2 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ↵ | Jeroen van Dijk | 2010-06-21 | 2 | -379/+210 | |
| | | | | | | | | | | | | | | | | hash and make various Validators pass their (filtered) options. This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format". Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation. Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options). Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now. The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet. Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | ActiveModel::Validations::Callbacks should not be required by default. | José Valim | 2010-06-19 | 1 | -0/+1 | |
| | ||||||
* | moving before_validation and after_validation functionality from ↵ | Neeraj Singh | 2010-06-19 | 1 | -0/+76 | |
| | | | | | | | | ActiveRecord to ActiveModel [#4653 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Really make include_root_in_json default to true [#3770 state:resolved] | José Valim | 2010-06-08 | 1 | -15/+21 | |
| | ||||||
* | Fix xml serialization test [#4650 state:resolved] | Anil Wadghule | 2010-05-19 | 1 | -2/+5 | |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Use better assertion methods for testing | Neeraj Singh | 2010-05-19 | 4 | -5/+5 | |
| | | | | | | [#4645 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Add a valid hex that shouldn't be valid to ActiveModel numericality tests ↵ | rohit | 2010-05-18 | 1 | -1/+1 | |
| | | | | | | [#4622 state:commited] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Valid hex strings aren't valid float column values, to match the integer ↵ | Jeremy Kemper | 2010-05-17 | 1 | -1/+1 | |
| | | | | restriction. [#4622 state:resolved] | |||||
* | Make use of assert_equal to test equallity between object assert expects and ↵ | Santiago Pastorino | 2010-05-16 | 2 | -3/+3 | |
| | | | | | | | | object and a message of error [#4611 state:committed] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Revert "Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an ↵ | José Valim | 2010-05-15 | 2 | -73/+73 | |
| | | | | | | | | options hash and make various Validators pass their (filtered) options." Having a huge array to whitelist options is not the proper way to handle this case. This means that the ActiveModel::Errors object should know about the options given in *all* validators and break the extensibility added by the validators itself. If the intent is to whitelist options before sending them to I18n, each validator should clean its respective options instead of throwing the responsibility to the Errors object. This reverts commit bc1c8d58ec45593acba614d1d0fecb49adef08ff. |