aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/test
Commit message (Collapse)AuthorAgeFilesLines
* :if should not fire on validations when not in context with :onAditya Sanghi2011-04-291-0/+14
|
* Add additional tests for AM::ObserverArray that I had missed yesterday.Myron Marston2011-04-281-1/+50
|
* Fix bug with AM::Observer disablement.Myron Marston2011-04-281-0/+10
| | | | | Now that we propagate the enabling/disabling to descendants, we no longer have to check the disabled_observer Set on each superclass of the model class. This was causing a bug when disabling all observers at a superclass level and then enabling an individual observer at a subclass level. Plus the logic is simpler now :).
* Revert "Revert "Handle enabling/disabling observers at different levels of ↵Myron Marston2011-04-281-0/+39
| | | | | | | | | the class hierarchy."" This reverts commit 2a25c5818b03d7d6cd63aad180bff23479dbd861. I'm going to add another commit that keeps the same behavior of fixes the problems of leaking memory in development.
* Revert "Handle enabling/disabling observers at different levels of the class ↵José Valim2011-04-281-39/+0
| | | | | | | | | | hierarchy." This reverts commit ad62f1928768bd2676958a4a08512bad342fe469 because the current subclasses implementation leaks memory in development. Instead of keeping an array of subclasses, the better solution is to ask the parent if an observer is being disabled or not.
* Handle enabling/disabling observers at different levels of the class hierarchy.Myron Marston2011-04-281-0/+39
| | | | Last call wins.
* Allow observers to be enabled and disabled.Myron Marston2011-04-283-0/+154
| | | | This is useful in situations like model unit tests and the occasional rake task to backfill old data.
* AM mass assignment security attr_accessible and attr_protected now allow for ↵Josh Kalderimis2011-04-243-11/+50
| | | | | | | | scopes using :as => scope eg. attr_accessible :name attr_accessible :name, :admin, :as => :admin
* bcrypt will encrypt anything, so validate_presence_of would not catch nil / ↵Aaron Patterson2011-04-141-0/+12
| | | | blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this
* No need to rescue here. Invoking the wrong method in an object can happen ↵José Valim2011-04-113-34/+0
| | | | anywhere if you are not careful. In other words, test your shit.
* Revert "Add :use_include option to allow user to explicitly use ↵José Valim2011-04-112-19/+0
| | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67.
* Using Object#in? and Object#either? in various placesPrem Sichanugrist2011-04-111-1/+2
| | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
* Add :use_include option to allow user to explicitly use `Range#include?` ↵Prem Sichanugrist2011-04-102-0/+19
| | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option.
* Add support for proc or lambda as an option for InclusionValidator, ↵Prem Sichanugrist2011-04-103-0/+82
| | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator
* Rename test directory to match code directoryJohn Firebaugh2011-04-062-0/+0
| | | | Hopefully "serializeration" is not an in joke that I missed.
* Do not in place modify what table_name returnsSantiago Pastorino2011-03-221-11/+0
|
* define_attr_method should be able to define methods that returns nilSantiago Pastorino2011-03-171-0/+2
|
* dup strings on return so that in place modifications do not break anything. ↵Aaron Patterson2011-03-171-0/+11
| | | | I am looking at you "compute_table_name"
* define_attr_method correctly defines methods with invalid identifiersSantiago Pastorino2011-03-161-2/+4
|
* Add a define_attr_method testSantiago Pastorino2011-03-161-0/+13
|
* Add test for define_attr_method using as name an invalid identifierSantiago Pastorino2011-03-161-0/+13
|
* Add test for define_attribute_method using as name an invalid identifierSantiago Pastorino2011-03-161-3/+26
|
* Refactor length validationSantiago Pastorino2011-03-121-3/+3
|
* length validation for fixnumsAndriy Tyurnikov2011-03-121-0/+11
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Active Model typos.R.T. Lechow2011-03-051-1/+1
|
* Move ActiveModel::AttributeMethods#attribute_methods_generated? to ↵Alexander Uvarov2011-03-011-3/+7
| | | | | | | | ActiveRecord, so it's flexible now [#6428 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]"Santiago Pastorino2011-02-272-24/+0
| | | | | | | This breaks #6448, you should use :"module/class" as key for namespacing [#6448 state:committed] This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557.
* failing test for i18n key collision with namespaced modelsSantiago Pastorino2011-02-272-0/+11
|
* Change validates inclusion to use cover? for Ranges in ruby 1.9 [#6453 ↵Frederick Cheung2011-02-181-0/+9
| | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com>
* Override attributes_protected_by_default when has_secure_password is called.Tsutomu Kuroda2011-02-093-0/+32
| | | | | | | attr_protected should not be called, because it nullifies the mass assignment protection that has been set by attr_accessible. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* implementing include? on AM::ErrorsAaron Patterson2011-02-091-0/+6
|
* Find all validators for multiple attributesCarl Lerche2011-02-051-0/+18
|
* Optionally pass in the attribute being validated to an instance method validatorCarl Lerche2011-02-052-0/+13
|
* Be able to pass a validator method to #validatesCarl Lerche2011-02-052-0/+16
|
* Provide a way to specify alternate option keys for validatesCarl Lerche2011-02-052-0/+15
|
* Do not require that validation attributes be specified as symbolsCarl Lerche2011-02-051-0/+11
|
* allow spaces and other characters in attribute names [#4725 state:resolved]Caleb Land2011-02-031-0/+30
| | | | | | | | * define the dynamically defined methods with 'define_method' instead of def * wrap some string injected method names in quotes Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use run_callbacks; the generated _run_<name>_callbacks method is not a ↵John Firebaugh2011-01-311-2/+2
| | | | | | public interface. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* psych does not emit a space after the tagAaron Patterson2011-01-211-1/+1
|
* fix difference between behaviour of blank and emptyHemant Kumar2011-01-051-0/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Tests and docs which explain the use of validate with a block and without ↵Santiago Pastorino2010-12-191-1/+9
| | | | arguments
* Remove weak_passwords list and the length/strong password validator, leave ↵Santiago Pastorino2010-12-191-49/+1
| | | | that up to the programmer
* Add set_weak_passwords call in alignment with set_table_name.Mikel Lindsaar2010-12-191-0/+5
|
* Added ability to specify which passwords you want as weak passwordsMikel Lindsaar2010-12-191-11/+31
|
* Make password messages translatable.José Valim2010-12-191-1/+1
|
* Avoid warnings and fix small typo on SecurePassword.José Valim2010-12-191-1/+3
|
* BCrypt does its own salting, lovely!David Heinemeier Hansson2010-12-181-0/+11
|
* Added ActiveRecord::Base#has_secure_password (via ↵David Heinemeier Hansson2010-12-182-0/+50
| | | | ActiveModel::SecurePassword) to encapsulate dead-simple password usage with SHA2 encryption and salting
* This is not an executable fileSantiago Pastorino2010-12-161-0/+0
|
* Add support for namespaced validatorsSamuel Kadolph2010-12-162-0/+14
| | | | | | Includes test and documentation for new feature Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>