Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fixed test "ArgumentError: wrong number of arguments(1 for 0)" | Arun Agrawal | 2011-12-17 | 1 | -1/+1 |
| | |||||
* | Fixed bug when error message is an empty string. | Antonio Roberto | 2011-12-16 | 1 | -0/+6 |
| | |||||
* | Improve cache on route_key lookup. | José Valim | 2011-12-08 | 1 | -0/+8 |
| | |||||
* | ActiveModel::Name#i18n_key: Fix doc and add tests | Marc-Andre Lafortune | 2011-12-05 | 1 | -0/+20 |
| | |||||
* | Namespaced attribute lookup now works as 'model/association.attribute'. | José Valim | 2011-12-05 | 1 | -5/+5 |
| | |||||
* | Merge pull request #3859 from kuroda/human_attribute_name | José Valim | 2011-12-05 | 1 | -0/+10 |
|\ | | | | | Fix human_attribute_name to handle names with dots | ||||
| * | Fix human_attribute_name to handle names with dots | Tsutomu Kuroda | 2011-12-05 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | Nested I18n namespace lookup under activerecord.models is deprecated now (c19bd4f). But when a model uses accepts_nested_attributes_for, its Errors object can have an attribute name with "addresses.street" style. In this case, the dots should be substituted with slashes so that we can provide the translation under the "activemodel.attributes.person.addresses/street" key. | ||||
* | | Revert "Implement ArraySerializer and move old serialization API to a new ↵ | José Valim | 2011-11-30 | 3 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb | ||||
* | | fix method redefined warning in activemodel | lest | 2011-11-30 | 2 | -1/+5 |
| | | |||||
* | | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 1 | -5/+18 |
| | | | | | | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | ||||
* | | Warning removed unused variable | Arun Agrawal | 2011-11-26 | 1 | -1/+1 |
| | | |||||
* | | Revert the serializers API as other alternatives are now also under discussion | José Valim | 2011-11-25 | 1 | -432/+0 |
| | | |||||
* | | Merge branch 'serializers' | José Valim | 2011-11-25 | 4 | -5/+437 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | This implements the ActiveModel::Serializer object. Includes code, tests, generators and guides. From José and Yehuda with love. Conflicts: railties/CHANGELOG.md | ||||
| * | | Rename UserSerializer to DefaultUserSerializer in tests. | José Valim | 2011-11-23 | 1 | -15/+13 |
| | | | |||||
| * | | Rely solely on active_model_serializer and remove the fancy constant lookup. | José Valim | 2011-11-23 | 1 | -34/+3 |
| | | | |||||
| * | | Implement ArraySerializer and move old serialization API to a new namespace. | José Valim | 2011-11-23 | 4 | -8/+67 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer. | ||||
| * | | Merge branch 'master' into serializers | José Valim | 2011-11-23 | 7 | -40/+128 |
| |\ \ | |||||
| * | | | Remove 1.9 Hash syntax - tests passing on 1.8.7 | Jose and Yehuda | 2011-10-15 | 1 | -3/+3 |
| | | | | |||||
| * | | | Add initial support for embed API | Jose and Yehuda | 2011-10-15 | 1 | -4/+82 |
| | | | | |||||
| * | | | Add support for the root attribute | Jose and Yehuda | 2011-10-15 | 1 | -14/+62 |
| | | | | |||||
| * | | | Fix nil has_one association | Jose and Yehuda | 2011-10-15 | 1 | -0/+18 |
| | | | | |||||
| * | | | Add association_ids | Jose and Yehuda | 2011-10-15 | 1 | -1/+60 |
| | | | | |||||
| * | | | Add support for overriding associations, mostly used for authorization | Jose and Yehuda | 2011-10-15 | 1 | -0/+26 |
| | | | | |||||
| * | | | Add support for implicit serializers | Jose and Yehuda | 2011-10-15 | 1 | -2/+33 |
| | | | | |||||
| * | | | Added has_one and has_many | Jose and Yehuda | 2011-10-15 | 1 | -5/+76 |
| | | | | |||||
| * | | | Don't require serializable_hash to take options. | Jose and Yehuda | 2011-10-15 | 1 | -2/+2 |
| | | | | |||||
| * | | | Initial implementation of ActiveModel::Serializer | Jose and Yehuda | 2011-10-15 | 1 | -0/+75 |
| | | | | |||||
* | | | | make ActiveModel::Name fail gracefully with anonymous classes | Jakub Kuźma | 2011-11-24 | 1 | -0/+13 |
| |/ / |/| | | |||||
* | | | Rely on a public contract between railties instead of accessing railtie ↵ | José Valim | 2011-11-23 | 2 | -10/+36 |
| | | | | | | | | | | | | methods directly. | ||||
* | | | Update variable's name in the test case to reflect the class we're testing | Prem Sichanugrist | 2011-11-18 | 3 | -24/+24 |
| | | | |||||
* | | | Revert "Merge pull request #2378 from cesario/remove_warnings_activemodel" | Jon Leighton | 2011-11-05 | 1 | -1/+0 |
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 6aaae3de277b572f37e09f16ae12737c3c87dfb7, reversing changes made to fdbc4e5f4e5746ebf558485348c841b33f038fda. Reason: build failure. | ||||
* | | | Merge pull request #2378 from cesario/remove_warnings_activemodel | Vijay Dev | 2011-11-05 | 1 | -0/+1 |
|\ \ \ | | | | | | | | | Remove warnings by calling remove_method | ||||
| * | | | Remove warnings by calling remove_method | Franck Verrot | 2011-07-31 | 1 | -0/+1 |
| | | | | |||||
* | | | | New #added? method on ActiveModel::Errors | Martin Svalin | 2011-10-19 | 1 | -0/+43 |
| | | | | | | | | | | | | The #added? method makes it possible to check if a specific error has been added, using the same parameters as for #add. | ||||
* | | | | use variables from test setup | Vijay Dev | 2011-10-17 | 1 | -6/+4 |
| | | | | |||||
* | | | | ActiveModel::Errors#generate_message without i18n_scope, and more test cases ↵ | Martin Svalin | 2011-10-17 | 1 | -0/+21 |
| |/ / |/| | | | | | | | | for #add | ||||
* | | | Fixed serialization issues with multiple includes with options | zhengjia | 2011-10-11 | 1 | -0/+8 |
| | | | |||||
* | | | One of the activemodel naming tests wasn't asserting anything. | Uģis Ozols | 2011-10-07 | 1 | -1/+1 |
| | | | |||||
* | | | Provide read_attribute_for_serialization as the API to serialize attributes. | José Valim | 2011-09-30 | 1 | -3/+3 |
| | | | |||||
* | | | Fixing `as_json` method for ActiveRecord models. | Nicolás Hock Isaza | 2011-09-29 | 1 | -0/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you've got an AR Model and you override the `as_json` method, you should be able to add default options to the renderer, like this: class User < ActiveRecord::Base def as_json(options = {}) super(options.merge(:except => [:password_digest])) end end This was not possible before this commit. See the added test case. | ||||
* | | | Make serializable_hash take attr values directly from attributes hash. | Jon Leighton | 2011-09-26 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, it would use send() to get the attribute. In Active Resource, this would rely on hitting method missing. If a method with the same name was defined further up the ancestor chain, that method would wrongly be called. This change fixes test_to_xml_with_private_method_name_as_attribute in activeresource/test/cases/base_test.rb, which was broken after 51bef9d8fb0b4da7a104425ab8545e9331387743, because that change made to_xml use serializable_hash. | ||||
* | | | fixed a bug with the json serialization when the class setting is set to not ↵ | Matt Aimonetti | 2011-09-22 | 1 | -0/+10 |
| | | | | | | | | | | | | include the root, but an instance is serialized with the root option passed as true | ||||
* | | | to_xml should also rely on serializable hash. | José Valim | 2011-09-18 | 1 | -0/+17 |
| | | | |||||
* | | | Generate attribute method unless it's already in the module. | Jon Leighton | 2011-09-14 | 1 | -0/+23 |
| | | | | | | | | | | | | | | | | | | | | | There's no harm in generating a method name that's already defined on the host class, since we're generating the attribute methods in a module that gets included. In fact, this is desirable as it allows the host class to call super. | ||||
* | | | Add an attribute_missing method to ActiveModel::AttributeMethods. | Jon Leighton | 2011-09-13 | 1 | -0/+15 |
| | | | | | | | | | | | | This can be overloaded by implementors if necessary. | ||||
* | | | Let Ruby deal with method visibility. | Jon Leighton | 2011-09-13 | 1 | -0/+36 |
| | | | | | | | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary. | ||||
* | | | Add deprecation for doing `attribute_method_suffix ''` | Jon Leighton | 2011-09-13 | 1 | -6/+11 |
| | | | |||||
* | | | Use an empty AttributeMethodMatcher by default. | Jon Leighton | 2011-09-13 | 1 | -0/+17 |
| | | | | | | | | | | | | | | | | | | This means that attribute methods which don't exist will get generated when define_attribute_methods is called, so we don't have to use hacks like `attribute_method_suffix ''`. | ||||
* | | | Added test for obj.errors.as_json | Lawrence Pit | 2011-09-09 | 1 | -0/+11 |
| | | | |||||
* | | | Add ability to get an individual full error message + test for full_messages. | Lawrence Pit | 2011-09-09 | 1 | -2/+18 |
| |/ |/| |