Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Handle enabling/disabling observers at different levels of the class ↵ | José Valim | 2011-04-28 | 1 | -39/+0 |
| | | | | | | | | | | hierarchy." This reverts commit ad62f1928768bd2676958a4a08512bad342fe469 because the current subclasses implementation leaks memory in development. Instead of keeping an array of subclasses, the better solution is to ask the parent if an observer is being disabled or not. | ||||
* | Handle enabling/disabling observers at different levels of the class hierarchy. | Myron Marston | 2011-04-28 | 1 | -0/+39 |
| | | | | Last call wins. | ||||
* | Allow observers to be enabled and disabled. | Myron Marston | 2011-04-28 | 3 | -0/+154 |
| | | | | This is useful in situations like model unit tests and the occasional rake task to backfill old data. | ||||
* | AM mass assignment security attr_accessible and attr_protected now allow for ↵ | Josh Kalderimis | 2011-04-24 | 3 | -11/+50 |
| | | | | | | | | scopes using :as => scope eg. attr_accessible :name attr_accessible :name, :admin, :as => :admin | ||||
* | bcrypt will encrypt anything, so validate_presence_of would not catch nil / ↵ | Aaron Patterson | 2011-04-14 | 1 | -0/+12 |
| | | | | blank passwords. Thank you to Aleksander Kamil Modzelewski for reporting this | ||||
* | No need to rescue here. Invoking the wrong method in an object can happen ↵ | José Valim | 2011-04-11 | 3 | -34/+0 |
| | | | | anywhere if you are not careful. In other words, test your shit. | ||||
* | Revert "Add :use_include option to allow user to explicitly use ↵ | José Valim | 2011-04-11 | 2 | -19/+0 |
| | | | | | | | | `Range#include?` method in Ruby 1.9" Use :with => range.to_a instead. This reverts commit f6540211b5b9133c9f93c11655a04d613c237e67. | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Add :use_include option to allow user to explicitly use `Range#include?` ↵ | Prem Sichanugrist | 2011-04-10 | 2 | -0/+19 |
| | | | | | | method in Ruby 1.9 In Ruby 1.9 we're currently use `Range#cover?` to fix the performance problem. However, there might be the case that you want to use `Range#include?` instead. This patch will give you that option. | ||||
* | Add support for proc or lambda as an option for InclusionValidator, ↵ | Prem Sichanugrist | 2011-04-10 | 3 | -0/+82 |
| | | | | | | ExclusionValidator, and FormatValidator You can now use a proc or lambda in :in option for InclusionValidator and ExclusionValidator, and :with, :without option for FormatValidator | ||||
* | Rename test directory to match code directory | John Firebaugh | 2011-04-06 | 2 | -0/+0 |
| | | | | Hopefully "serializeration" is not an in joke that I missed. | ||||
* | Do not in place modify what table_name returns | Santiago Pastorino | 2011-03-22 | 1 | -11/+0 |
| | |||||
* | define_attr_method should be able to define methods that returns nil | Santiago Pastorino | 2011-03-17 | 1 | -0/+2 |
| | |||||
* | dup strings on return so that in place modifications do not break anything. ↵ | Aaron Patterson | 2011-03-17 | 1 | -0/+11 |
| | | | | I am looking at you "compute_table_name" | ||||
* | define_attr_method correctly defines methods with invalid identifiers | Santiago Pastorino | 2011-03-16 | 1 | -2/+4 |
| | |||||
* | Add a define_attr_method test | Santiago Pastorino | 2011-03-16 | 1 | -0/+13 |
| | |||||
* | Add test for define_attr_method using as name an invalid identifier | Santiago Pastorino | 2011-03-16 | 1 | -0/+13 |
| | |||||
* | Add test for define_attribute_method using as name an invalid identifier | Santiago Pastorino | 2011-03-16 | 1 | -3/+26 |
| | |||||
* | Refactor length validation | Santiago Pastorino | 2011-03-12 | 1 | -3/+3 |
| | |||||
* | length validation for fixnums | Andriy Tyurnikov | 2011-03-12 | 1 | -0/+11 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Active Model typos. | R.T. Lechow | 2011-03-05 | 1 | -1/+1 |
| | |||||
* | Move ActiveModel::AttributeMethods#attribute_methods_generated? to ↵ | Alexander Uvarov | 2011-03-01 | 1 | -3/+7 |
| | | | | | | | | ActiveRecord, so it's flexible now [#6428 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]" | Santiago Pastorino | 2011-02-27 | 2 | -24/+0 |
| | | | | | | | This breaks #6448, you should use :"module/class" as key for namespacing [#6448 state:committed] This reverts commit 8d30193b08bd2321a7a78a1f481bd5e4d4d45557. | ||||
* | failing test for i18n key collision with namespaced models | Santiago Pastorino | 2011-02-27 | 2 | -0/+11 |
| | |||||
* | Change validates inclusion to use cover? for Ranges in ruby 1.9 [#6453 ↵ | Frederick Cheung | 2011-02-18 | 1 | -0/+9 |
| | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | ||||
* | Override attributes_protected_by_default when has_secure_password is called. | Tsutomu Kuroda | 2011-02-09 | 3 | -0/+32 |
| | | | | | | | attr_protected should not be called, because it nullifies the mass assignment protection that has been set by attr_accessible. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | implementing include? on AM::Errors | Aaron Patterson | 2011-02-09 | 1 | -0/+6 |
| | |||||
* | Find all validators for multiple attributes | Carl Lerche | 2011-02-05 | 1 | -0/+18 |
| | |||||
* | Optionally pass in the attribute being validated to an instance method validator | Carl Lerche | 2011-02-05 | 2 | -0/+13 |
| | |||||
* | Be able to pass a validator method to #validates | Carl Lerche | 2011-02-05 | 2 | -0/+16 |
| | |||||
* | Provide a way to specify alternate option keys for validates | Carl Lerche | 2011-02-05 | 2 | -0/+15 |
| | |||||
* | Do not require that validation attributes be specified as symbols | Carl Lerche | 2011-02-05 | 1 | -0/+11 |
| | |||||
* | allow spaces and other characters in attribute names [#4725 state:resolved] | Caleb Land | 2011-02-03 | 1 | -0/+30 |
| | | | | | | | | * define the dynamically defined methods with 'define_method' instead of def * wrap some string injected method names in quotes Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Use run_callbacks; the generated _run_<name>_callbacks method is not a ↵ | John Firebaugh | 2011-01-31 | 1 | -2/+2 |
| | | | | | | public interface. Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | psych does not emit a space after the tag | Aaron Patterson | 2011-01-21 | 1 | -1/+1 |
| | |||||
* | fix difference between behaviour of blank and empty | Hemant Kumar | 2011-01-05 | 1 | -0/+6 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Tests and docs which explain the use of validate with a block and without ↵ | Santiago Pastorino | 2010-12-19 | 1 | -1/+9 |
| | | | | arguments | ||||
* | Remove weak_passwords list and the length/strong password validator, leave ↵ | Santiago Pastorino | 2010-12-19 | 1 | -49/+1 |
| | | | | that up to the programmer | ||||
* | Add set_weak_passwords call in alignment with set_table_name. | Mikel Lindsaar | 2010-12-19 | 1 | -0/+5 |
| | |||||
* | Added ability to specify which passwords you want as weak passwords | Mikel Lindsaar | 2010-12-19 | 1 | -11/+31 |
| | |||||
* | Make password messages translatable. | José Valim | 2010-12-19 | 1 | -1/+1 |
| | |||||
* | Avoid warnings and fix small typo on SecurePassword. | José Valim | 2010-12-19 | 1 | -1/+3 |
| | |||||
* | BCrypt does its own salting, lovely! | David Heinemeier Hansson | 2010-12-18 | 1 | -0/+11 |
| | |||||
* | Added ActiveRecord::Base#has_secure_password (via ↵ | David Heinemeier Hansson | 2010-12-18 | 2 | -0/+50 |
| | | | | ActiveModel::SecurePassword) to encapsulate dead-simple password usage with SHA2 encryption and salting | ||||
* | This is not an executable file | Santiago Pastorino | 2010-12-16 | 1 | -0/+0 |
| | |||||
* | Add support for namespaced validators | Samuel Kadolph | 2010-12-16 | 2 | -0/+14 |
| | | | | | | Includes test and documentation for new feature Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Test using default option as symbol added for human_attribute_name | Santiago Pastorino | 2010-12-05 | 1 | -0/+5 |
| | |||||
* | default could be a symbol here so attribute.to_s.humanize should be the ↵ | Santiago Pastorino | 2010-12-05 | 1 | -0/+4 |
| | | | | final option | ||||
* | Test falling back to default added for human_attribute_name | Santiago Pastorino | 2010-12-05 | 1 | -0/+4 |
| | |||||
* | Test using default option added for human_attribute_name | Santiago Pastorino | 2010-12-05 | 1 | -0/+4 |
| |