aboutsummaryrefslogtreecommitdiffstats
path: root/activemodel/test/cases
Commit message (Collapse)AuthorAgeFilesLines
* Fix ActiveModel::Errors#dupPaweł Kondzior2012-01-161-0/+8
| | | | | | | | | | | | Since ActiveModel::Errors instance keeps all error messages as hash we should duplicate this object as well. Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash, which results in different behavior on dup, this may result in regression for people relying on it. Because Rails 3.2 stills supports Ruby 1.8.7 in order to properly fix this regression we need to backport #initialize_dup.
* Apparently asssert_empty is not available in 1.8.7Piotr Sarnacki2012-01-161-1/+1
|
* Add ActiveModel::Errors#delete, which was not available after move to use ↵Piotr Sarnacki2012-01-161-0/+7
| | | | delegation
* Fix stack level too deep when model does not have attributes method.Piotr Sarnacki2012-01-151-0/+8
| | | | | | | | | | | Without that patch when using ActiveModel::AttributeMethods in a class that does not respond to `attributes` method, stack level too deep error will be raised on non existing method. While documentation is clear that you need to define `attributes` method in order to use AttributeMethods module, `stack level too deep` is rather obscure and hard to debug, therefore we should try to not break `method_missing` if someone forgets about defining `attributes`.
* Fixed test "ArgumentError: wrong number of arguments(1 for 0)"Arun Agrawal2011-12-171-1/+1
|
* Fixed bug when error message is an empty string.Antonio Roberto2011-12-161-0/+6
|
* Improve cache on route_key lookup.José Valim2011-12-081-0/+8
|
* ActiveModel::Name#i18n_key: Fix doc and add testsMarc-Andre Lafortune2011-12-051-0/+20
|
* Namespaced attribute lookup now works as 'model/association.attribute'.José Valim2011-12-051-5/+5
|
* Merge pull request #3859 from kuroda/human_attribute_nameJosé Valim2011-12-051-0/+10
|\ | | | | Fix human_attribute_name to handle names with dots
| * Fix human_attribute_name to handle names with dotsTsutomu Kuroda2011-12-051-0/+10
| | | | | | | | | | | | | | | | Nested I18n namespace lookup under activerecord.models is deprecated now (c19bd4f). But when a model uses accepts_nested_attributes_for, its Errors object can have an attribute name with "addresses.street" style. In this case, the dots should be substituted with slashes so that we can provide the translation under the "activemodel.attributes.person.addresses/street" key.
* | Revert "Implement ArraySerializer and move old serialization API to a new ↵José Valim2011-11-303-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | namespace." This reverts commit 8896b4fdc8a543157cdf4dfc378607ebf6c10ab0. Conflicts: activemodel/lib/active_model.rb activemodel/lib/active_model/serializable.rb activemodel/lib/active_model/serializer.rb activemodel/test/cases/serializer_test.rb
* | fix method redefined warning in activemodellest2011-11-302-1/+5
| |
* | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`Jon Leighton2011-11-291-5/+18
| | | | | | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated.
* | Warning removed unused variableArun Agrawal2011-11-261-1/+1
| |
* | Revert the serializers API as other alternatives are now also under discussionJosé Valim2011-11-251-432/+0
| |
* | Merge branch 'serializers'José Valim2011-11-254-5/+437
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | This implements the ActiveModel::Serializer object. Includes code, tests, generators and guides. From José and Yehuda with love. Conflicts: railties/CHANGELOG.md
| * | Rename UserSerializer to DefaultUserSerializer in tests.José Valim2011-11-231-15/+13
| | |
| * | Rely solely on active_model_serializer and remove the fancy constant lookup.José Valim2011-11-231-34/+3
| | |
| * | Implement ArraySerializer and move old serialization API to a new namespace.José Valim2011-11-234-8/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer.
| * | Merge branch 'master' into serializersJosé Valim2011-11-236-34/+126
| |\ \
| * | | Remove 1.9 Hash syntax - tests passing on 1.8.7Jose and Yehuda2011-10-151-3/+3
| | | |
| * | | Add initial support for embed APIJose and Yehuda2011-10-151-4/+82
| | | |
| * | | Add support for the root attributeJose and Yehuda2011-10-151-14/+62
| | | |
| * | | Fix nil has_one associationJose and Yehuda2011-10-151-0/+18
| | | |
| * | | Add association_idsJose and Yehuda2011-10-151-1/+60
| | | |
| * | | Add support for overriding associations, mostly used for authorizationJose and Yehuda2011-10-151-0/+26
| | | |
| * | | Add support for implicit serializersJose and Yehuda2011-10-151-2/+33
| | | |
| * | | Added has_one and has_manyJose and Yehuda2011-10-151-5/+76
| | | |
| * | | Don't require serializable_hash to take options.Jose and Yehuda2011-10-151-2/+2
| | | |
| * | | Initial implementation of ActiveModel::SerializerJose and Yehuda2011-10-151-0/+75
| | | |
* | | | make ActiveModel::Name fail gracefully with anonymous classesJakub Kuźma2011-11-241-0/+13
| |/ / |/| |
* | | Rely on a public contract between railties instead of accessing railtie ↵José Valim2011-11-231-4/+34
| | | | | | | | | | | | methods directly.
* | | Update variable's name in the test case to reflect the class we're testingPrem Sichanugrist2011-11-183-24/+24
| | |
* | | Revert "Merge pull request #2378 from cesario/remove_warnings_activemodel"Jon Leighton2011-11-051-1/+0
| | | | | | | | | | | | | | | | | | | | | This reverts commit 6aaae3de277b572f37e09f16ae12737c3c87dfb7, reversing changes made to fdbc4e5f4e5746ebf558485348c841b33f038fda. Reason: build failure.
* | | Merge pull request #2378 from cesario/remove_warnings_activemodelVijay Dev2011-11-051-0/+1
|\ \ \ | | | | | | | | Remove warnings by calling remove_method
| * | | Remove warnings by calling remove_methodFranck Verrot2011-07-311-0/+1
| | | |
* | | | New #added? method on ActiveModel::ErrorsMartin Svalin2011-10-191-0/+43
| | | | | | | | | | | | The #added? method makes it possible to check if a specific error has been added, using the same parameters as for #add.
* | | | use variables from test setupVijay Dev2011-10-171-6/+4
| | | |
* | | | ActiveModel::Errors#generate_message without i18n_scope, and more test cases ↵Martin Svalin2011-10-171-0/+21
| |/ / |/| | | | | | | | for #add
* | | Fixed serialization issues with multiple includes with optionszhengjia2011-10-111-0/+8
| | |
* | | One of the activemodel naming tests wasn't asserting anything.Uģis Ozols2011-10-071-1/+1
| | |
* | | Provide read_attribute_for_serialization as the API to serialize attributes.José Valim2011-09-301-3/+3
| | |
* | | Fixing `as_json` method for ActiveRecord models.Nicolás Hock Isaza2011-09-291-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you've got an AR Model and you override the `as_json` method, you should be able to add default options to the renderer, like this: class User < ActiveRecord::Base def as_json(options = {}) super(options.merge(:except => [:password_digest])) end end This was not possible before this commit. See the added test case.
* | | Make serializable_hash take attr values directly from attributes hash.Jon Leighton2011-09-261-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, it would use send() to get the attribute. In Active Resource, this would rely on hitting method missing. If a method with the same name was defined further up the ancestor chain, that method would wrongly be called. This change fixes test_to_xml_with_private_method_name_as_attribute in activeresource/test/cases/base_test.rb, which was broken after 51bef9d8fb0b4da7a104425ab8545e9331387743, because that change made to_xml use serializable_hash.
* | | fixed a bug with the json serialization when the class setting is set to not ↵Matt Aimonetti2011-09-221-0/+10
| | | | | | | | | | | | include the root, but an instance is serialized with the root option passed as true
* | | to_xml should also rely on serializable hash.José Valim2011-09-181-0/+17
| | |
* | | Generate attribute method unless it's already in the module.Jon Leighton2011-09-141-0/+23
| | | | | | | | | | | | | | | | | | | | | There's no harm in generating a method name that's already defined on the host class, since we're generating the attribute methods in a module that gets included. In fact, this is desirable as it allows the host class to call super.
* | | Add an attribute_missing method to ActiveModel::AttributeMethods.Jon Leighton2011-09-131-0/+15
| | | | | | | | | | | | This can be overloaded by implementors if necessary.
* | | Let Ruby deal with method visibility.Jon Leighton2011-09-131-0/+36
| | | | | | | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary.